Page MenuHomePhabricator
Create Task
Maniphest T257993

Move Skin::getAllowedSkins and Skin::getSkinNames to SkinFactory and hard deprecate
Closed, ResolvedPublic
Actions

Description

The Skin::getAllowedSkins function is a wrapper for SkinFactory functions. It consults the value of $wgSkipSkins

acceptance criteria

  • Moved to SkinFactory.
  • Update BetaFeatures to use SkinFactory directly
  • Update GlobalCssJs to use SkinFactory directly
  • Update Gadgets to use SkinFactory directly
  • Update WikimediaMaintenance use SkinFactory directly
  • Skin::getAllowedSkins similar to Skin::getSkinNames uses MediaWikiServices::getInstance()->getSkinFactory();
  • Both Skin::getAllowedSkins and Skin::getSkinNames are marked as deprecated in 1.36

Details

SubjectRepoBranchLines +/-
Remove usages of Skin::getAllowedSkins.mediawiki/coremaster+102 -28
Deprecate Skin methods moved to SkinFactorymediawiki/coremaster+24 -66
Remove usage of Skin::getSkinNames()mediawiki/extensions/Gadgetsmaster+5 -2
Remove usage of Skin::getSkinNames()mediawiki/extensions/WikimediaMaintenancemaster+3 -1
Replace deprecated Skin methodmediawiki/extensions/GlobalCssJsmaster+2 -3
Replace deprecated Skin methodmediawiki/extensions/BetaFeaturesmaster+2 -1
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Jul 14 2020, 10:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 14 2020, 10:25 PM
Ammarpad claimed this task.Jul 15 2020, 6:32 AM
Jdlrobson moved this task from Phase 3 - standardise template data to Phase 2 - Deprecate and remove Skin methods for readability on the MediaWiki-Core-Skin-Architecture board.Jul 15 2020, 8:47 PM
gerritbot added a comment.Jul 25 2020, 2:46 AM

Change 616193 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Remove usages of Skin::getAllowedSkins.

https://gerrit.wikimedia.org/r/616193

gerritbot added a project: Patch-For-Review.Jul 25 2020, 2:46 AM
Jdlrobson triaged this task as Medium priority.Aug 4 2020, 8:46 PM
gerritbot added a comment.Aug 5 2020, 8:43 PM

Change 616193 merged by jenkins-bot:
[mediawiki/core@master] Remove usages of Skin::getAllowedSkins.

https://gerrit.wikimedia.org/r/616193

Jdlrobson updated the task description. (Show Details)Aug 5 2020, 8:47 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).Aug 5 2020, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 5 2020, 9:10 PM
gerritbot added a comment.Aug 12 2020, 1:49 PM

Change 619754 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/GlobalCssJs@master] Replace deprecated Skin method

https://gerrit.wikimedia.org/r/619754

gerritbot added a project: Patch-For-Review.Aug 12 2020, 1:49 PM

Change 619755 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/BetaFeatures@master] Replace deprecated Skin method

https://gerrit.wikimedia.org/r/619755

gerritbot added a comment.Aug 13 2020, 11:01 AM

Change 619755 merged by jenkins-bot:
[mediawiki/extensions/BetaFeatures@master] Replace deprecated Skin method

https://gerrit.wikimedia.org/r/619755

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.5; 2020-08-18); removed MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).Aug 13 2020, 12:00 PM
Jdlrobson updated the task description. (Show Details)Aug 13 2020, 10:14 PM
gerritbot added a comment.Aug 17 2020, 10:40 PM

Change 619754 merged by jenkins-bot:
[mediawiki/extensions/GlobalCssJs@master] Replace deprecated Skin method

https://gerrit.wikimedia.org/r/619754

Ammarpad updated the task description. (Show Details)Aug 17 2020, 11:07 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 17 2020, 11:10 PM
gerritbot added a comment.Aug 18 2020, 12:24 AM

Change 620808 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Deprecate Skin methods moved to SkinFatory

https://gerrit.wikimedia.org/r/620808

gerritbot added a project: Patch-For-Review.Aug 18 2020, 12:24 AM
Ammarpad added projects: MediaWiki-extensions-Gadgets, MediaWiki-extensions-WikimediaMaintenance.Aug 19 2020, 1:53 AM

Per code review comment, these should be hard deprecated. But before that, we need to update these extensions too

Ammarpad renamed this task from Move Skin::getAllowedSkins and Skin::getSkinNames to SkinFactory and soft deprecate to Move Skin::getAllowedSkins and Skin::getSkinNames to SkinFactory and hard deprecate.Aug 19 2020, 1:58 AM
Ammarpad updated the task description. (Show Details)
gerritbot added a comment.Aug 25 2020, 10:24 PM

Change 622438 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/Gadgets@master] Remove usage of Skin::getSkinNames()

https://gerrit.wikimedia.org/r/622438

gerritbot added a comment.Aug 25 2020, 10:28 PM

Change 622439 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/WikimediaMaintenance@master] Remove usage of Skin::getSkinNames()

https://gerrit.wikimedia.org/r/622439

gerritbot added a comment.Aug 26 2020, 11:50 AM

Change 622439 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMaintenance@master] Remove usage of Skin::getSkinNames()

https://gerrit.wikimedia.org/r/622439

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.8; 2020-09-08); removed MW-1.36-notes (1.36.0-wmf.5; 2020-08-18).Aug 26 2020, 12:00 PM
gerritbot added a comment.Aug 26 2020, 7:41 PM

Change 622438 merged by jenkins-bot:
[mediawiki/extensions/Gadgets@master] Remove usage of Skin::getSkinNames()

https://gerrit.wikimedia.org/r/622438

gerritbot added a comment.Aug 26 2020, 8:08 PM

Change 620808 merged by jenkins-bot:
[mediawiki/core@master] Deprecate Skin methods moved to SkinFactory

https://gerrit.wikimedia.org/r/620808

Ammarpad closed this task as Resolved.Aug 27 2020, 7:23 AM
Ammarpad updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL