Page MenuHomePhabricator
Create Task
Maniphest T258039

Add checkbox to fed props notification & set cookie to persist
Closed, ResolvedPublic
Actions

Description

Created during a breakdown session (more notes in T251102#6307821)
BDDs and design from T251102

Tech Notes
An example cookie that can be copied / looked at in wikibase code is wikidatawikiwikibase.acknowledgedcopyrightversion for the dismissing of the cc0 edit warning.
This same popup also saves this setting as a user preference when displayed to logged in users
We can likely find lots of the things we need by looking at that code.
https://codesearch.wmcloud.org/search/?q=acknowledgedcopyrightversion&i=nope&files=&repos=
https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/9b837c08f6ab1d05bf7e4f838737ad425b75b19a/repo/resources/wikibase.ui.entityViewInit.js

Details

SubjectRepoBranchLines +/-
Backport five FP changesmediawiki/extensions/WikibaseREL1_35+231 -23
FP: Persist leaving site noticemediawiki/extensions/Wikibasemaster+53 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

Addshore created this task.Jul 15 2020, 10:20 AM
Addshore moved this task from Backlog to Prioritized backlog (aka Ready to pick up) on the Wikibase - Federated Properties board.
Addshore triaged this task as Medium priority.Jul 22 2020, 8:43 AM
Addshore moved this task from Prioritized backlog (aka Ready to pick up) to Sprint 4/6 (Hike 2) on the Wikibase - Federated Properties board.
Addshore edited projects, added Wikibase - Federated Properties (Sprint 4/6 (Hike 2)); removed Wikibase - Federated Properties.
• toan claimed this task.Aug 10 2020, 10:59 AM
• toan moved this task from To do to Doing on the Wikibase - Federated Properties (Sprint 4/6 (Hike 2)) board.
gerritbot added a comment.Aug 10 2020, 1:03 PM

Change 619292 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] FP: add leaving site checkbox

https://gerrit.wikimedia.org/r/619292

gerritbot added a project: Patch-For-Review.Aug 10 2020, 1:03 PM
• toan moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 4/6 (Hike 2)) board.Aug 11 2020, 10:12 AM
gerritbot added a comment.Aug 11 2020, 2:51 PM

Change 619292 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Persist leaving site notice

https://gerrit.wikimedia.org/r/619292

Maintenance_bot removed a project: Patch-For-Review.Aug 11 2020, 3:10 PM
Rosalie_WMDE moved this task from Peer Review to Done on the Wikibase - Federated Properties (Sprint 4/6 (Hike 2)) board.Aug 11 2020, 3:12 PM
• Samantha_Alipio_WMDE closed this task as Resolved.Aug 21 2020, 11:40 AM
gerritbot added a comment.Feb 24 2021, 6:09 PM

Change 666715 had a related patch set uploaded (by Hoo man; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@REL1_35] Backport five FP changes

https://gerrit.wikimedia.org/r/666715

gerritbot added a project: Patch-For-Review.Feb 24 2021, 6:09 PM
gerritbot added a comment.Mar 4 2021, 2:48 PM

Change 666715 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@REL1_35] Backport five FP changes

https://gerrit.wikimedia.org/r/666715

Maintenance_bot removed a project: Patch-For-Review.Mar 4 2021, 3:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL