Page MenuHomePhabricator
Create Task
Maniphest T258325

Remove deprecated code from "ArticleToCategory2Hooks.php"
Closed, ResolvedPublic
Actions

Description

Reported on MediaWiki.org:

The suggestion is to replace $content = $rev->getText(); by $content = ContentHandler::getContentText($rev->getContent()); in "ArticleToCategory2Hooks.php". This is supposed to avoid errors on category pages.

Since I am not a developer ...

Details

SubjectRepoBranchLines +/-
Replace deprecated `$rev->getText()` callmediawiki/extensions/ArticleToCategory2REL1_35+1 -1
Replace deprecated `$rev->getText()` callmediawiki/extensions/ArticleToCategory2REL1_36+1 -1
Replace deprecated `$rev->getText()` callmediawiki/extensions/ArticleToCategory2master+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Kghbln created this task.Jul 18 2020, 2:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 18 2020, 2:55 PM
Aklapper added a subscriber: Peachey88.Jul 18 2020, 3:39 PM

@Peachey88 created MediaWiki-extensions-ArticleToCategory2 a while ago; wondering if any codebase maintainers asked for this tag and are aware?

Reedy renamed this task from Remmove deprecated code from "ArticleToCategory2Hooks.php" to Remove deprecated code from "ArticleToCategory2Hooks.php".Jul 18 2020, 4:08 PM
gerritbot added a comment.Apr 8 2021, 11:00 PM

Change 678112 had a related patch set uploaded (by Kghbln; author: Kghbln):

[mediawiki/extensions/ArticleToCategory2@master] Remove deprecated `$rev->getText();`

https://gerrit.wikimedia.org/r/678112

gerritbot added a project: Patch-For-Review.Apr 8 2021, 11:00 PM
gerritbot added a comment.Apr 8 2021, 11:11 PM

Change 678112 merged by jenkins-bot:

[mediawiki/extensions/ArticleToCategory2@master] Replace deprecated `$rev->getText()` call

https://gerrit.wikimedia.org/r/678112

gerritbot added a comment.Apr 8 2021, 11:14 PM

Change 678089 had a related patch set uploaded (by Kghbln; author: Kghbln):

[mediawiki/extensions/ArticleToCategory2@REL1_35] Replace deprecated `$rev->getText()` call

https://gerrit.wikimedia.org/r/678089

Reedy mentioned this in rEATC40b6c3159300: Replace deprecated `$rev->getText()` call.Apr 8 2021, 11:14 PM
gerritbot added a comment.Apr 8 2021, 11:15 PM

Change 678090 had a related patch set uploaded (by Kghbln; author: Kghbln):

[mediawiki/extensions/ArticleToCategory2@REL1_36] Replace deprecated `$rev->getText()` call

https://gerrit.wikimedia.org/r/678090

gerritbot added a comment.Apr 9 2021, 1:04 AM

Change 678090 merged by jenkins-bot:

[mediawiki/extensions/ArticleToCategory2@REL1_36] Replace deprecated `$rev->getText()` call

https://gerrit.wikimedia.org/r/678090

gerritbot added a comment.Apr 9 2021, 1:04 AM

Change 678089 merged by jenkins-bot:

[mediawiki/extensions/ArticleToCategory2@REL1_35] Replace deprecated `$rev->getText()` call

https://gerrit.wikimedia.org/r/678089

Kghbln mentioned this in rEATCf140428c0ba9: Replace deprecated `$rev->getText()` call.Apr 9 2021, 1:05 AM
Kghbln mentioned this in rEATC4921d6d206fc: Replace deprecated `$rev->getText()` call.
Maintenance_bot removed a project: Patch-For-Review.Apr 9 2021, 1:10 AM
Kghbln closed this task as Resolved.Apr 9 2021, 7:09 AM
Kghbln claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits