Page MenuHomePhabricator

Editing GeoJSON code in Visual Editor maps on Telugu Wiki sets keyboard cursor in wrong places, impossible to properly edit
Open, Needs TriagePublicBUG REPORT

Description

Steps to Reproduce:

  1. Create a map using Visual Editor map feature on Telugu wikipedia test page. Add a point feature Example url: https://te.wikipedia.org/wiki/%E0%B0%95%E0%B0%B0%E0%B1%8D%E0%B0%A8%E0%B1%82%E0%B0%B2%E0%B1%81?veaction=edit&section=6
  2. Try to edit Geojson code to add title in properties like "title": "ఉదాహరణ శీర్షిక"
  3. Cursor location fails after some typing and then adding or deleting Telugu or English characters creates errors.

4. Just move the cursor to different lines and you can see that cursor is not positioned at the end of text.

VE map GeoJSON editor cursor position problem.png (861×1 px, 152 KB)

This is similar to errors editing Javascript or Module pages in code mode.

Actual Results:

Editing results in mistakes, as cursor position is not correct.

Expected Results:
Proper cursor position for edit operations

Event Timeline

Aklapper renamed this task from Editing GeoJSON code in Visual Editor does not work for Telugu Wiki to Editing GeoJSON code in Visual Editor maps on Telugu Wiki sets keyboard cursor in wrong places, impossible to properly edit.Jul 19 2020, 8:13 AM

Hmm, cannot reproduce in Firefox 78 on https://te.wikipedia.org/wiki/%E0%B0%95%E0%B0%B0%E0%B1%8D%E0%B0%A8%E0%B1%82%E0%B0%B2%E0%B1%81?veaction=edit&section=6&uselang=en after clicking the Map, clicking "Edit", and choosing "Map Contents" (@Arjunaraoc: please always include full and complete steps to reproduce!). Which web browser has been used?

f.jpg (990×1 px, 276 KB)

@Arjunaraoc, this might caused by one of the gadget you have enabled. If possible, it would be great if listing all the gadget you are currently using, so we can find which gadget that cause conflicts with MediaWiki-extensions-CodeMirror.

Hmm, cannot reproduce in Firefox 78 on https://te.wikipedia.org/wiki/%E0%B0%95%E0%B0%B0%E0%B1%8D%E0%B0%A8%E0%B1%82%E0%B0%B2%E0%B1%81?veaction=edit&section=6&uselang=en after clicking the Map, clicking "Edit", and choosing "Map Contents" (@Arjunaraoc: please always include full and complete steps to reproduce!). Which web browser has been used?

f.jpg (990×1 px, 276 KB)

My environment is
Ubuntu 18.04 (Budgie)
Firefox 68.10.0esr(64 bit) snap
Wikipedia gadgets enabled exlinks, Gadget-Twinkle,, Hotcat,Charinsert,Reftoolbar,

I have disabled the above gadgets, but the problem is still present.

@Arjunaraoc, this might caused by one of the gadget you have enabled. If possible, it would be great if listing all the gadget you are currently using, so we can find which gadget that cause conflicts with MediaWiki-extensions-CodeMirror.

See my response at https://phabricator.wikimedia.org/T258338#6318055

I did not find the problem when using Chromium Version 83.0.4103.116 (Official Build) snap (64-bit). But it runs very slow on my system.

I have tried with firefox 78.0.2 (non-snap). I found enabling charinsert gadget is causing the cursor positioning problem when typing Telugu text.

Firefox 68.10.0esr(64 bit) snap
Wikipedia gadgets enabled exlinks, Gadget-Twinkle,, Hotcat,Charinsert,Reftoolbar,
I have disabled the above gadgets, but the problem is still present.

I have tried with firefox 78.0.2 (non-snap). I found enabling charinsert gadget is causing the cursor positioning problem when typing Telugu text.

Does that mean that disabling the CharInsert gadget fixes the problem in Firefox 78, but disabling the CharInsert gadget does NOT fix the problem in Firefox 68?

Sorry for my updates above, which were based on simple addition of text. But I found when I add Telugu text and then delete some characters, the problem remains in Firefox (68.10.0esr snap) , (nonsnap 78.0.2) and Chromium (83.0.4103.116) browsers.

With all gadgets disabled ,I checked on Windows 10, with Firefox 78, Edge version 18.18362, Chrome version 84.0.4147.89 and found the problem as most of my Telugu wikipedians use Windows. This needs to be fixed by mediawiki only.