Page MenuHomePhabricator
Create Task
Maniphest T258721

Cannot use 'object' as class name as it is reserved
Closed, ResolvedPublic
Actions

Description

In https://gerrit.wikimedia.org/r/615764 bumping MediaWiki-Codesniffer in MediaWiki-extensions-Score in MW-1.31-release

https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php72-noselenium-docker/1784/console

16:45:31 ...................................................PHP Fatal error:  Cannot use 'object' as class name as it is reserved in /workspace/src/vendor/phpunit/phpunit-mock-objects/src/Generator.php(264) : eval()'d code on line 1
16:45:31 
16:45:31 Fatal error: Cannot use 'object' as class name as it is reserved in /workspace/src/vendor/phpunit/phpunit-mock-objects/src/Generator.php(264) : eval()'d code on line 1

Details

SubjectRepoBranchLines +/-
Do not attempt to mock 'object'mediawiki/extensions/ConfirmEditREL1_31+8 -4
Customize query in gerrit

Event Timeline

Reedy created this task.Jul 23 2020, 3:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 23 2020, 3:48 PM
Reedy triaged this task as High priority.Jul 23 2020, 3:58 PM

Very unhelpfully, that line highlighted... https://github.com/sebastianbergmann/phpunit-mock-objects/blob/5.0/src/Generator.php#L264 is an eval() call

/**
 * @param string $code
 * @param string $className
 */
private function evalClass($code, $className)
{
    if (!\class_exists($className, false)) {
        eval($code);
    }
}

It doesn't seem to be a problem in MediaWiki-extensions-Score...

Let's do some more testing

Marking high as this is seemingly blocking merges into 1.31

gerritbot added a comment.Jul 23 2020, 3:59 PM

Change 615769 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_31] Testing T258721

https://gerrit.wikimedia.org/r/615769

gerritbot added a project: Patch-For-Review.Jul 23 2020, 4:00 PM
Reedy added a comment.Jul 23 2020, 4:10 PM

Core by itself is seemingly fine...

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/615769

To be really helpful, score has dependancies in CI

'Score': ['VisualEditor', 'TimedMediaHandler', 'Wikibase'],

Let's try testing those standalone...

gerritbot added a comment.Jul 23 2020, 4:11 PM

Change 615769 abandoned by Reedy:
[mediawiki/core@REL1_31] Testing T258721

Reason:

https://gerrit.wikimedia.org/r/615769

gerritbot added a comment.Jul 23 2020, 4:11 PM

Change 615770 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/VisualEditor@REL1_31] T258721

https://gerrit.wikimedia.org/r/615770

gerritbot added a comment.Jul 23 2020, 4:12 PM

Change 615771 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/TimedMediaHandler@REL1_31] T258721

https://gerrit.wikimedia.org/r/615771

gerritbot added a comment.Jul 23 2020, 4:12 PM

Change 615772 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Wikibase@REL1_31] T258721

https://gerrit.wikimedia.org/r/615772

Reedy added a comment.Jul 23 2020, 4:27 PM

It seems it's probably VE or a dependancy...

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/615770

Reedy edited projects, added VisualEditor, Wikidata, Wikidata-Campsite; removed MediaWiki-extensions-Score.Jul 23 2020, 4:29 PM

Or Wikibase or a dependancy...

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/615772

gerritbot added a comment.Jul 23 2020, 4:55 PM

Change 615771 abandoned by Reedy:
[mediawiki/extensions/TimedMediaHandler@REL1_31] T258721

Reason:

https://gerrit.wikimedia.org/r/615771

gerritbot added a comment.Jul 23 2020, 4:56 PM

Change 615775 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Cite@REL1_31] T258721

https://gerrit.wikimedia.org/r/615775

gerritbot added a comment.Jul 23 2020, 4:57 PM

Change 615776 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/ConfirmEdit@REL1_31] T258721

https://gerrit.wikimedia.org/r/615776

gerritbot added a comment.Jul 23 2020, 4:57 PM

Change 615777 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/FlaggedRevs@REL1_31] T258721

https://gerrit.wikimedia.org/r/615777

gerritbot added a comment.Jul 23 2020, 4:57 PM

Change 615778 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/ParserFunctions@REL1_31] T258721

https://gerrit.wikimedia.org/r/615778

gerritbot added a comment.Jul 23 2020, 4:58 PM

Change 615779 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Scribunto@REL1_31] T258721

https://gerrit.wikimedia.org/r/615779

gerritbot added a comment.Jul 23 2020, 4:58 PM

Change 615780 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/SyntaxHighlight_GeSHi@REL1_31] T258721

https://gerrit.wikimedia.org/r/615780

gerritbot added a comment.Jul 23 2020, 4:59 PM

Change 615781 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/TemplateData@REL1_31] T258721

https://gerrit.wikimedia.org/r/615781

gerritbot added a comment.Jul 23 2020, 4:59 PM

Change 615782 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/skins/Vector@REL1_31] T258721

https://gerrit.wikimedia.org/r/615782

gerritbot added a comment.Jul 23 2020, 5:04 PM

Change 615783 had a related patch set uploaded (by Reedy; owner: simetrical):
[mediawiki/extensions/ConfirmEdit@REL1_31] Do not attempt to mock 'object'

https://gerrit.wikimedia.org/r/615783

gerritbot added a comment.Jul 23 2020, 5:15 PM

Change 615783 merged by Reedy:
[mediawiki/extensions/ConfirmEdit@REL1_31] Do not attempt to mock 'object'

https://gerrit.wikimedia.org/r/615783

Reedy closed this task as Resolved.Jul 23 2020, 5:25 PM
Reedy claimed this task.

Fix to ConfirmEdit fixed this...

Onto the next uncovered bug

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 23 2020, 5:25 PM
gerritbot added a comment.Jul 23 2020, 5:31 PM

Change 615781 abandoned by Reedy:
[mediawiki/extensions/TemplateData@REL1_31] T258721

Reason:

https://gerrit.wikimedia.org/r/615781

gerritbot added a comment.Jul 23 2020, 5:39 PM

Change 615782 abandoned by Reedy:
[mediawiki/skins/Vector@REL1_31] T258721

Reason:

https://gerrit.wikimedia.org/r/615782

gerritbot added a comment.Jul 23 2020, 5:39 PM

Change 615776 abandoned by Reedy:
[mediawiki/extensions/ConfirmEdit@REL1_31] T258721

Reason:

https://gerrit.wikimedia.org/r/615776

gerritbot added a comment.Jul 23 2020, 5:42 PM

Change 615775 abandoned by Reedy:
[mediawiki/extensions/Cite@REL1_31] T258721

Reason:

https://gerrit.wikimedia.org/r/615775

gerritbot added a comment.Jul 23 2020, 5:42 PM

Change 615777 abandoned by Reedy:
[mediawiki/extensions/FlaggedRevs@REL1_31] T258721

Reason:

https://gerrit.wikimedia.org/r/615777

gerritbot added a comment.Jul 23 2020, 5:43 PM

Change 615779 abandoned by Reedy:
[mediawiki/extensions/Scribunto@REL1_31] T258721

Reason:

https://gerrit.wikimedia.org/r/615779

gerritbot added a comment.Jul 23 2020, 5:44 PM

Change 615772 abandoned by Reedy:
[mediawiki/extensions/Wikibase@REL1_31] T258721

Reason:

https://gerrit.wikimedia.org/r/615772

gerritbot added a comment.Jul 23 2020, 5:44 PM

Change 615770 abandoned by Reedy:
[mediawiki/extensions/VisualEditor@REL1_31] T258721

Reason:

https://gerrit.wikimedia.org/r/615770

gerritbot added a comment.Jul 23 2020, 5:44 PM

Change 615778 abandoned by Reedy:
[mediawiki/extensions/ParserFunctions@REL1_31] T258721

Reason:

https://gerrit.wikimedia.org/r/615778

gerritbot added a comment.Jul 23 2020, 5:44 PM

Change 615780 abandoned by Reedy:
[mediawiki/extensions/SyntaxHighlight_GeSHi@REL1_31] T258721

Reason:

https://gerrit.wikimedia.org/r/615780

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL