Page MenuHomePhabricator
Create Task
Maniphest T259400

Drop MonoBookAfterContent hook in favor of SkinAfterContent
Closed, ResolvedPublic
Actions

Description

The MonoBookAfterContent hook has been deprecated for some time. It can and should be replaced with SkinAfterContent.

Acceptance criteria

  • A patch for ShoutWiki exists
  • Drop Monobook::deprecatedHookHack inside Monobook skin
  • Shoutwiki patch has been merged

Details

SubjectRepoBranchLines +/-
Use SkinAfterContent hooks rather then deprecated hooks for Vector and Monobookmediawiki/extensions/ShoutWikiAdsREL1_35+15 -19
Use SkinAfterContent hooks rather then deprecated hooks for Vector and Monobookmediawiki/extensions/ShoutWikiAdsmaster+15 -19
Drop MonoBookAfterContent hookmediawiki/skins/MonoBookmaster+0 -28
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jul 31 2020, 10:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 31 2020, 10:56 PM
gerritbot added a comment.Aug 6 2020, 4:19 PM

Change 616581 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/ShoutWikiAds@master] Use SkinAfterContent hooks rather then deprecated hooks for Vector and Monobook

https://gerrit.wikimedia.org/r/616581

gerritbot added a project: Patch-For-Review.Aug 6 2020, 4:19 PM
Jdlrobson triaged this task as High priority.Sep 4 2020, 9:26 PM
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Sep 14 2020, 10:08 AM

Change 627244 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/MonoBook@master] Drop MonoBookAfterContent hook

https://gerrit.wikimedia.org/r/627244

Jdlrobson renamed this task from Drop MonoBookAfterContent hook to Drop MonoBookAfterContent hook in favor of SkinAfterContent.Sep 14 2020, 8:03 PM
Jdlrobson removed projects: MonoBook, MediaWiki-Core-Skin-Architecture.
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Sep 14 2020, 8:24 PM

Change 627244 merged by jenkins-bot:
[mediawiki/skins/MonoBook@master] Drop MonoBookAfterContent hook

https://gerrit.wikimedia.org/r/627244

Ammarpad mentioned this in rSMNB7f3581f05cbd: Drop MonoBookAfterContent hook.Sep 14 2020, 8:56 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 14 2020, 9:01 PM
gerritbot added a comment.Oct 29 2020, 9:41 PM

Change 616581 merged by jenkins-bot:
[mediawiki/extensions/ShoutWikiAds@master] Use SkinAfterContent hooks rather then deprecated hooks for Vector and Monobook

https://gerrit.wikimedia.org/r/616581

Maintenance_bot removed a project: Patch-For-Review.Oct 29 2020, 10:10 PM
Jdlrobson closed this task as Resolved.Oct 29 2020, 10:31 PM
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.May 14 2021, 10:43 PM

Change 691311 had a related patch set uploaded (by Umherirrender; author: Jdlrobson):

[mediawiki/extensions/ShoutWikiAds@REL1_35] Use SkinAfterContent hooks rather then deprecated hooks for Vector and Monobook

https://gerrit.wikimedia.org/r/691311

gerritbot added a project: Patch-For-Review.May 14 2021, 10:43 PM
gerritbot added a comment.May 15 2021, 12:23 AM

Change 691311 merged by jenkins-bot:

[mediawiki/extensions/ShoutWikiAds@REL1_35] Use SkinAfterContent hooks rather then deprecated hooks for Vector and Monobook

https://gerrit.wikimedia.org/r/691311

Jdlrobson mentioned this in Blog Post: How and why we moved our skins to Mustache.Jul 15 2022, 8:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits