Page MenuHomePhabricator

Echo-SpecialHelpMenuWidget aria-label message not declared in extension.json
Closed, ResolvedPublic

Description

In T244543
@Volker_E submitted a patch
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/597136/
to add aria-label to the SpecialHelpMenuWidget

but forgot to declare the new message in extension.json

The message wasn't generated.

Event Timeline

Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 17 2020, 2:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 620526 had a related patch set uploaded (by Tam-edwin-microsoft; owner: Tam-edwin-microsoft):
[mediawiki/extensions/Echo@master] Fix: Add newly created aria-label message to extension.json

https://gerrit.wikimedia.org/r/620526

Just found out the old Phabricator task T244543 that the original patch was fixing had multiple issues and is still open.
Sorry for opening a duplicate Task

Change 620526 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Fix: Add newly created aria-label message to extension.json

https://gerrit.wikimedia.org/r/620526

(In case there is no further work to do in this task and if all patches have been merged, feel free to resolve this task via Add Action...Change Status in the dropdown menu.)

Tam-edwin-microsoft closed this task as Resolved.Aug 17 2020, 4:07 PM