Page MenuHomePhabricator
Create Task
Maniphest T244543

Ensures every ARIA input field has an accessible name
Open, Needs TriagePublicBUG REPORT
Actions

Description

Steps to Reproduce:
Repro Steps:

  1. Navigate to Wiki Main page (enwiki example)
  2. Navigate till "Your Alerts" control and hit enter.
  3. Navigate till "All Notification" control and hit enter.

Actual Results:
Listbox does not have an aria-label attribute

Expected Results:

  • Listbox should contain aria-label attribute.
  • mw-echo-ui-readStateButtonSelectWidget carries role=listbox but no aria-label
  • mw-echo-ui-notificationItemWidget has no aria-label
  • mw-echo-ui-specialHelpMenuWidget is a button but has no aria-label

This accessibility issue was found using Accessibility Insights for Web 2.13.1 (axe-core 3.3.2), a tool that helps find and fix accessibility issues. Get more information & download this tool at http://aka.ms/AccessibilityInsights.

image.png (1×1 px, 138 KB)

Details

SubjectRepoBranchLines +/-
Add 'aria-label' to NotificationitemWidget and ReadStateButtonSelectWidgetmediawiki/extensions/Echomaster+9 -1
Add `aria-label` to SpecialHelpMenuWidgetmediawiki/extensions/Echomaster+4 -0
Add `aria-label` to Notifications page “Recent activity” filter widgetmediawiki/extensions/Echomaster+6 -2
Customize query in gerrit

Related Objects

Event Timeline

Akinwale-microsoft created this task.Feb 6 2020, 10:20 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptFeb 6 2020, 10:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Akinwale-microsoft updated the task description. (Show Details)Feb 6 2020, 10:20 PM
Aklapper added a project: Accessibility.Feb 7 2020, 12:32 PM
gerritbot added a comment.Feb 21 2020, 7:28 PM

Change 570730 had a related patch set uploaded (by Akinwale-microsoft; owner: Akinwale-microsoft):
[mediawiki/extensions/Echo@master] Fix: ListBox is not accessible to screen readers

https://gerrit.wikimedia.org/r/570730

gerritbot added a project: Patch-For-Review.Feb 21 2020, 7:28 PM
gerritbot added a comment.Apr 3 2020, 9:18 PM

Change 570730 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Add aria-label to Notifications page “Recent activity” filter widget

https://gerrit.wikimedia.org/r/570730

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.27; 2020-04-07).Apr 3 2020, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 3 2020, 10:10 PM
Volker_E updated the task description. (Show Details)May 18 2020, 7:20 PM
Volker_E added a subscriber: kostajh.
Volker_E updated the task description. (Show Details)May 18 2020, 7:26 PM
gerritbot added a comment.May 18 2020, 7:35 PM

Change 597136 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Echo@master] Add aria-label to SpecialHelpMenuWidget

https://gerrit.wikimedia.org/r/597136

gerritbot added a project: Patch-For-Review.May 18 2020, 7:35 PM
gerritbot added a comment.May 19 2020, 12:38 PM

Change 597136 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Add aria-label to SpecialHelpMenuWidget

https://gerrit.wikimedia.org/r/597136

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.34; 2020-05-26); removed MW-1.35-notes (1.35.0-wmf.27; 2020-04-07).May 19 2020, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 19 2020, 1:10 PM
Tam-edwin-microsoft mentioned this in T260505: Echo-SpecialHelpMenuWidget aria-label message not declared in extension.json.Aug 17 2020, 2:35 AM
gerritbot added a comment.Aug 17 2020, 6:28 AM

Change 620534 had a related patch set uploaded (by Tam-edwin-microsoft; owner: Tam-edwin-microsoft):
[mediawiki/extensions/Echo@master] Add 'aria-label' to NotificationitemWidget and ReadStateButtonSelectWidget

https://gerrit.wikimedia.org/r/620534

gerritbot added a project: Patch-For-Review.Aug 17 2020, 6:28 AM
Tam-edwin-microsoft updated the task description. (Show Details)Aug 17 2020, 6:32 AM
Tam-edwin-microsoft updated the task description. (Show Details)
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:51 PM
Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Aug 16 2022, 10:06 AM
Aklapper removed Akinwale-microsoft as the assignee of this task.Sep 26 2022, 10:24 AM

Removing task assignee due to inactivity as this open task has been assigned for more than two years. See the email sent to the task assignee on August 22nd, 2022.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome!
If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL