Page MenuHomePhabricator
Create Task
Maniphest T260606

Use RevisionLookup::getKnownLatestRevision instead of PrefetchingWikiPageEntityMetaDataAccessor
Open, LowPublic
Actions

Description

Follow up to T255305: [Investigation] - Consider if the Wikibase cache for CachingEntityRevisionLookup is needed any more.

RevisionLookup::getKnownLatestRevision() has a much better caching system than PrefetchingWikiPageEntityMetaDataAccessor which is a simple LRU cache that gets reset in every request.
This is doubly important since we are dropping CachingEntityRevisionLookup in T260600 which means caching will be based on revision id and not the page title (increasing revision id lookup: T255305#6380897) Making the drop slightly more like a ticking bomb.

Related Objects

Event Timeline

Ladsgroup created this task.Aug 17 2020, 8:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 17 2020, 8:05 PM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Aug 17 2020, 8:15 PM
Ladsgroup mentioned this in T260600: Drop CachingEntityRevisionLookup.Aug 17 2020, 9:47 PM
Addshore edited projects, added: Wikidata-Campsite; removed: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Aug 18 2020, 12:04 PM
Addshore moved this task from Incoming to Needs Tech Work on the Wikidata-Campsite board.
Rosalie_WMDE claimed this task.Sep 15 2020, 7:48 AM
Rosalie_WMDE moved this task from Needs Tech Work to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.
Rosalie_WMDE edited projects, added: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed: Wikidata-Campsite.
Rosalie_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Rosalie_WMDE removed Rosalie_WMDE as the assignee of this task.Sep 15 2020, 7:54 AM
Rosalie_WMDE edited projects, added: Wikidata-Campsite; removed: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).
Rosalie_WMDE moved this task from Incoming to Needs Tech Work on the Wikidata-Campsite board.
Rosalie_WMDE subscribed.
Addshore added a project: [DEPRECATED] wdwb-tech.Apr 14 2021, 9:37 AM
Addshore updated the task description. (Show Details)Apr 14 2021, 3:34 PM
Addshore moved this task from Inbox to To Prioritize on the [DEPRECATED] wdwb-tech board.
Addshore removed a project: Wikidata-Campsite.Apr 22 2021, 3:59 PM
Addshore moved this task from To Prioritize to Triaged Low (0-50) on the [DEPRECATED] wdwb-tech board.May 4 2021, 10:52 AM
Addshore triaged this task as Low priority.Jul 14 2021, 11:12 AM
Umherirrender renamed this task from Use RevisionLookup::getKnownCurrentRevision instead of PrefetchingWikiPageEntityMetaDataAccessor to Use RevisionLookup::getKnownLatestRevision instead of PrefetchingWikiPageEntityMetaDataAccessor.Jul 11 2026, 9:44 PM
Umherirrender updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits