Page MenuHomePhabricator

RTL issue with "Add description" CTA
Closed, ResolvedPublic

Description

The "+ Add a title description" text is not RTL aware. The alignment is incorrect.
I don't have an actual page handy where this happens but this can be observed on a local PCS instance with some minor, temporary modifications.

Steps to reproduce:

  • Modify local PCS instance so that it always thinks there is no description:
    • In lib/transformations/pcs/addPageHeader.js add the following block before the EditTransform.newPageHeader() call:
meta.mw.description = '';
meta.mw.description_source = 'central';

Actual

The "+" icon is not aligned to the right and too close to the text for "add description".

Screen Shot 2020-08-26 at 4.51.47 PM.png (181×304 px, 16 KB)

Expected

The "+" icon is aligned to the right and there is some space between it and the text for "add description".

Event Timeline

Change 622854 had a related patch set uploaded (by BearND; owner: BearND):
[mediawiki/services/mobileapps@master] Fix RTL issue in "add description"

https://gerrit.wikimedia.org/r/622854

Change 622854 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Fix RTL issue in "add description"

https://gerrit.wikimedia.org/r/622854