Page MenuHomePhabricator

On This Day widget: follow up tasks
Closed, ResolvedPublicBUG REPORT

Description

From https://github.com/wikimedia/wikipedia-ios/pull/3678#pullrequestreview-488196763

  1. the large widget has some cutoff at the bottom when the dynamic type size is increased (see image in PR review above)
  2. Seems like all of the strings for the placeholder should be localized.
  3. Top Read passes the usingCache into this method, and uses ImageCacheController.shared?.cachedImage(withURL url:URL) here instead for a speedier getSnapshot method. We should probably do the same in this widget (specific spot in code: https://github.com/wikimedia/wikipedia-ios/pull/3678#discussion_r488270117)
  4. remove a force unwrap: https://github.com/wikimedia/wikipedia-ios/pull/3678#discussion_r488273719
  5. And maybe another? https://github.com/wikimedia/wikipedia-ios/pull/3678#discussion_r488274998
  6. remove placeholder https://github.com/wikimedia/wikipedia-ios/pull/3678#discussion_r488279606

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript