Page MenuHomePhabricator

MattCleinman (Matt Cleinman)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Mar 10 2020, 7:21 PM (33 w, 3 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
MCleinman (WMF) [ Global Accounts ]

Recent Activity

Yesterday

MattCleinman moved T265677: Modal improvements: loading additional events looks slow or stalled from Doing to Needs Code Review on the iOS-app-Bonefish-On-A-Balloon board.
Fri, Oct 30, 9:05 PM · iOS-app-Bonefish-On-A-Balloon, Wikipedia-iOS-App-Backlog
MattCleinman renamed T166197: [[Wikimedia:Wikipedia-ios-pictured/en]] i18n issue - add custom gender and grammar from [[Wikimedia:Wikipedia-ios-pictured/en]] i18n issue to [[Wikimedia:Wikipedia-ios-pictured/en]] i18n issue - add custom gender and grammar.
Fri, Oct 30, 8:23 PM · Gender-Support, iOS-app-feature-Multilingual, iOS-app-Bugs, Wikipedia-iOS-App-Backlog, I18n

Thu, Oct 29

MattCleinman added a comment to T266837: Remove grunt from project.

Would be nice to slip this into 6.8.

Thu, Oct 29, 10:06 PM · Wikipedia-iOS-App-Backlog
MattCleinman created T266837: Remove grunt from project.
Thu, Oct 29, 10:05 PM · Wikipedia-iOS-App-Backlog
MattCleinman updated the task description for T266817: iOS 14 widget bug: Top Read shows wrong count when almost midnight.
Thu, Oct 29, 5:29 PM · iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower, Wikipedia-iOS-App-Backlog
MattCleinman created T266817: iOS 14 widget bug: Top Read shows wrong count when almost midnight.
Thu, Oct 29, 5:29 PM · iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower, Wikipedia-iOS-App-Backlog

Wed, Oct 28

MattCleinman claimed T265677: Modal improvements: loading additional events looks slow or stalled.
Wed, Oct 28, 9:56 PM · iOS-app-Bonefish-On-A-Balloon, Wikipedia-iOS-App-Backlog

Tue, Oct 27

MattCleinman created T266621: Article as a Living Doc modal has incorrect scroll position for some text sizes.
Tue, Oct 27, 10:49 PM · Wikipedia-iOS-App-Backlog
MattCleinman closed T252921: Update PCS defaultOutputModeForPOSTResponse as Resolved.
Tue, Oct 27, 8:46 PM · Patch-For-Review, Platform Team Workboards (External Code Reviews), Wikipedia-iOS-App-Backlog
MattCleinman merged task T219208: Logging audit into T260724: Improve logging in app.
Tue, Oct 27, 8:27 PM · Wikipedia-iOS-App-Backlog
MattCleinman merged T219208: Logging audit into T260724: Improve logging in app.
Tue, Oct 27, 8:27 PM · iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower, Wikipedia-iOS-App-Backlog
MattCleinman moved T265666: Interstitial card visuals: design polish from Needs Code Review to Waiting for Build on the iOS-app-Bonefish-On-A-Balloon board.
Tue, Oct 27, 8:07 PM · iOS-app-Bonefish-On-A-Balloon, Wikipedia-iOS-App-Backlog
MattCleinman created T266596: Automate app versioning on Github.
Tue, Oct 27, 7:25 PM · Wikipedia-iOS-App-Backlog

Fri, Oct 23

MattCleinman moved T266370: Article as a Living Doc - Add a highlight when viewing History from Doing to Needs Code Review on the iOS-app-Bonefish-On-A-Balloon board.
Fri, Oct 23, 11:54 PM · iOS-app-Bonefish-On-A-Balloon, Wikipedia-iOS-App-Backlog
MattCleinman placed T265672: Snippets: increase amount of visible text up for grabs.
Fri, Oct 23, 8:25 PM · iOS-app-Bonefish-On-A-Balloon, Wikipedia-iOS-App-Backlog
MattCleinman claimed T266370: Article as a Living Doc - Add a highlight when viewing History.
Fri, Oct 23, 8:25 PM · iOS-app-Bonefish-On-A-Balloon, Wikipedia-iOS-App-Backlog
MattCleinman claimed T265672: Snippets: increase amount of visible text.
Fri, Oct 23, 7:36 PM · iOS-app-Bonefish-On-A-Balloon, Wikipedia-iOS-App-Backlog
MattCleinman moved T265674: Improve transitions out of modal from Doing to Waiting for Build on the iOS-app-Bonefish-On-A-Balloon board.
Fri, Oct 23, 7:34 PM · iOS-app-Bonefish-On-A-Balloon, Wikipedia-iOS-App-Backlog

Thu, Oct 22

MattCleinman closed T265929: VoiceOver on iPad using iPadOS 14 is messed up as Invalid.
Thu, Oct 22, 8:56 PM · Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T265929: VoiceOver on iPad using iPadOS 14 is messed up.

Toni and I compared iOS 13 and iOS 14. Could not find any regressions in iOS 14.

Thu, Oct 22, 8:56 PM · Wikipedia-iOS-App-Backlog

Tue, Oct 20

MattCleinman claimed T265674: Improve transitions out of modal.
Tue, Oct 20, 9:56 PM · iOS-app-Bonefish-On-A-Balloon, Wikipedia-iOS-App-Backlog
MattCleinman moved T264803: [Dev]: UI work in modal - Remaining non-thank button flows from Needs Code Review to Waiting for Build on the iOS-app-Bonefish-On-A-Balloon board.
Tue, Oct 20, 6:08 PM · iOS-app-Bonefish-On-A-Balloon, Wikipedia-iOS-App-Backlog
MattCleinman moved T265676: Modal improvements: header should not fade from Needs Code Review to Waiting for Build on the iOS-app-Bonefish-On-A-Balloon board.
Tue, Oct 20, 6:07 PM · iOS-app-Bonefish-On-A-Balloon, Wikipedia-iOS-App-Backlog

Mon, Oct 19

MattCleinman created T265961: [OTRS bug] Original image webview has bad scrollability.
Mon, Oct 19, 11:39 PM · Wikipedia-iOS-App-Backlog
MattCleinman moved T265676: Modal improvements: header should not fade from Ready for Development to Needs Code Review on the iOS-app-Bonefish-On-A-Balloon board.
Mon, Oct 19, 7:25 PM · iOS-app-Bonefish-On-A-Balloon, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T265676: Modal improvements: header should not fade.

done as commit that is part of https://phabricator.wikimedia.org/T258209

Mon, Oct 19, 7:25 PM · iOS-app-Bonefish-On-A-Balloon, Wikipedia-iOS-App-Backlog
MattCleinman created T265929: VoiceOver on iPad using iPadOS 14 is messed up.
Mon, Oct 19, 5:35 PM · Wikipedia-iOS-App-Backlog

Fri, Oct 16

MattCleinman renamed T263485: Issue on articles opening wrong image in gallery (often when lead image is a photo montage) from Issue on articles where the lead image is a photo montage to Issue on articles opening wrong image in gallery (often when lead image is a photo montage).
Fri, Oct 16, 11:29 PM · iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower, Wikipedia-iOS-App-Backlog, iOS-app-Bugs
MattCleinman created T265776: [OTRS request] - Saved articles should persist scroll position.
Fri, Oct 16, 11:05 PM · Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T259842: Implement Featured article widget for iOS 14.

OTRS request for this: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=11546616

Fri, Oct 16, 10:55 PM · Wikipedia-iOS-App-Backlog

Fri, Oct 9

MattCleinman moved T259555: As a reader on Wikipedia, I'd like to be able to easily thank editors for their contributions from the Article as a Living Document model from Doing to Needs Code Review on the iOS-app-Bonefish-On-A-Balloon board.
Fri, Oct 9, 12:30 AM · iOS-app-Bonefish-On-A-Balloon, Wikipedia-iOS-App-Backlog

Thu, Oct 8

JMinor awarded T263158: On This Day widget takes user to Russian(?) version of the page a Mountain of Wealth token.
Thu, Oct 8, 10:02 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T259555: As a reader on Wikipedia, I'd like to be able to easily thank editors for their contributions from the Article as a Living Document model .
  • Move tappedThank and associated unctions from DiffContainerViewController to a protocol and protocol extension.
  • Test that I didn't break anything in DiffContainerViewController.
  • Make Article as a Living Doc conform to new protocol.
Thu, Oct 8, 6:27 PM · iOS-app-Bonefish-On-A-Balloon, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T264003: Automatic PR creation from the twn branch.

Looks like it's working well!

Thu, Oct 8, 4:16 PM · Language-Team (Language-2020-October-December), Patch-For-Review, iOS-app-Bonefish-On-A-Balloon, translatewiki.net, Wikipedia-iOS-App-Backlog

Wed, Oct 7

MattCleinman claimed T259555: As a reader on Wikipedia, I'd like to be able to easily thank editors for their contributions from the Article as a Living Document model .
Wed, Oct 7, 11:00 PM · iOS-app-Bonefish-On-A-Balloon, Wikipedia-iOS-App-Backlog
MattCleinman moved T259555: As a reader on Wikipedia, I'd like to be able to easily thank editors for their contributions from the Article as a Living Document model from Ready for Development to Doing on the iOS-app-Bonefish-On-A-Balloon board.
Wed, Oct 7, 11:00 PM · iOS-app-Bonefish-On-A-Balloon, Wikipedia-iOS-App-Backlog
MattCleinman moved T264803: [Dev]: UI work in modal - Remaining non-thank button flows from Doing to Needs Code Review on the iOS-app-Bonefish-On-A-Balloon board.
Wed, Oct 7, 10:59 PM · iOS-app-Bonefish-On-A-Balloon, Wikipedia-iOS-App-Backlog
MattCleinman created T264932: Navigation Bar's underbar view messes up scroll positions.
Wed, Oct 7, 7:23 PM · iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower, Wikipedia-iOS-App-Backlog

Mon, Oct 5

MattCleinman added a comment to T264003: Automatic PR creation from the twn branch.

@abi_ sounds good. I've put up a PR to create a new github action, and we can deprecate the old one after we confirm the new one - in combination with your patch - is working as expected.

Mon, Oct 5, 8:29 PM · Language-Team (Language-2020-October-December), Patch-For-Review, iOS-app-Bonefish-On-A-Balloon, translatewiki.net, Wikipedia-iOS-App-Backlog

Sep 29 2020

MattCleinman placed T264003: Automatic PR creation from the twn branch up for grabs.
Sep 29 2020, 6:30 PM · Language-Team (Language-2020-October-December), Patch-For-Review, iOS-app-Bonefish-On-A-Balloon, translatewiki.net, Wikipedia-iOS-App-Backlog

Sep 28 2020

MattCleinman added a comment to T264003: Automatic PR creation from the twn branch.

Hello! We've been doing something similar on our end, but it's definitely better to standardize this based on the way it's working for other repos.

Sep 28 2020, 7:29 PM · Language-Team (Language-2020-October-December), Patch-For-Review, iOS-app-Bonefish-On-A-Balloon, translatewiki.net, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T263863: [Bug] Changing languages in app settings does not update Widget languages as expected.

This should be fixed/improved in 6.7.1. Please let us know if this behavior still occurs in this release.

Sep 28 2020, 6:47 PM · Wikipedia-iOS-App-Backlog, iOS-app-Bugs

Sep 24 2020

JMinor awarded T257238: Remove whitelist/blacklist/master in Wikipedia iOS app codebase a Love token.
Sep 24 2020, 8:19 PM · iOS-app-v6.7-Bonefish-On-A-Bus, Wikipedia-iOS-App-Backlog, Voice & Tone

Sep 23 2020

MattCleinman moved T261027: [OTRS]: Unable to link to commons link with umlauts from article from Needs Code Review to Waiting for Build on the iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat board.
Sep 23 2020, 11:50 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
MattCleinman updated subscribers of T263271: All widgets displaying blank or brief flash of content before blank.

Upon reading that thread, I'm thinking this one is either from:

  • An iOS 14 issue (most likely)
  • Some issue related to the periodic crashes we're seeing in widgets, which causes a refresh/crash loop. (For this one to be the case, all widgets in the gallery would have to be updated when one crashes. That seems like weird architecture, but who knows.)
Sep 23 2020, 5:07 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman moved T263108: On this day widget not working from Doing to Needs QA on the iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat board.
Sep 23 2020, 4:49 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T263108: On this day widget not working.

Cannot replicate, and several folks have not seen this one recently. We believe/hope it was fixed by other widget tweaks. Will have QA do one final check on this release. (Of course, if this pops its head back up, we'll look into it.)

Sep 23 2020, 4:49 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T263271: All widgets displaying blank or brief flash of content before blank.

Several of us have seen this behavior at this point, including when not looking at any Wikipedia widgets. It seems like this also happens sometimes when looking at stock widgets. And if so, is it fair to guess this is on Apple to fix?

Sep 23 2020, 12:26 AM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman moved T263483: Opening from On This Day Widget sometimes leads to a navigation bar with no back button from Needs Code Review to Waiting for Build on the iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat board.
Sep 23 2020, 12:22 AM · Wikipedia-iOS-App-Backlog, iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat
MattCleinman moved T262876: On This Day widget: follow up tasks from Needs Code Review to Waiting for Build on the iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat board.
Sep 23 2020, 12:22 AM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman moved T263158: On This Day widget takes user to Russian(?) version of the page from Needs Code Review to Waiting for Build on the iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat board.
Sep 23 2020, 12:22 AM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman moved T263247: Fix 0xdead10cc crashes reported by the widgets from Needs Code Review to Waiting for Build on the iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat board.
Sep 23 2020, 12:22 AM · iOS-app-Bonefish-On-A-Balloon, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
MattCleinman claimed T263108: On this day widget not working.
Sep 23 2020, 12:20 AM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T263108: On this day widget not working.

I can't seem to replicate this on device. Except for the device - a XR instead of an 11 Pro Max - everything is identical.

Sep 23 2020, 12:20 AM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, iOS-app-Bugs, Wikipedia-iOS-App-Backlog

Sep 22 2020

MattCleinman moved T261027: [OTRS]: Unable to link to commons link with umlauts from article from Doing to Needs Code Review on the iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat board.
Sep 22 2020, 11:28 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T261027: [OTRS]: Unable to link to commons link with umlauts from article.

PR is up: https://github.com/wikimedia/wikipedia-ios/pull/3710/

Sep 22 2020, 11:28 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
MattCleinman merged T259902: 404 not found for link in app (beta) into T261027: [OTRS]: Unable to link to commons link with umlauts from article.
Sep 22 2020, 11:28 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
MattCleinman merged task T259902: 404 not found for link in app (beta) into T261027: [OTRS]: Unable to link to commons link with umlauts from article.
Sep 22 2020, 11:27 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T259902: 404 not found for link in app (beta).

Definitely a dup of https://phabricator.wikimedia.org/T261027, so closing this one.

Sep 22 2020, 11:27 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman moved T262355: Top read and Picture of the day polish from Needs Code Review to Waiting for Build on the iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat board.
Sep 22 2020, 9:39 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T261027: [OTRS]: Unable to link to commons link with umlauts from article.

From looking at the variety of links created on a test wiki page, looking at how they look on web (that link), after PCS parsing, and in the iOS app, it seems like the actual solution here is for us to detect if a URL is already encoded. This could be done on one of two levels:

  1. iOS app - if encoded, don't encode the URL ever
  2. PCS - if encoded, pass the unencoded version to the mobile apps
Sep 22 2020, 9:10 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T261979: Finish PR feedback for On This Day deep link.

QA test instructions:

  • Install app, open app, add a widget to homescreen.
  • Tap widget, ensure app opens to On This Day screen scrolled to proper element.
  • Change language to another one that supports On This Day (like French, Spanish, Arabic, Russian, and a few others). The widget should show the other language. Tap widget, ensure app opens to On This Day screen scrolled to proper element - in proper language.
  • On a phone w/ a notch (iPhone X style), scroll to top of On This Day screen in app. Rotate phone so notch is on left side, ensure the header's padding respects the notch - the text shouldn't be hidden by the notch.
  • Background the app (go to home screen). Hard quit the app. Reopen the app. Ensure that On This Day screen in the app still has a "back" button and not the "X" (which it has when the On This Day card is tapped on the explore screen).
Sep 22 2020, 6:54 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman moved T263158: On This Day widget takes user to Russian(?) version of the page from Doing to Needs Code Review on the iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat board.
Sep 22 2020, 6:42 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T261027: [OTRS]: Unable to link to commons link with umlauts from article.

If an editor uses an encoded version of a special character in a link, it automatically is converted to the actual character in the link when the edit is saved. So writing a link as https://commons.wikimedia.org/wiki/Duszniki-Zdr%C3%B3j?uselang=de or https://commons.wikimedia.org/wiki/Duszniki-Zdrój?uselang=de doesn't matter, as both will be saved in wikitext as https://commons.wikimedia.org/wiki/Duszniki-Zdrój?uselang=de.

Sep 22 2020, 5:43 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T261027: [OTRS]: Unable to link to commons link with umlauts from article.

This is happening when linking to off-wikipedia wikimedia-project site (wikiquotes, commons, wikidata etc.). That is the commonality between all of these.

Sep 22 2020, 5:16 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T261027: [OTRS]: Unable to link to commons link with umlauts from article.

In short: This is likely going to be fixed in PCS; I'm chasing it down that path now.

Sep 22 2020, 12:09 AM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, iOS-app-Bugs, Wikipedia-iOS-App-Backlog

Sep 21 2020

MattCleinman claimed T259902: 404 not found for link in app (beta).
Sep 21 2020, 9:46 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman moved T261027: [OTRS]: Unable to link to commons link with umlauts from article from Tasks from Product Backlog to Doing on the iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat board.
Sep 21 2020, 9:46 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
MattCleinman claimed T261027: [OTRS]: Unable to link to commons link with umlauts from article.

Likely related: https://phabricator.wikimedia.org/T259902

Sep 21 2020, 9:46 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
MattCleinman moved T263483: Opening from On This Day Widget sometimes leads to a navigation bar with no back button from Doing to Needs Code Review on the iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat board.

PR is up https://github.com/wikimedia/wikipedia-ios/pull/3708

Sep 21 2020, 8:47 PM · Wikipedia-iOS-App-Backlog, iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat
MattCleinman added a comment to T263155: Editing error(?) message in ios app displaying nonsense characters in ja.wiki.

Seems like a translation issue, given that they're seeing %1$@ unexpectedly.

Sep 21 2020, 6:45 PM · iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower, Wikipedia-iOS-App-Backlog
MattCleinman moved T263483: Opening from On This Day Widget sometimes leads to a navigation bar with no back button from Tasks from Product Backlog to Doing on the iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat board.
Sep 21 2020, 4:56 PM · Wikipedia-iOS-App-Backlog, iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat
MattCleinman created T263483: Opening from On This Day Widget sometimes leads to a navigation bar with no back button.
Sep 21 2020, 4:56 PM · Wikipedia-iOS-App-Backlog, iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat
MattCleinman added a comment to T263283: Support multiple language customizable widgets on iOS 14.

I don't think we'd be able to have two different languages in the same sized widget (though there may be a hacky way to make it happen), but we could use different languages on different sized widgets of the same type.

Sep 21 2020, 4:20 PM · iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower, Wikipedia-iOS-App-Backlog
cmadeo awarded T263287: On This Day widget: Update highlighted article throughout the day a Party Time token.
Sep 21 2020, 2:17 PM · iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower, Wikipedia-iOS-App-Backlog

Sep 19 2020

MattCleinman moved T262876: On This Day widget: follow up tasks from Doing to Needs Code Review on the iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat board.
Sep 19 2020, 12:13 AM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog

Sep 18 2020

MattCleinman added a comment to T262876: On This Day widget: follow up tasks.

PR is up for all of these: https://github.com/wikimedia/wikipedia-ios/pull/3705

Sep 18 2020, 11:23 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman created T263287: On This Day widget: Update highlighted article throughout the day.
Sep 18 2020, 8:23 PM · iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower, Wikipedia-iOS-App-Backlog
MattCleinman moved T262876: On This Day widget: follow up tasks from Tasks from Product Backlog to Doing on the iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat board.
Sep 18 2020, 6:55 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman created T263280: Add gesture to open Table of Contents (when TOC is collapsed).
Sep 18 2020, 6:22 PM · Wikipedia-iOS-App-Backlog
MattCleinman created T263279: Allow copying link to an article section.
Sep 18 2020, 6:15 PM · Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T263158: On This Day widget takes user to Russian(?) version of the page.

This fix is being handled here: https://github.com/wikimedia/wikipedia-ios/pull/3703/

Sep 18 2020, 4:18 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T263158: On This Day widget takes user to Russian(?) version of the page.

It's possibly a context issue. When debugging, you can see the new language being updated appropriately, then trying to get the language from the widget, and there it shows as the outdated language.

Sep 18 2020, 12:26 AM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog

Sep 17 2020

MattCleinman added a comment to T263158: On This Day widget takes user to Russian(?) version of the page.

Progress made: If this is threaded, it's a race condition. If it's not threaded, we're just pulling the data before we're setting the new language. It doesn't take two moves to get the language to update - it's always using the prior language.

Sep 17 2020, 11:03 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T263158: On This Day widget takes user to Russian(?) version of the page.

PR for main part is merged: https://github.com/wikimedia/wikipedia-ios/pull/3701

Sep 17 2020, 10:28 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman moved T263158: On This Day widget takes user to Russian(?) version of the page from Tasks from Product Backlog to Doing on the iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat board.

Can confirm that the video is Russia's on this day for yesterday (when video was taken): https://ru.wikipedia.org/api/rest_v1/feed/onthisday/events/09/16

Sep 17 2020, 6:59 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman claimed T263158: On This Day widget takes user to Russian(?) version of the page.
Sep 17 2020, 6:59 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman moved T262497: On This Day view controller: RTL languages have incorrect initial horizontal scrolling offset for article cards from Needs Code Review to Waiting for Build on the iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat board.
Sep 17 2020, 4:18 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog

Sep 16 2020

MattCleinman moved T262497: On This Day view controller: RTL languages have incorrect initial horizontal scrolling offset for article cards from Doing to Needs Code Review on the iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat board.
Sep 16 2020, 8:03 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T262497: On This Day view controller: RTL languages have incorrect initial horizontal scrolling offset for article cards.

PR up: https://github.com/wikimedia/wikipedia-ios/pull/3697

Sep 16 2020, 8:03 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T262497: On This Day view controller: RTL languages have incorrect initial horizontal scrolling offset for article cards.

Looks like the second time a cell loads (scroll down, then scroll back up) sizing is appropriate.

Sep 16 2020, 7:53 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T262497: On This Day view controller: RTL languages have incorrect initial horizontal scrolling offset for article cards.

This happens within resetContentOffset() in SideScrollingCollectionViewCell.swift. It seems like the collectionView's sizes (especially collectionView.contentSize and collectionView.bounds) aren't being properly calculated before the function is called, even if you spam collectionView.setNeedsLayout() / collectionView.layoutIfNeeded() at the top of the function.

Sep 16 2020, 7:37 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T262497: On This Day view controller: RTL languages have incorrect initial horizontal scrolling offset for article cards.

Also, the "X" to close the screen is on the wrong side in RTL languages.

Sep 16 2020, 4:32 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman claimed T262497: On This Day view controller: RTL languages have incorrect initial horizontal scrolling offset for article cards.
Sep 16 2020, 12:22 AM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman merged task T259904: Problem with Commons links with umlauts into T261027: [OTRS]: Unable to link to commons link with umlauts from article.
Sep 16 2020, 12:21 AM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman merged T259904: Problem with Commons links with umlauts into T261027: [OTRS]: Unable to link to commons link with umlauts from article.
Sep 16 2020, 12:21 AM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
MattCleinman moved T262497: On This Day view controller: RTL languages have incorrect initial horizontal scrolling offset for article cards from Tasks from Product Backlog to Doing on the iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat board.
Sep 16 2020, 12:17 AM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog

Sep 15 2020

MattCleinman moved T261979: Finish PR feedback for On This Day deep link from Needs Code Review to Waiting for Build on the iOS-app-v6.7-Bonefish-On-A-Bus board.
Sep 15 2020, 10:32 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman moved T261979: Finish PR feedback for On This Day deep link from Doing to Needs Code Review on the iOS-app-v6.7-Bonefish-On-A-Bus board.

PR: https://github.com/wikimedia/wikipedia-ios/pull/3691

Sep 15 2020, 7:12 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog
MattCleinman updated the task description for T262876: On This Day widget: follow up tasks.
Sep 15 2020, 6:19 PM · iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat, Wikipedia-iOS-App-Backlog