Page MenuHomePhabricator

MattCleinman (Matt Cleinman)
Disabled

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2020, 7:21 PM (121 w, 22 h)
Roles
Disabled
LDAP User
Unknown
MediaWiki User
MCleinman (WMF) [ Global Accounts ]
This account has been disabled.

Recent Activity

Fri, Jul 1

MattCleinman moved T310798: [ZNUNY] Keyboard opens on Setting tab when brought from background from Tasks from Product Backlog to Needs Code Review on the iOS-app-v6.9.3 board.
Fri, Jul 1, 8:24 PM · iOS-app-v6.9.3, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
MattCleinman added a project to T310798: [ZNUNY] Keyboard opens on Setting tab when brought from background: iOS-app-v6.9.3.
Fri, Jul 1, 8:23 PM · iOS-app-v6.9.3, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T310798: [ZNUNY] Keyboard opens on Setting tab when brought from background.

PR: https://github.com/wikimedia/wikipedia-ios/pull/4267

Fri, Jul 1, 8:23 PM · iOS-app-v6.9.3, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T310798: [ZNUNY] Keyboard opens on Setting tab when brought from background.

My initial hunch was wrong: shouldShowExploreScreenOnLaunch didn't consider whether the user wanted to always launch into the search tab - so it was opening to Search, then switching to Settings.

Fri, Jul 1, 8:21 PM · iOS-app-v6.9.3, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
MattCleinman closed T311786: Cross-Platform Reading List Syncing bug as Resolved.

Turns out there was something stopping Android from syncing, even when manually triggering a sync. He logged out on Android, uninstalled the Android app, reinstalled it and relogged in, and everything synced as expected.

Fri, Jul 1, 5:07 PM · Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog
MattCleinman closed T294875: Ensure "Libraries used" section of app is up to date as Resolved.

From a quick check, this seems okay - nothing to update.

Fri, Jul 1, 12:13 AM · Wikipedia-iOS-App-Backlog

Thu, Jun 30

MattCleinman created T311786: Cross-Platform Reading List Syncing bug.
Thu, Jun 30, 9:28 PM · Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog
MattCleinman added a comment to T292688: iOS app needs option to delete account.

This starts on June 30th (today), so we should expedite this work: https://developer.apple.com/news/?id=12m75xbj

Thu, Jun 30, 7:12 PM · iOS-app-v6.9.3, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T298814: Add optional talk page icon to the mobile-html endpoint.

@vadim-kovalenko - Hold off on this one for now. Sorry, I just found out that the design on this may change. We'll let you know when we're confident how we'd like to move forward with this.

Thu, Jun 30, 3:52 PM · Patch-For-Review, Wikipedia-Android-App-Backlog, Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-iOS-App-Backlog

Tue, Jun 28

MattCleinman added a comment to T310798: [ZNUNY] Keyboard opens on Setting tab when brought from background.

I looked into this, and it seems like some race condition with the last few lines of WMFAppViewController's configureTabController:

if (shouldOpenAppOnSearchTab && self.selectedIndex != WMFAppTabTypeSearch) {
    [self setSelectedIndex:WMFAppTabTypeSearch];
    [[self searchViewController] makeSearchBarBecomeFirstResponder];
} else if (self.selectedIndex != WMFAppTabTypeMain) {
    [self setSelectedIndex:WMFAppTabTypeMain];
}
Tue, Jun 28, 12:25 AM · iOS-app-v6.9.3, iOS-app-Bugs, Wikipedia-iOS-App-Backlog

Mon, Jun 27

MattCleinman added a comment to T311238: Article saved via shared sheet is not added to default reading list.

PR: https://github.com/wikimedia/wikipedia-ios/pull/4263

Mon, Jun 27, 8:02 PM · iOS-app-v6.9.3, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
MattCleinman moved T311238: Article saved via shared sheet is not added to default reading list from Tasks from Product Backlog to Needs Code Review on the iOS-app-v6.9.3 board.
Mon, Jun 27, 8:02 PM · iOS-app-v6.9.3, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
MattCleinman claimed T311238: Article saved via shared sheet is not added to default reading list.
Mon, Jun 27, 8:01 PM · iOS-app-v6.9.3, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T311238: Article saved via shared sheet is not added to default reading list.

Bug also exists when adding via share sheet in explore feed.

Mon, Jun 27, 7:32 PM · iOS-app-v6.9.3, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
MattCleinman moved T307604: User talk page message notifications on non-latin topic titles do not navigate to specific reply thread from Tasks from Product Backlog to Ready for Development on the iOS-app-v6.9.3 board.
Mon, Jun 27, 6:38 PM · iOS-app-v6.9.3, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
MattCleinman triaged T311071: Consume new Talk Page API as Medium priority.
Mon, Jun 27, 6:37 PM · Wikipedia-iOS-App-Backlog, ios-app-v7.0
MattCleinman triaged T311238: Article saved via shared sheet is not added to default reading list as Medium priority.
Mon, Jun 27, 6:36 PM · iOS-app-v6.9.3, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
MattCleinman triaged T311313: Talk pages: Set up feature flag as Medium priority.
Mon, Jun 27, 6:35 PM · ios-app-v7.0, Wikipedia-iOS-App-Backlog
MattCleinman triaged T311326: Bug when deleting articles as Medium priority.
Mon, Jun 27, 6:34 PM · Wikipedia-iOS-App-Backlog
MattCleinman triaged T311325: Feature request: Warn when opening an article that is already open in a different tab as Low priority.

On Firefox Desktop, if you typed in a URL that is open in another tab, one of the autocomplete options is "Switch to Tab". We could do a similar treatment - if an article is open in another tab, we could offer "open", "open in new tab", and "jump to existing tab" (that should be worded better).

Mon, Jun 27, 4:19 PM · Wikipedia-Android-App-Backlog

Fri, Jun 24

MattCleinman added a comment to T268279: Display issues with math articles in dark & black mode.

Another report: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=12238543

Fri, Jun 24, 8:27 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog
MattCleinman added a comment to T264474: Some tables in articles have unreadable background in dark and black themes.

Another report: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=12236477

Fri, Jun 24, 8:25 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog, iOS-app-Bugs
MattCleinman added a comment to T264474: Some tables in articles have unreadable background in dark and black themes.

Another report: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=12235893

Fri, Jun 24, 8:24 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog, iOS-app-Bugs
MattCleinman created T311326: Bug when deleting articles.
Fri, Jun 24, 8:16 PM · Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T264474: Some tables in articles have unreadable background in dark and black themes.

Another report: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=12232218

Fri, Jun 24, 8:13 PM · Product-Infrastructure-Team-Backlog (Kanban), Page Content Service, Wikipedia-iOS-App-Backlog, iOS-app-Bugs
MattCleinman created T311325: Feature request: Warn when opening an article that is already open in a different tab.
Fri, Jun 24, 7:41 PM · Wikipedia-Android-App-Backlog
MattCleinman added a comment to T311320: "Recent searches" missing.

Another report in Znuny

Fri, Jun 24, 6:13 PM · Wikipedia-Android-App-Backlog (Android Release FY2021-22)
MattCleinman updated the task description for T311320: "Recent searches" missing.
Fri, Jun 24, 6:10 PM · Wikipedia-Android-App-Backlog (Android Release FY2021-22)
MattCleinman created T311320: "Recent searches" missing.
Fri, Jun 24, 6:07 PM · Wikipedia-Android-App-Backlog (Android Release FY2021-22)
MattCleinman added a comment to T272914: Privacy mode - option(s) to auto-clear or never record search history or browsing history.

Request via email: "Too bad you can't set anywhere that you want to clear the search history when closing the app. "

Fri, Jun 24, 5:39 PM · Wikipedia-Android-App-Backlog

Wed, Jun 22

MattCleinman closed T306281: Boxes in French Wikipedia Skew Section Headers as Resolved.

Looks like this has been fixed. Thanks so much!

Wed, Jun 22, 6:12 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog

Tue, Jun 21

MattCleinman added a comment to T277351: [OTRS] Unexpected behavior with context menu "Share" action.

PR: https://github.com/wikimedia/wikipedia-ios/pull/4232

Tue, Jun 21, 7:11 PM · iOS-app-v6.9.3, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T305777: On this day feed card content cannot be found in the on this day list.

Thanks for your thoughts on this.

Tue, Jun 21, 4:26 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikifeeds, Wikipedia-Android-App-Backlog

Fri, Jun 17

MattCleinman added a project to T301007: [Bug] Reference links not working in HIV/AIDs article : Product-Infrastructure-Team-Backlog.
Fri, Jun 17, 10:26 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-iOS-App-Backlog, iOS-app-Bugs
MattCleinman added a comment to T301007: [Bug] Reference links not working in HIV/AIDs article .

This is due to a bug in PCS. It is considering the page name AIDS (instead of the accurate HIV/AIDS, and so isCitation is incorrectly returning false. This is due to ClickedItem constructor being given an incorrect pageTitle, as it assumes slashes are never in page titles (around line 289 of InteractionHandling.js).

Fri, Jun 17, 10:25 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-iOS-App-Backlog, iOS-app-Bugs

Thu, Jun 16

MattCleinman moved T310807: Share sections from the Wikipedia Android App from Epics in Progress to Needs Design/Design doing on the Wikipedia-Android-App-Backlog (Android Release FY2021-22) board.
Thu, Jun 16, 4:24 PM · Wikipedia-Android-App-Backlog (Android Release FY2021-22)
MattCleinman edited projects for T310807: Share sections from the Wikipedia Android App, added: Wikipedia-Android-App-Backlog (Android Release FY2021-22); removed Wikipedia-Android-App-Backlog.
Thu, Jun 16, 4:23 PM · Wikipedia-Android-App-Backlog (Android Release FY2021-22)

Mon, Jun 13

MattCleinman updated the task description for T310239: Check apps team testing device inventory.
Mon, Jun 13, 9:45 PM · Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog
MattCleinman merged T310384: SVG image invisible in dark and black mode into T268279: Display issues with math articles in dark & black mode.
Mon, Jun 13, 6:34 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog
MattCleinman merged task T310384: SVG image invisible in dark and black mode into T268279: Display issues with math articles in dark & black mode.
Mon, Jun 13, 6:33 PM · iOS-app-Bugs, Wikipedia-iOS-App-Backlog

Tue, Jun 7

MattCleinman added a comment to T298814: Add optional talk page icon to the mobile-html endpoint.

No giant rush, but do you know when this will be deployed?

Tue, Jun 7, 6:50 PM · Patch-For-Review, Wikipedia-Android-App-Backlog, Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T305777: On this day feed card content cannot be found in the on this day list.

I spoke to @Dbrant yesterday, and the Android architecture for this departs from iOS. Android uses what the API gives it in each appropriate spot:

Tue, Jun 7, 6:18 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikifeeds, Wikipedia-Android-App-Backlog

Jun 3 2022

MattCleinman added a comment to T307407: Issues w/ Arabic Wikipedia in app.

This is fixed in the current beta - if we get additional reports of this, we can explain that we expect to have it fixed in the main app store version soon, and we should share the instructions for joining the beta.

Jun 3 2022, 6:46 PM · User-Ryasmeen, Product-Infrastructure-Team-Backlog (Kanban), iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon, Wikipedia-iOS-App-Backlog

Jun 2 2022

MattCleinman moved T306124: Disappear-on-scroll navigation bar should come back more easily? from Tasks from Product Backlog to Needs Code Review on the iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon board.

Added this to board as an engineering thing that had been bugging me, during our post-release week.

Jun 2 2022, 12:57 AM · iOS-app-v6.9.3, iOS-app-feature-Navigation, Wikipedia-iOS-App-Backlog
MattCleinman added a project to T306124: Disappear-on-scroll navigation bar should come back more easily?: iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon.
Jun 2 2022, 12:56 AM · iOS-app-v6.9.3, iOS-app-feature-Navigation, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T306124: Disappear-on-scroll navigation bar should come back more easily?.

PR: https://github.com/wikimedia/wikipedia-ios/pull/4246

Jun 2 2022, 12:56 AM · iOS-app-v6.9.3, iOS-app-feature-Navigation, Wikipedia-iOS-App-Backlog

Jun 1 2022

MattCleinman moved T307407: Issues w/ Arabic Wikipedia in app from Blocked or Waiting to Needs Testing Criteria on the iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon board.
Jun 1 2022, 1:10 AM · User-Ryasmeen, Product-Infrastructure-Team-Backlog (Kanban), iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T307407: Issues w/ Arabic Wikipedia in app.

Thanks for this. It fixes the problem and tests great, thank you.

Jun 1 2022, 12:55 AM · User-Ryasmeen, Product-Infrastructure-Team-Backlog (Kanban), iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon, Wikipedia-iOS-App-Backlog

May 31 2022

MattCleinman added a comment to T308652: Tapping on a page's first edit on the watchlist produces a 404 error message.

For simplicity, we're going to go with a top half of the screen, but instead of green text we say something like "The first edit of [article name]".

May 31 2022, 4:27 PM · Wikipedia-Android-App-Backlog (Android Release FY2021-22), Android-app-Bugs

May 27 2022

MattCleinman added a comment to T307407: Issues w/ Arabic Wikipedia in app.

I think I'd rather fix this on wiki or PCS than with a hack the iOS codebase. (In part because the fix will get out their even quicker.)

May 27 2022, 6:15 PM · User-Ryasmeen, Product-Infrastructure-Team-Backlog (Kanban), iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T306281: Boxes in French Wikipedia Skew Section Headers.

The version that mobile apps use is available here: https://fr.wikipedia.org/api/rest_v1/page/mobile-html/%C3%89ph%C3%A9m%C3%A8re

May 27 2022, 4:45 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog

May 25 2022

MattCleinman added a comment to T306281: Boxes in French Wikipedia Skew Section Headers.

That sounds good to me @vadim-kovalenko , thanks!

May 25 2022, 4:52 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog

May 24 2022

alaa awarded T307407: Issues w/ Arabic Wikipedia in app a Like token.
May 24 2022, 3:53 PM · User-Ryasmeen, Product-Infrastructure-Team-Backlog (Kanban), iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon, Wikipedia-iOS-App-Backlog
MattCleinman moved T277351: [OTRS] Unexpected behavior with context menu "Share" action from Tasks from Product Backlog to Needs Code Review on the iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon board.
May 24 2022, 12:31 AM · iOS-app-v6.9.3, Wikipedia-iOS-App-Backlog
MattCleinman added a project to T277351: [OTRS] Unexpected behavior with context menu "Share" action: iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon.
May 24 2022, 12:31 AM · iOS-app-v6.9.3, Wikipedia-iOS-App-Backlog

May 23 2022

MattCleinman added a comment to T308652: Tapping on a page's first edit on the watchlist produces a 404 error message.

@scblr I'm not sure I understand how this would help this situation - doesn't that link compare two versions, and this situation is talking about when there is only one version of the page?

May 23 2022, 7:45 PM · Wikipedia-Android-App-Backlog (Android Release FY2021-22), Android-app-Bugs

May 20 2022

MattCleinman added a comment to T306281: Boxes in French Wikipedia Skew Section Headers.

This layout bug in the image above is replicable in a web browser if you make the width of the window fairly small: https://fr.wikipedia.org/api/rest_v1/page/mobile-html/%C3%89ph%C3%A9m%C3%A8re

May 20 2022, 9:54 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog

May 19 2022

MattCleinman added a comment to T298814: Add optional talk page icon to the mobile-html endpoint.

@vadim-kovalenko Thanks for your work on this. I want to make sure you saw the comment directly above this - this probably should move from the sign off column, to handle that tweak that is needed. Thank you!

May 19 2022, 5:31 PM · Patch-For-Review, Wikipedia-Android-App-Backlog, Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T308750: Introduce searching for namespaces.

Two questions to answer for the spike:

  1. Can we filter our search API requests to certain domains, or would we do the filtering locally?
  2. Can we do the UI of the bar at the bottom of search?
May 19 2022, 4:22 PM · Wikipedia-Android-App-Backlog (Android Release FY2021-22)

May 18 2022

MattCleinman placed T307407: Issues w/ Arabic Wikipedia in app up for grabs.

Removing myself as assignee, as this is out of app's expertise.

May 18 2022, 9:47 PM · User-Ryasmeen, Product-Infrastructure-Team-Backlog (Kanban), iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon, Wikipedia-iOS-App-Backlog
MattCleinman added a project to T307407: Issues w/ Arabic Wikipedia in app: Product-Infrastructure-Team-Backlog.
May 18 2022, 12:18 AM · User-Ryasmeen, Product-Infrastructure-Team-Backlog (Kanban), iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T307407: Issues w/ Arabic Wikipedia in app.

It's possible there could be a quick fix using .pcs-platform-ios somewhere. But overall, we need to make sure the Ariel font-family isn't what is being used in the body. There may be an on-wiki fix, but I'm not quite sure how this Arabic wiki specific css feeds into PCS.

May 18 2022, 12:15 AM · User-Ryasmeen, Product-Infrastructure-Team-Backlog (Kanban), iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon, Wikipedia-iOS-App-Backlog

May 17 2022

MattCleinman moved T305112: Siri Knowledge: Looking up new article when in app doesn't work from Ready for Development to Needs Code Review on the iOS-app-v6.9.1-Carp-On-A-Moon-Lander board.

monospaced text

May 17 2022, 11:24 PM · iOS-app-v6.9.1-Carp-On-A-Moon-Lander, Wikipedia-iOS-App-Backlog
MattCleinman added a project to T305112: Siri Knowledge: Looking up new article when in app doesn't work: iOS-app-v6.9.1-Carp-On-A-Moon-Lander.

PR: https://github.com/wikimedia/wikipedia-ios/pull/4226

May 17 2022, 11:24 PM · iOS-app-v6.9.1-Carp-On-A-Moon-Lander, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T305112: Siri Knowledge: Looking up new article when in app doesn't work.

PR up shortly. For posterity, the problem:
When a user was in our app, selected a word/phrase, then tapped "Look Up" (and entered the iOS overlay), then tapped the "Siri Knowledge" cell (if available), then tapped "Wikipedia": iOS's overlay would open the link in the app, but currentNavigationController would present the new article VC on the iOS Look Up VC, not the original article VC (as expected). Since the iOS Look Up VC would deinit nearly immediately, the new article would close after a split second.

May 17 2022, 11:14 PM · iOS-app-v6.9.1-Carp-On-A-Moon-Lander, Wikipedia-iOS-App-Backlog
MattCleinman moved T297865: Improve onboarding to talk pages from Epics in Progress to Ready for dev on the Wikipedia-Android-App-Backlog (Android Release FY2021-22) board.
May 17 2022, 4:29 PM · Wikipedia-Android-App-Backlog (Android Release FY2021-22)
MattCleinman moved T307938: Research viability of bringing mute feature into app from Epics in Progress to Ready for dev on the Wikipedia-Android-App-Backlog (Android Release FY2021-22) board.
May 17 2022, 4:29 PM · Wikipedia-Android-App-Backlog (Android Release FY2021-22)
MattCleinman edited projects for T297865: Improve onboarding to talk pages, added: Wikipedia-Android-App-Backlog (Android Release FY2021-22); removed Wikipedia-Android-App-Backlog.
May 17 2022, 4:28 PM · Wikipedia-Android-App-Backlog (Android Release FY2021-22)
MattCleinman edited projects for T307938: Research viability of bringing mute feature into app, added: Wikipedia-Android-App-Backlog (Android Release FY2021-22); removed Wikipedia-Android-App-Backlog.
May 17 2022, 4:28 PM · Wikipedia-Android-App-Backlog (Android Release FY2021-22)
MattCleinman updated subscribers of T307407: Issues w/ Arabic Wikipedia in app.

It's from the CSS font-family: Arial found in site.css, in the first part of the file:

html, body, #content h1, #content h2, #content #firstHeading, .mw-body .mw-editsection, .mw-body .mw-editsection-like, .ui-widget, .mw-body #toc h2, .mw-body .toc h2, .flow-topic-title, h2.flow-board-header-title, .mw-collapsible-toggle, .mw-collapsible-toggle > a, .CategoryTreeToggle, .CategoryTreeEmptyBullet, .NavToggle {
    font-family:Arial
}

Remove this, problem goes away.

May 17 2022, 1:02 AM · User-Ryasmeen, Product-Infrastructure-Team-Backlog (Kanban), iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon, Wikipedia-iOS-App-Backlog

May 13 2022

MattCleinman added a comment to T305112: Siri Knowledge: Looking up new article when in app doesn't work.

It seems like this is because we take our tabViewController's presentedViewController. Unfortunately, in this situation it's the spotlight VC, and it has no relationship to our app's VCs, so we can't start with it and work our way to the expected VC. I think the only way to do this is to work our way up from the tabVC. This gets a tiny bit tricky, as VCs and NavControllers may be pushed or presented on any variety of VCs, so we need to carefully traverse our way up the stack.

May 13 2022, 12:42 AM · iOS-app-v6.9.1-Carp-On-A-Moon-Lander, Wikipedia-iOS-App-Backlog

May 12 2022

MattCleinman added a comment to T305112: Siri Knowledge: Looking up new article when in app doesn't work.

In WMFAppViewController, it presents the VC in (WMFArticleViewController *)showArticleWithURL:(NSURL *)articleURL animated:(BOOL)animated completion:(nonnull dispatch_block_t)completion

May 12 2022, 11:59 PM · iOS-app-v6.9.1-Carp-On-A-Moon-Lander, Wikipedia-iOS-App-Backlog

May 11 2022

MattCleinman added a comment to T307407: Issues w/ Arabic Wikipedia in app.

I can replicate while only messing with text size on the article for Crosswords.
I can see a couple characters change when the text size increases and a word gets kicked to the next line.
Arabic letters have different forms depending on where it is in the word. And a letter moves from the middle-position form to the final-position form as the text size increases and the word moves to another line. Which obviously shouldn’t happen.
It doesn’t happen to this word on web.
Also happens on 15.4.1, but not 15.3 or 14.7
On 15.4.1, It does not happen on the output of PCS loaded in Safari on iOS (https://ar.wikipedia.org/api/rest_v1/page/mobile-html/%D9%83%D9%84%D9%85%D8%A7%D8%AA_%D9%85%D8%AA%D9%82%D8%A7%D8%B7%D8%B9%D8%A9). This seems very app specific.

May 11 2022, 12:33 AM · User-Ryasmeen, Product-Infrastructure-Team-Backlog (Kanban), iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon, Wikipedia-iOS-App-Backlog

May 9 2022

MattCleinman added a comment to T307407: Issues w/ Arabic Wikipedia in app.

Possibilities of source of issue, and some thoughts

  • iOS changed font
    • Looks identical on Windows and macOS and IOS
    • Looks identical on multiple versions of iOS
  • Our app changed something
    • Report came when we were still on 6.8.2 - nothing had changed in months
  • Somewhere on Wikipedia servers changed font
    • Android isn’t seeing similar complaints (though there could be something Android-specific that means a PCS change isn’t being seen on Android)
    • No reports of issues elsewhere
May 9 2022, 11:25 PM · User-Ryasmeen, Product-Infrastructure-Team-Backlog (Kanban), iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T307407: Issues w/ Arabic Wikipedia in app.

@alaa we're trying to track this down, and are having some trouble. Apologies for my ignorance, but can you help confirm the problem with these screenshots? My understanding of Arabic is that the same letter may be written different depending on whether it is at the start of the word, in the middle, or at the end. Is this the issue that we're having? Or is it something different?

May 9 2022, 11:24 PM · User-Ryasmeen, Product-Infrastructure-Team-Backlog (Kanban), iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon, Wikipedia-iOS-App-Backlog

May 6 2022

MattCleinman closed T301600: REST endpoints cannot handle requests from ka.wikipedia.org with Georgian titles as Resolved.

@JMinor and @JTannerWMF are okay with natural cache replacement. The bug exists only in cached articles. As articles get edited, the cache will get updated. (There is no automatic refresh of this cache, it turns out.) It looks like about 6k articles per month are edited, and this bug cropped up in January/February of this year…. which means given that the fix was deployed 2 weeks ago, it will (mostly) naturally take care of itself in the next few months. (And if we get complaints on specific articles, we can run open the URL with ?action=purge to immediately invalidate.)

May 6 2022, 8:51 PM · Parsoid (Tracking), RESTBase, Patch-For-Review, Wikipedia-Android-App-Backlog (Android Release FY2021-22), Product-Infrastructure-Team-Backlog, Page Content Service

May 5 2022

MattCleinman added a comment to T301600: REST endpoints cannot handle requests from ka.wikipedia.org with Georgian titles.

It seems like the problem has been fixed, but old (and broken) versions exist in the cache. This is now article-specific, and the cache will naturally be updated when each article gets updated. I'd like to look into invalidating the cache in a more complete fashion, so let's keep this open for now.

May 5 2022, 11:51 PM · Parsoid (Tracking), RESTBase, Patch-For-Review, Wikipedia-Android-App-Backlog (Android Release FY2021-22), Product-Infrastructure-Team-Backlog, Page Content Service

May 4 2022

MattCleinman added a comment to T307373: Hide '+ ADD ARTICLE DESCRIPTION' CTA when 'Reading focus mode' is enabled .

This works on both web (https://en.wikipedia.org/api/rest_v1/page/mobile-html/Metapuzzle, then in console run pcs.c1.Page.setEditButtons(false)) and on iOS in app.

May 4 2022, 12:51 AM · Wikipedia-Android-App-Backlog (Android Release FY2021-22), Product-Infrastructure-Team-Backlog (Kanban)

May 2 2022

MattCleinman created T307408: Chinese language variant issue in search results.
May 2 2022, 11:56 PM · Chinese-Sites, Wikipedia-iOS-App-Backlog
MattCleinman created T307407: Issues w/ Arabic Wikipedia in app.
May 2 2022, 11:50 PM · User-Ryasmeen, Product-Infrastructure-Team-Backlog (Kanban), iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T284839: [OTRS]: On this day content cut off underneath header when deep linking from widget.

Another report: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=12173516

May 2 2022, 11:12 PM · iOS-app-Bugs, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T307252: push-notifications: Validate APNS and FCM credentials on startup.

Happy to help with this however we can. So you know, this APNs key rotation isn't something we anticipate happening frequently, so we may not want to over-engineer an automated check for it. There is no expiry of the key. In this case, we wanted to rotate the key we had been using for dev before it goes to production, but from here out we don't expect to update it even once per year.

May 2 2022, 6:35 PM · Push-Notification-Service, Product-Infrastructure-Team-Backlog, Wikipedia-iOS-App-Backlog, serviceops

Apr 22 2022

MattCleinman moved T305892: User requested feature to place cursor directly in search if open app on search setting is enabled from Tasks from Product Backlog to Needs Code Review on the iOS-app-v6.9-Carp-On-A-Zamboni board.
Apr 22 2022, 8:41 PM · iOS-app-v6.9-Carp-On-A-Zamboni, Wikipedia-iOS-App-Backlog
MattCleinman edited projects for T305892: User requested feature to place cursor directly in search if open app on search setting is enabled, added: iOS-app-v6.9-Carp-On-A-Zamboni; removed iOS-app-v6.9.1-Carp-On-A-Moon-Lander.

PR: https://github.com/wikimedia/wikipedia-ios/pull/4198

Apr 22 2022, 8:41 PM · iOS-app-v6.9-Carp-On-A-Zamboni, Wikipedia-iOS-App-Backlog

Apr 21 2022

MattCleinman added a comment to T301744: Syncing Saved Articles: If iOS device removes articles in `Saved`, they don't delete on Android.

Despite repro'ing this several times before I filed this, I can't repro it anymore. Closing.

Apr 21 2022, 11:41 PM · Wikipedia-Android-App-Backlog (Android Release FY2021-22)
MattCleinman moved T288546: Rotate APNS key before deploying Push Notifications to Production from Blocked or Waiting to Doing on the iOS-app-v6.9-Carp-On-A-Zamboni board.
Apr 21 2022, 7:15 PM · serviceops, iOS-app-v6.9-Carp-On-A-Zamboni, Product-Infrastructure-Team-Backlog, Wikipedia-iOS-App-Backlog
MattCleinman added a comment to T305763: "View edit history" menu item in the mobile-html footer shows incorrect edit status in zhwiki.

If not easy to give contextual dates ("3 months ago"), better to just give absolute dates ("Dec 20 2022") in Chinese.

Apr 21 2022, 5:39 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Parsoid (Tracking), Wikipedia-Android-App-Backlog, Chinese-Sites, Page Content Service, RESTBase
MattCleinman moved T305549: Collect analytics for theme issues across different wikis which uses specific templates. Add performance tests. from Needs Triage to Tracking on the Wikipedia-Android-App-Backlog board.
Apr 21 2022, 4:20 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, Page Content Service
MattCleinman moved T301600: REST endpoints cannot handle requests from ka.wikipedia.org with Georgian titles from Needs Triage to Tracking on the Wikipedia-Android-App-Backlog board.
Apr 21 2022, 4:19 PM · Parsoid (Tracking), RESTBase, Patch-For-Review, Wikipedia-Android-App-Backlog (Android Release FY2021-22), Product-Infrastructure-Team-Backlog, Page Content Service
MattCleinman moved T301600: REST endpoints cannot handle requests from ka.wikipedia.org with Georgian titles from Epics in Progress to QA signoff on the Wikipedia-Android-App-Backlog (Android Release FY2021-22) board.
Apr 21 2022, 4:19 PM · Parsoid (Tracking), RESTBase, Patch-For-Review, Wikipedia-Android-App-Backlog (Android Release FY2021-22), Product-Infrastructure-Team-Backlog, Page Content Service
MattCleinman triaged T305763: "View edit history" menu item in the mobile-html footer shows incorrect edit status in zhwiki as Medium priority.
Apr 21 2022, 4:18 PM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Parsoid (Tracking), Wikipedia-Android-App-Backlog, Chinese-Sites, Page Content Service, RESTBase
MattCleinman moved T305912: Wikipedia android app shows wrong tab preview from Needs Triage to Up Next on the Wikipedia-Android-App-Backlog board.
Apr 21 2022, 4:16 PM · Wikipedia-Android-App-Backlog (Android Release FY2021-22)
MattCleinman moved T305912: Wikipedia android app shows wrong tab preview from Epics in Progress to Merged and Waiting on the Wikipedia-Android-App-Backlog (Android Release FY2021-22) board.
Apr 21 2022, 4:16 PM · Wikipedia-Android-App-Backlog (Android Release FY2021-22)
MattCleinman triaged T305912: Wikipedia android app shows wrong tab preview as Low priority.
Apr 21 2022, 4:16 PM · Wikipedia-Android-App-Backlog (Android Release FY2021-22)
MattCleinman added a comment to T305506: Promote or remove experimental MW core API endpoints.

iOS also doesn't use them or plan to. Seems like they're safe to remove, at least from the standpoint of mobile apps.

Apr 21 2022, 3:58 PM · MW-1.39-notes (1.39.0-wmf.8; 2022-04-18), Patch-For-Review, Platform Team Initiatives (MW REST API in PHP), MediaWiki-REST-API, API Platform

Apr 18 2022

MattCleinman updated subscribers of T305506: Promote or remove experimental MW core API endpoints.

Adding @Dbrant - Do you know the history of these? (These pre-date my and Jazmin's time on the team, but thinking Dmitry may know off the top of his head.)

Apr 18 2022, 11:13 PM · MW-1.39-notes (1.39.0-wmf.8; 2022-04-18), Patch-For-Review, Platform Team Initiatives (MW REST API in PHP), MediaWiki-REST-API, API Platform
MattCleinman added a comment to T288546: Rotate APNS key before deploying Push Notifications to Production.

@Dzahn I don't believe I have access to production servers - is that what you mean by deployment ones?

Apr 18 2022, 10:45 PM · serviceops, iOS-app-v6.9-Carp-On-A-Zamboni, Product-Infrastructure-Team-Backlog, Wikipedia-iOS-App-Backlog
MattCleinman triaged T305777: On this day feed card content cannot be found in the on this day list as Low priority.

Content showing up in Featured feed should also be in OnThisDay feed.

Apr 18 2022, 4:29 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikifeeds, Wikipedia-Android-App-Backlog
MattCleinman triaged T306191: Display issue with pie chart in dark mode as Low priority.
Apr 18 2022, 4:22 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog
MattCleinman triaged T306281: Boxes in French Wikipedia Skew Section Headers as Medium priority.
Apr 18 2022, 4:21 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog