Page MenuHomePhabricator
Create Task
Maniphest T277351

[OTRS] Unexpected behavior with context menu "Share" action
Closed, ResolvedPublic
Actions

Description

From https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=11736306

On iOS, if you select text within an article and use the popover menu to copy the text, everything works as intended. But if you instead tap “share” to bring the share sheet, the output being passed to the next app / action is not the selected text (as expected) but rather a link to the article you are viewing.

Essentially - the other actions in the context menu are about the selected snippet. The share action is not.

Possibilities

  • Change text to "share article"
  • Include the selected snippet of text with the article URL

Event Timeline

• MattCleinman created this task.Mar 13 2021, 12:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 13 2021, 12:44 AM
Nonissue subscribed.EditedMar 13 2021, 1:01 AM

Hey! Thanks for creating a ticket about this so quickly (I reported the bug via email yesterday).

I personally think that the appropriate behaviour is just to share the selected text as it is. I tested several other iOS apps (both first and third party) using a Siri shortcut that displays the shortcuts input, and all of the apps only sent the selected text.

Furthermore, there is already a share menu for the article itself, so I don’t think changing the context menu or sending a URL with the selected text would be appropriate. If either of those solutions were implemented, there’s be no direct way to pass selected text from a Wikipedia article to another app or a Siri shortcut.

I hope that all makes sense and helps in some way.

Ps. I spent half an hour looking through the source on GitHub trying to find where the context menu is implemented, but couldn’t pinpoint it and I’m not at all familiar with swift otherwise I’d submit a PR.

• MattCleinman triaged this task as Low priority.Mar 15 2021, 6:36 PM
• MattCleinman moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.

Josh/Carolyn: Let's add a snippet to it, along with teh link.

• MattCleinman added a project: iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon.May 24 2022, 12:31 AM
• MattCleinman moved this task from Tasks from Product Backlog to Needs Code Review on the iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon board.
• MattCleinman added a comment.Jun 21 2022, 7:11 PM

PR: https://github.com/wikimedia/wikipedia-ios/pull/4232

LGoto edited projects, added iOS-app-v6.9.3; removed iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon.Jun 21 2022, 9:54 PM
LGoto moved this task from Tasks from Product Backlog to Needs Code Review on the iOS-app-v6.9.3 board.
Tsevener moved this task from Needs Code Review to Needs QA on the iOS-app-v6.9.3 board.Jun 23 2022, 3:14 PM
ABorbaWMF moved this task from Needs QA to Blocked or Waiting on the iOS-app-v6.9.3 board.Jul 20 2022, 7:49 PM
ABorbaWMF subscribed.

Tested on 6.9.3 (1948)

I was a little unclear on the expected results here so I thought I would flag this one for a little review. Below is a screenshot of the same text. The top was done using 'copy' from the highlight menu and the bottom was done using 'share' and then 'copy' from the share menu.

IMG_3A1EAE2FCA84-1.jpeg (2×2 px, 833 KB)

cmadeo moved this task from Blocked or Waiting to Ready for PM Signoff on the iOS-app-v6.9.3 board.Jul 28 2022, 7:09 PM
cmadeo subscribed.

@ABorbaWMF Thanks! This is the expected behavior, will move over to PM sign-off

• JMinor closed this task as Resolved.Oct 18 2022, 9:07 PM
• JMinor claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL