User talk page message notifications on non-latin topic titles do not navigate to specific reply thread
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Tsevener
	May 4 2022, 5:35 PM

Description

How many times were you able to reproduce it?

Every time

Steps to reproduce

Trigger a user talk page notification on a topic that has a special character in the topic title (i.e. non-latin characters).
In Notifications Center detail screen, tap "Your talk page"

Expected results

User is navigated to that particular talk page topic reply thread

Actual results

User is navigated to their user talk page topic list screen, and has to seek out reply thread.

Screenshots

Environments observed

App version: 6.9.0 (1921)
OS versions: 15.4.1
Device model: iPhone 7
Device language: EN

Related Objects

Mentioned In: T315043: Release 6.9.3
T307603: User talk message notifications from notifications API does not encode link fragments
Mentioned Here: T307603: User talk message notifications from notifications API does not encode link fragments
T307529: Notifications - missing message and broken navigation for non-latin user talk page messages

Event Timeline

Tsevener created this task.May 4 2022, 5:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 4 2022, 5:35 PM

Note - initial fix attempt is in branch T307529-nested-talk-reply, but that fix depends on https://phabricator.wikimedia.org/T307603 getting fixed on the server-side first.

Tsevener renamed this task from User talk page message notifications on non-latin topic titles do not navigate to reply thread to User talk page message notifications on non-latin topic titles do not navigate to specific reply thread.May 4 2022, 5:39 PM

LGoto triaged this task as Medium priority.May 9 2022, 6:36 PM

LGoto added a project: iOS-app-v6.9.1-Carp-On-A-Moon-Lander.

LGoto removed a project: iOS-app-v6.9.1-Carp-On-A-Moon-Lander.

LGoto moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.

Tsevener mentioned this in T307603: User talk message notifications from notifications API does not encode link fragments.Jun 21 2022, 9:39 PM

We're opting out of encoding this on the server-side. We'll have to adjust the urlString here first by url encoding all characters after the first # mark. That should help this successfully insantiate.

Even once this is fixed, we still might need this commit to get it to properly deep link to talk page reply thread.

LGoto added a project: iOS-app-v6.9.3.Jun 21 2022, 9:51 PM

• MattCleinman moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v6.9.3 board.Jun 27 2022, 6:38 PM

Tsevener claimed this task.Jul 29 2022, 7:29 PM

Tsevener moved this task from Ready for Development to Doing on the iOS-app-v6.9.3 board.

Tsevener moved this task from Doing to Needs Code Review on the iOS-app-v6.9.3 board.Jul 29 2022, 9:39 PM

https://github.com/wikimedia/wikipedia-ios/pull/4282

• Dmantena moved this task from Needs Code Review to Needs QA on the iOS-app-v6.9.3 board.Aug 8 2022, 4:36 PM

Tsevener removed Tsevener as the assignee of this task.Aug 11 2022, 7:43 PM