Get rid of useWhitespaceHeuristics
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Arlolra
	Sep 21 2020, 10:14 PM

Description

The code paths in DOMHandler::getTrailingSpace() and DOMHandler::getLeadingSpace() taken when useWhitespaceHeuristics is true seem like they're better placed in Separators::buildSep() where the other logic to restore original separators already exists. This duplication has led to a few bugs (T260960 / T245206).

From the discussion in the review,
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/628955/3/src/Html2Wt/DOMHandlers/DOMHandler.php

buildSep was assumed to restore separators only between adjacent elements, however, it has an asymmetric path of walking back from non-elements nodes to find an element to calculate dsr off of. That should maybe be extended to both directions.
Some helpers can be created to help clarify predicates, like,
- DOMUtils::haveDSR($node) for $node instanceof DOMElement and !empty( .. dsr ... )
- !isAnOldEltNode( $lc )) for !$lc || !DOMUtils::isElt( $lc ) || WTUtils::isNewElt( $lc )

Details

Subject	Repo	Branch	Lines +/-
Move whitespace heuristics for trimmable whitespace nodes to buildSep	mediawiki/services/parsoid	master	+252 -89
Bump wikimedia/parsoid to 0.13.0-a12	mediawiki/vendor	master	+1 K -974
Bump wikimedia/parsoid to 0.13.0-a11	mediawiki/vendor	master	+552 -378
Avoid double dip whitespace reuse when getting trailing space	mediawiki/services/parsoid	master	+34 -12

Customize query in gerrit

Related Objects

Mentioned Here: T245206: VE removes space in wikitext in list elements starting with wikilinks
T260960: Visual editor adds unwanted whitespaces at the end of section headings using french-spacing at each edit

Event Timeline

Arlolra created this task.Sep 21 2020, 10:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2020, 10:15 PM

• ssastry triaged this task as Medium priority.Sep 21 2020, 10:46 PM

• ssastry moved this task from Needs Triage to Tech Debt / Big changes on the Parsoid board.

Change 628955 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Avoid double dip whitespace reuse when getting trailing space

https://gerrit.wikimedia.org/r/628955

gerritbot added a project: Patch-For-Review.Sep 22 2020, 4:36 PM

Arlolra updated the task description. (Show Details)Sep 23 2020, 9:32 PM

Change 628955 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Avoid double dip whitespace reuse when getting trailing space

https://gerrit.wikimedia.org/r/628955

Maintenance_bot removed a project: Patch-For-Review.Sep 23 2020, 10:10 PM

Change 630676 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump wikimedia\parsoid to 0.13.0-a11

https://gerrit.wikimedia.org/r/630676

gerritbot added a project: Patch-For-Review.Sep 28 2020, 8:36 PM

Change 630676 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a11

https://gerrit.wikimedia.org/r/630676

Maintenance_bot removed a project: Patch-For-Review.Sep 29 2020, 1:10 AM

Change 630711 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] WIP: move whitespace heuristics to buildSep

https://gerrit.wikimedia.org/r/630711

gerritbot added a project: Patch-For-Review.Sep 29 2020, 2:21 AM

Since I am in this code right now to tackle list items & selser issues for discussion tools, might as well clean this up.

Change 630711 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Move whitespace heuristics for trimmable whitespace nodes to buildSep

https://gerrit.wikimedia.org/r/630711

Maintenance_bot removed a project: Patch-For-Review.Oct 19 2020, 4:10 PM

Change 635100 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a12

https://gerrit.wikimedia.org/r/635100

gerritbot added a project: Patch-For-Review.Oct 19 2020, 10:52 PM

Change 635100 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a12

https://gerrit.wikimedia.org/r/635100

Maintenance_bot removed a project: Patch-For-Review.Oct 20 2020, 2:10 AM

• ssastry removed • ssastry as the assignee of this task.Nov 16 2020, 5:58 PM

• ssastry subscribed.

Arlolra closed this task as Resolved.Nov 16 2020, 6:10 PM

Arlolra assigned this task to • ssastry.