Page MenuHomePhabricator
Create Task
Maniphest T264175

syntaxhighlight doesn't highlight "VALUES" in SPARQL
Closed, ResolvedPublic
Actions

Description

Hi,

For some reason, at least the "VALUES" keyword in language SPARQL is not recognize by syntaxhighlight.

See for instance https://www.wikidata.org/wiki/Wikidata:SPARQL_query_service/queries/examples#Wikidata_items_of_Wikipedia_articles where VALUES is in black but should be highlighted in red.

PS: I've checked, this is standard SPARQL (see https://www.w3.org/TR/sparql11-query/#inline-data-syntax ).

Related Objects

Event Timeline

VIGNERON created this task.Sep 30 2020, 11:17 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2020, 11:17 AM
LucasWerkmeister claimed this task.Sep 30 2020, 12:50 PM
LucasWerkmeister subscribed.

Fix submitted upstream in https://github.com/pygments/pygments/pull/1559.

LucasWerkmeister changed the task status from Open to Stalled.Oct 2 2020, 9:34 PM

Upstream pull request was merged, but the next release might take a while…

Aklapper added a project: Upstream.Oct 3 2020, 10:32 AM
Aklapper moved this task from Backlog to Patch merged upstream on the Upstream board.
Aklapper added a comment.Nov 30 2020, 10:31 AM

The upstream change is included in the released version 2.7.2. Not sure what that means when deploying new versions somehow on Wikimedia servers though.

LucasWerkmeister added a subscriber: ori.Dec 5 2020, 1:06 PM

@ori updated Pygments recently (I0be3c1c204), so we should only need to wait for the wmf.20 rollout (T263186) now.

Aklapper changed the task status from Stalled to Open.Dec 29 2020, 1:25 PM
In T264175#6670961, @LucasWerkmeister wrote:

updated Pygments recently (I0be3c1c204), so we should only need to wait for the wmf.20 rollout now.

wmf.20 was deployed; is there more to do here or can this be resolved?

LucasWerkmeister closed this task as Resolved.Dec 29 2020, 1:57 PM

Verification doesn’t hurt:

Screenshot_2020-12-29 Wikidata SPARQL query service queries examples - Wikidata.png (561×1 px, 96 KB)

It works \o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL