1.36.0-wmf.20 deployment blockers
Closed, ResolvedPublicRelease
Actions

Details

Backup Train Conductor: • mmodell
Release Version: 1.36.0-wmf.20
Release Date: Nov 30 2020, 12:00 AM

2020 week 49 1.36-wmf.20 Changes wmf/1.36.0-wmf.20

This MediaWiki Train Deployment is scheduled for the week of Monday, November 30th:

Monday November 30th	Tuesday, December 1st	Wednesday, December 2nd	Thursday, December 3rd	Friday
Backports only.	Branch `wmf.20` and deploy to Group 0 Wikis.	Deploy `wmf.20` to Group 1 Wikis.	Deploy `wmf.20` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.20 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.36.0-wmf.19

Next: 1.36.0-wmf.21

	Subject	Repo	Branch	Lines +/-
	Branch commit for wmf/1.36.0-wmf.20	mediawiki/core	wmf/1.36.0-wmf.20	+961 -3

Customize query in gerrit

Revisions and Commits

rECTR extension-CategoryTree
	rECTRf6c2d74259b9 Use ParserOutput::extensionData instead of dynamic properties.
rMW MediaWiki
	rMW8e61bed3e38d ParserOutput: temporary undeprecate getting dynamic properties.

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Release	hashar	T263186 1.36.0-wmf.20 deployment blockers
Resolved		Umherirrender	T268360 captcha error text no longer shown as parsed message on Special:Contact
Declined	PRODUCTION ERROR	None	T269278 Out of memory error reaching 700MBytes since 1.36.0-wmf.20
Resolved	PRODUCTION ERROR	Daimona	T269314 Argument 5 passed to MediaWiki\Extension\AbuseFilter\Filter\Specs::__construct() must be of the type string, null given, called in /srv/mediawiki/php-1.36.0-wmf.20/extensions/AbuseFilter/includes/FilterLookup.php on line 346
Resolved	BUG REPORT	daniel	T269396 Parser cache serving old results

Event Timeline

thcipriani created this task.Sep 17 2020, 7:30 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2020, 7:30 PM

thcipriani assigned this task to hashar.Nov 6 2020, 4:14 PM

thcipriani triaged this task as Medium priority.

thcipriani mentioned this in T263184: 1.36.0-wmf.18 deployment blockers.

thcipriani updated Other Assignee, added: • mmodell.

thcipriani added a project: Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)).

thcipriani moved this task from INBOX to Deployment on the Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)) board.

Umherirrender added a subtask: T268360: captcha error text no longer shown as parsed message on Special:Contact.Nov 20 2020, 5:54 PM

Umherirrender closed subtask T268360: captcha error text no longer shown as parsed message on Special:Contact as Resolved.Nov 23 2020, 5:24 PM

Change 644387 had a related patch set uploaded (by DannyS712; owner: trainbranchbot):
[mediawiki/core@wmf/1.36.0-wmf.20] Branch commit for wmf/1.36.0-wmf.20

https://gerrit.wikimedia.org/r/644387

gerritbot added a project: Patch-For-Review.Dec 1 2020, 3:03 AM

Change 644387 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.20] Branch commit for wmf/1.36.0-wmf.20

https://gerrit.wikimedia.org/r/644387

Mentioned in SAL (#wikimedia-operations) [2020-12-01T12:57:56Z] <hashar> Preparing deployment of 1.36.0-wmf.20 # T263186

• Mholloway subscribed.Dec 1 2020, 5:38 PM

So yesterday I have promoted the "testwikis" and today I have promoted the group1 wikis. The group0 wikis have NOT been promoted.

Mentioned in SAL (#wikimedia-operations) [2020-12-02T14:56:08Z] <hashar> Promoting group0 to 1.36.0-wmf.20 since I haven't done so yesterday :-\ # T263186

Filed T269242: Change deploy-promote to check previous groups have been promoted beforehand about deploy-promote.

These 3 back ports get rid of deprecation warnings T269235 and T269236 seen in production in wmf.20:

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CategoryTree/+/644815
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/644816
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/644817

This is just deprecations, so it's not critical, however there might be quite a bit of the log spam in deprecation channel when wmf.20 hits group2, so I would recommend merging the backports.

Krinkle closed subtask T269278: Out of memory error reaching 700MBytes since 1.36.0-wmf.20 as Declined.Dec 2 2020, 7:25 PM

thcipriani added a subtask: T269286: Monolog update removes exception object from logstash.Dec 2 2020, 7:25 PM

@Pchelolo I probably should have filed a single task for those two. I will be out for rest of the day, but you have my blessing to have those fix deployed today!

Mentioned in SAL (#wikimedia-operations) [2020-12-02T20:56:22Z] <twentyafterfour> deploying backports for 1.36.0-wmf.20 refs T263186

Deploying these patches:

rMW8b5451aae893: Parser: use setter instead of accessing ParserOutput property
rMW8e61bed3e38d: ParserOutput: temporary undeprecate getting dynamic properties.
rECTRf6c2d74259b9: Use ParserOutput::extensionData instead of dynamic properties.

• mmodell added a commit: rECTRf6c2d74259b9: Use ParserOutput::extensionData instead of dynamic properties..Dec 2 2020, 9:20 PM

• mmodell added a commit: rMW8e61bed3e38d: ParserOutput: temporary undeprecate getting dynamic properties..Dec 2 2020, 10:31 PM

Mentioned in SAL (#wikimedia-operations) [2020-12-02T22:38:46Z] <twentyafterfour@deploy1001> Synchronized php-1.36.0-wmf.20/includes/parser/: Deploying backports for wmf.20 refs T263186 (duration: 01m 08s)

Mentioned in SAL (#wikimedia-operations) [2020-12-02T22:43:05Z] <twentyafterfour@deploy1001> Synchronized php-1.36.0-wmf.20/extensions/CategoryTree/: Deploying backport f6c2d74259b9 to wmf.20, bug: T269235 refs T263186 (duration: 01m 07s)

Stashbot mentioned this in T269235: [X8ehRwpAICgAALHNCUsAAACI] /wiki/clamor ErrorException from line 157 of /srv/mediawiki/php-1.36.0-wmf.20/extensions/CategoryTree/includes/CategoryTreeHooks.php: ParserOutput::mCategoryTreeTag dynamic property write access deprecated [Called from CategoryTreeHooks::parserHook].Dec 2 2020, 10:43 PM

Reedy removed a subtask: T269286: Monolog update removes exception object from logstash.Dec 3 2020, 1:23 AM

Krinkle added a subtask: T269314: Argument 5 passed to MediaWiki\Extension\AbuseFilter\Filter\Specs::__construct() must be of the type string, null given, called in /srv/mediawiki/php-1.36.0-wmf.20/extensions/AbuseFilter/includes/FilterLookup.php on line 346.Dec 3 2020, 3:18 AM

• mmodell added a subtask: T269315: Fatal error: Cannot pass parameter 1 by reference (Wikibase\DataModel\Entity).Dec 3 2020, 6:32 AM

Ladsgroup removed a subtask: T269315: Fatal error: Cannot pass parameter 1 by reference (Wikibase\DataModel\Entity).Dec 3 2020, 1:13 PM

Ladsgroup subscribed.Dec 3 2020, 1:48 PM

Blockers got solved or ruled out as preexisting conditions. I am going to promote all wikis.

There was one occurrence of a logging issue on a request to a Parsoid server ( T269386 ) but that does not seem worth rolling back. Nothing else is showing in the log at least.

JJMC89 added a subtask: T269396: Parser cache serving old results.Dec 3 2020, 9:23 PM

• mmodell reopened this task as Open.Dec 3 2020, 9:39 PM

Mentioned in SAL (#wikimedia-operations) [2020-12-03T21:39:33Z] <twentyafterfour> rolling back wmf.20 due to T269396 refs T263186

Change 645178 had a related patch set uploaded (by 20after4; owner: 20after4):
[operations/mediawiki-config@master] All wikis (except testwikis) to 1.36.0-wmf.18 refs T269396 and T263186

https://gerrit.wikimedia.org/r/645178

Change 645178 merged by jenkins-bot:
[operations/mediawiki-config@master] All wikis (except testwikis) to 1.36.0-wmf.18 refs T269396 and T263186

https://gerrit.wikimedia.org/r/645178

Rolled back due to an incompatibility of ParserOutput class signature between 1.36.0-wmf.18 and 1.36.0-wmf.20. That is an issue that has often hit us in the past and is tricky enough that we end up hitting it from time to time. The task is being worked on by all the appropriate people so it is on track, though I anticipate itl take a bit of time to address it or find a workaround and get the train unblocked.

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/645157 will fix the wmf.20 issue, however for wmf.21 I would like to take some time and try to get it right. If I don’t get it by Monday, we can revert on master too.

LucasWerkmeister mentioned this in T264175: syntaxhighlight doesn't highlight "VALUES" in SPARQL.Dec 5 2020, 1:06 PM

Urbanecm added a subtask: Restricted Task.Dec 5 2020, 1:31 PM

Urbanecm subscribed.

Warning: I created {T269497} (available only to acl*security) and added it as a train blocker to this task.

Urbanecm removed a subtask: Restricted Task.Dec 5 2020, 2:41 PM

Lucas_Werkmeister_WMDE subscribed.Dec 7 2020, 11:37 AM

Lucas_Werkmeister_WMDE mentioned this in T268625: [20h] Investigate the significant number of skipped Item IDs for newly created Wikidata items.Dec 7 2020, 1:52 PM

When the revert https://gerrit.wikimedia.org/r/c/mediawiki/core/+/645312 is merged by CI, I will promote group0/group1 wikis to 1.36.0-wmf.20. Not sure I can do the rest of the wikis since I have a personal appointment in two hours.

• LarsWirzenius unsubscribed.Dec 7 2020, 2:16 PM

hashar closed this task as Resolved.Dec 7 2020, 2:57 PM

daniel closed subtask T269396: Parser cache serving old results as Resolved.Dec 8 2020, 3:44 PM

1.36.0-wmf.20 deployment blockersClosed, ResolvedPublicReleaseActions