Page MenuHomePhabricator

LarsWirzenius (Lars Wirzenius)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 9 2018, 11:58 AM (107 w, 2 d)
Availability
Available
IRC Nick
liw
LDAP User
Lars Wirzenius
MediaWiki User
LWirzenius (WMF) [ Global Accounts ]

Recent Activity

Yesterday

LarsWirzenius created T266676: Make a Scap release.
Wed, Oct 28, 2:32 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2))

Mon, Oct 26

LarsWirzenius added a comment to T266432: Increase on database writes and deletes activity on Commonswiki leads to some replication lag.

@thcipriani Sorry, I have no recollection that anything that would cause this happened. But my memory is not great.

Mon, Oct 26, 4:29 PM · Platform Engineering, Wikimedia-production-error, DBA, Commons, Release-Engineering-Team, Operations

Fri, Oct 23

LarsWirzenius closed T263180: 1.36.0-wmf.14 deployment blockers as Resolved.

Train's been at group2 for about 22 hours. I'm tempting fate by declaring this done.

Fri, Oct 23, 11:54 AM · Release-Engineering-Team-TODO, Release, Train Deployments

Thu, Oct 22

LarsWirzenius added a comment to T263180: 1.36.0-wmf.14 deployment blockers.

Reported T266234: PHP Warning: fclose() expects parameter 1 to be resource, boolean given but not as a blocker.

Thu, Oct 22, 1:11 PM · Release-Engineering-Team-TODO, Release, Train Deployments
LarsWirzenius created T266234: PHP Warning: fclose() expects parameter 1 to be resource, boolean given.
Thu, Oct 22, 1:10 PM · MediaWiki-Uploading, Structured-Data-Backlog (Current Work), Platform Team Initiatives (API Gateway), UploadWizard, Structured Data Engineering, Wikimedia-production-error

Wed, Oct 21

LarsWirzenius lowered the priority of T266108: Call to undefined method MediaWiki\Session\UserInfo::isVerifidd() from Unbreak Now! to Needs Triage.
Wed, Oct 21, 4:02 PM · MediaWiki-extensions-CentralAuth, Wikimedia-production-error
LarsWirzenius added a comment to T265501: Make a way to build Scap .deb in Docker.

While this won't block me starting the release process of the next Scap release, I would like to get this .deb building thing resolved soon. Has serviceops had time to discuss this?

Wed, Oct 21, 3:10 PM · serviceops, Operations, Scap, Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2))
LarsWirzenius closed T266051: Class 'TranslatablePage' not found, a subtask of T245183: PHP7 corruption reports in 2020 (Call on wrong object, etc.), as Resolved.
Wed, Oct 21, 3:07 PM · Wikimedia-production-error, serviceops, Operations
LarsWirzenius closed T266051: Class 'TranslatablePage' not found as Resolved.

Closing as this seems to have been an opcache corruption issue.

Wed, Oct 21, 3:07 PM · Wikimedia-production-error
LarsWirzenius updated subscribers of T266108: Call to undefined method MediaWiki\Session\UserInfo::isVerifidd().

Restarted php-fpm, as per advice from @CDanis and @Joe on IRC.

Wed, Oct 21, 1:43 PM · MediaWiki-extensions-CentralAuth, Wikimedia-production-error
LarsWirzenius added a comment to T266108: Call to undefined method MediaWiki\Session\UserInfo::isVerifidd().

About a thousand now.

Wed, Oct 21, 1:23 PM · MediaWiki-extensions-CentralAuth, Wikimedia-production-error
LarsWirzenius added a comment to T266108: Call to undefined method MediaWiki\Session\UserInfo::isVerifidd().

I note that right after promoting train to group1, there were hundreds of Verifidd errors in logstash.

Wed, Oct 21, 1:12 PM · MediaWiki-extensions-CentralAuth, Wikimedia-production-error
LarsWirzenius removed a subtask for T263180: 1.36.0-wmf.14 deployment blockers: T266108: Call to undefined method MediaWiki\Session\UserInfo::isVerifidd().
Wed, Oct 21, 10:15 AM · Release-Engineering-Team-TODO, Release, Train Deployments
LarsWirzenius removed a parent task for T266108: Call to undefined method MediaWiki\Session\UserInfo::isVerifidd(): T263180: 1.36.0-wmf.14 deployment blockers.
Wed, Oct 21, 10:15 AM · MediaWiki-extensions-CentralAuth, Wikimedia-production-error
LarsWirzenius added a comment to T266108: Call to undefined method MediaWiki\Session\UserInfo::isVerifidd().

Opcache corruption again? That seems to happen regardless of what version of the code is running. Removing as blocker.

Wed, Oct 21, 10:15 AM · MediaWiki-extensions-CentralAuth, Wikimedia-production-error
LarsWirzenius added a comment to T265523: PHP Notice: Undefined index: href (from ContentTranslationSpecialPage.php).

This seems to be happening somewhat in this week's train. About 18 instance in the last four hours on group0.

Wed, Oct 21, 10:14 AM · Language-Team (Language-2020-October-December), MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), ContentTranslation, Wikimedia-production-error
LarsWirzenius added a comment to T263180: 1.36.0-wmf.14 deployment blockers.

Reported T266108: Call to undefined method MediaWiki\Session\UserInfo::isVerifidd() as a blocker.

Wed, Oct 21, 10:03 AM · Release-Engineering-Team-TODO, Release, Train Deployments
LarsWirzenius added a subtask for T263180: 1.36.0-wmf.14 deployment blockers: T266108: Call to undefined method MediaWiki\Session\UserInfo::isVerifidd().
Wed, Oct 21, 10:03 AM · Release-Engineering-Team-TODO, Release, Train Deployments
LarsWirzenius added a parent task for T266108: Call to undefined method MediaWiki\Session\UserInfo::isVerifidd(): T263180: 1.36.0-wmf.14 deployment blockers.
Wed, Oct 21, 10:03 AM · MediaWiki-extensions-CentralAuth, Wikimedia-production-error
LarsWirzenius triaged T266108: Call to undefined method MediaWiki\Session\UserInfo::isVerifidd() as Unbreak Now! priority.
Wed, Oct 21, 10:02 AM · MediaWiki-extensions-CentralAuth, Wikimedia-production-error
LarsWirzenius created T266108: Call to undefined method MediaWiki\Session\UserInfo::isVerifidd().
Wed, Oct 21, 10:02 AM · MediaWiki-extensions-CentralAuth, Wikimedia-production-error

Tue, Oct 20

LarsWirzenius added a comment to T263180: 1.36.0-wmf.14 deployment blockers.

Reported T263180: 1.36.0-wmf.14 deployment blockers as blocker.

Tue, Oct 20, 5:05 PM · Release-Engineering-Team-TODO, Release, Train Deployments
LarsWirzenius added a subtask for T263180: 1.36.0-wmf.14 deployment blockers: T266051: Class 'TranslatablePage' not found.
Tue, Oct 20, 5:05 PM · Release-Engineering-Team-TODO, Release, Train Deployments
LarsWirzenius added a parent task for T266051: Class 'TranslatablePage' not found: T263180: 1.36.0-wmf.14 deployment blockers.
Tue, Oct 20, 5:05 PM · Wikimedia-production-error
LarsWirzenius triaged T266051: Class 'TranslatablePage' not found as Unbreak Now! priority.
Tue, Oct 20, 5:05 PM · Wikimedia-production-error
LarsWirzenius created T266051: Class 'TranslatablePage' not found.
Tue, Oct 20, 5:05 PM · Wikimedia-production-error
LarsWirzenius added a comment to T263180: 1.36.0-wmf.14 deployment blockers.

Reported T266021: PHP Fatal Error: Uncaught Error: Call to a member function getDescription() on null, but not a blocker yet.

Tue, Oct 20, 2:15 PM · Release-Engineering-Team-TODO, Release, Train Deployments
LarsWirzenius created T266021: PHP Fatal Error: Uncaught Error: Call to a member function getDescription() on null.
Tue, Oct 20, 2:15 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), MediaWiki-skins-WikimediaApiPortal, User-DannyS712, API-Portal, Wikimedia-production-error
LarsWirzenius added a comment to T265994: PHP Warning: mb_stripos(): Empty delimiter.

It's excellent if it's not visible to users, but as train conductor, it makes my work harder if there's a lot of logspam that could be avoid. Thank you for fixing this.

Tue, Oct 20, 12:33 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), AbuseFilter, Wikimedia-production-error
LarsWirzenius triaged T265994: PHP Warning: mb_stripos(): Empty delimiter as Unbreak Now! priority.

There's now over 2000 of these in the past four hours. Not blocking the train yet, but raising priority to UBN.

Tue, Oct 20, 11:51 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), AbuseFilter, Wikimedia-production-error
LarsWirzenius added a comment to T263180: 1.36.0-wmf.14 deployment blockers.

Filed T265994: PHP Warning: mb_stripos(): Empty delimiter before starting train.

Tue, Oct 20, 11:33 AM · Release-Engineering-Team-TODO, Release, Train Deployments
LarsWirzenius claimed T263180: 1.36.0-wmf.14 deployment blockers.

I'm taking over as backup train conductor.

Tue, Oct 20, 11:32 AM · Release-Engineering-Team-TODO, Release, Train Deployments
LarsWirzenius updated the task description for T265994: PHP Warning: mb_stripos(): Empty delimiter.
Tue, Oct 20, 11:32 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), AbuseFilter, Wikimedia-production-error
LarsWirzenius created T265994: PHP Warning: mb_stripos(): Empty delimiter.
Tue, Oct 20, 11:31 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), AbuseFilter, Wikimedia-production-error

Mon, Oct 19

LarsWirzenius updated subscribers of T265501: Make a way to build Scap .deb in Docker.
Mon, Oct 19, 9:42 AM · serviceops, Operations, Scap, Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2))
LarsWirzenius updated subscribers of T265501: Make a way to build Scap .deb in Docker.
Mon, Oct 19, 9:41 AM · serviceops, Operations, Scap, Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2))
LarsWirzenius updated subscribers of T265501: Make a way to build Scap .deb in Docker.
Mon, Oct 19, 9:41 AM · serviceops, Operations, Scap, Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2))
LarsWirzenius added a comment to T265501: Make a way to build Scap .deb in Docker.

I have a protype in Gerrit: https://gerrit.wikimedia.org/r/c/mediawiki/tools/scap/+/634929 (WIP; not to be merged yet).

Mon, Oct 19, 9:40 AM · serviceops, Operations, Scap, Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2))
LarsWirzenius updated the task description for T265501: Make a way to build Scap .deb in Docker.
Mon, Oct 19, 9:36 AM · serviceops, Operations, Scap, Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2))
LarsWirzenius triaged T265501: Make a way to build Scap .deb in Docker as High priority.
Mon, Oct 19, 9:33 AM · serviceops, Operations, Scap, Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2))
LarsWirzenius triaged T265502: Make a way to test Scap in train-dev as High priority.
Mon, Oct 19, 9:32 AM · MediaWiki Train Development Environment, Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2))
LarsWirzenius added a comment to T86969: Send scap log directly to logstash via syslog input.

ASAP, I'm sorting out things so I can start process soon.

Mon, Oct 19, 9:25 AM · User-fgiunchedi, Patch-For-Review, Scap

Wed, Oct 14

LarsWirzenius moved T265502: Make a way to test Scap in train-dev from INBOX to New Work on the Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)) board.
Wed, Oct 14, 4:45 PM · MediaWiki Train Development Environment, Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2))
LarsWirzenius created T265502: Make a way to test Scap in train-dev.
Wed, Oct 14, 4:45 PM · MediaWiki Train Development Environment, Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2))
LarsWirzenius moved T265501: Make a way to build Scap .deb in Docker from INBOX to Maintenance on the Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)) board.
Wed, Oct 14, 4:45 PM · serviceops, Operations, Scap, Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2))
LarsWirzenius created T265501: Make a way to build Scap .deb in Docker.
Wed, Oct 14, 4:45 PM · serviceops, Operations, Scap, Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2))

Tue, Oct 13

mmodell awarded T248490: Move scap plugins from mediawiki-config repo to scap repo a Love token.
Tue, Oct 13, 3:56 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), Wikimedia-Site-requests, Scap

Wed, Oct 7

LarsWirzenius moved T234543: Learn Go from INBOX to Learning/Teaching/Blogging/Reading on the Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)) board.
Wed, Oct 7, 2:27 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2))
LarsWirzenius moved T246025: Port scap to Python 3.4 from INBOX to New Work on the Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)) board.
Wed, Oct 7, 2:26 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), EngProd-Virtual-Hackathon, Python3-Porting, Scap
LarsWirzenius moved T248490: Move scap plugins from mediawiki-config repo to scap repo from INBOX to Maintenance on the Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)) board.
Wed, Oct 7, 2:26 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), Wikimedia-Site-requests, Scap
LarsWirzenius moved T255695: Create a development & testing environment for scap + train deployments from INBOX to New Work on the Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)) board.
Wed, Oct 7, 2:26 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), MediaWiki Train Development Environment, Release-Engineering-Team (Deployment services), User-brennen, Scap, Developer Productivity, Train Deployments

Mon, Oct 5

LarsWirzenius edited projects for T234543: Learn Go, added: Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)); removed Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)).
Mon, Oct 5, 1:43 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2))
LarsWirzenius edited projects for T255695: Create a development & testing environment for scap + train deployments, added: Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)); removed Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)).
Mon, Oct 5, 1:42 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), MediaWiki Train Development Environment, Release-Engineering-Team (Deployment services), User-brennen, Scap, Developer Productivity, Train Deployments
LarsWirzenius edited projects for T246025: Port scap to Python 3.4, added: Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)); removed Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)).
Mon, Oct 5, 1:42 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), EngProd-Virtual-Hackathon, Python3-Porting, Scap
LarsWirzenius edited projects for T248490: Move scap plugins from mediawiki-config repo to scap repo, added: Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)); removed Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)).
Mon, Oct 5, 1:42 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), Wikimedia-Site-requests, Scap

Thu, Oct 1

LarsWirzenius added a comment to T248490: Move scap plugins from mediawiki-config repo to scap repo.

~~~sh
liw@deploy1001:~$ scap version
3.15.0-1
liw@deploy1001:~$ dpkg -L scap | grep wikiversions
/usr/lib/python2.7/dist-packages/scap/plugins/updatewikiversions.py
liw@deploy1001:~$
~~~

Thu, Oct 1, 11:53 AM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), Wikimedia-Site-requests, Scap

Wed, Sep 30

LarsWirzenius closed T250302: Rename `scap sync` to `scap sync-world` as Resolved.

This has been deployed for a while now, so closing the ticket. Please reopen if you find anywhere that needs to be fixed.

Wed, Sep 30, 4:45 PM · Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Sustainability (Incident Followup), Patch-For-Review, EngProd-Virtual-Hackathon, Scap
LarsWirzenius created E1268: Out of office.
Wed, Sep 30, 4:26 PM · events
LarsWirzenius created E1267: Out of office.
Wed, Sep 30, 4:26 PM · events
LarsWirzenius created E1266: Out of office.
Wed, Sep 30, 4:25 PM · events
LarsWirzenius created E1265: Out of office.
Wed, Sep 30, 4:24 PM · events

Sep 21 2020

LarsWirzenius added a comment to T259586: Add CI to mediawiki/tools/train-dev.

I would prefer we NOT add CI for train-dev until we're ready. At the moment building train-dev will download some big files from my personal server, and if CI starts doing that, it's going to cost me too much. We'll want to move those files onto suitable WMF servers.

Sep 21 2020, 11:32 AM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), Patch-For-Review, Release-Engineering-Team (CI & Testing services), Continuous-Integration-Config, MediaWiki Train Development Environment
LarsWirzenius lowered the priority of T254000: Add tests for Scap cdb generation from High to Medium.

Lowering priority as things aren't currently broken.

Sep 21 2020, 10:59 AM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), Scap
LarsWirzenius added a comment to T214431: Pipeline: provide a way to rebuild all blubber images.

Meta comment: I have no strong opinion on this, but I note that this task was opened in 2019, and is still untriaged. It would be good to, at least, decide if this is urgent or not.

Sep 21 2020, 10:55 AM · Release-Engineering-Team (Pipeline), serviceops-radar, Release-Engineering-Team-TODO, Release Pipeline
LarsWirzenius added a comment to T260401: Avoid unfinished train deploys over holidays, weekends, or other stretches of no-deploy days.

Having pondered this during last week, when I was the train conductor, I have no strong opinions for or against.

Sep 21 2020, 10:52 AM · User-brennen, Release-Engineering-Team (Deployment services), Sustainability (Incident Followup), Release-Engineering-Team-TODO, Deployments

Sep 17 2020

LarsWirzenius reassigned T257977: 1.36.0-wmf.9 deployment blockers from LarsWirzenius to brennen.

@brennen is taking over for the rest of Thursday. Thanks.

Sep 17 2020, 4:33 PM · Patch-For-Review, User-brennen, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
LarsWirzenius added a comment to T257977: 1.36.0-wmf.9 deployment blockers.

Filed T263132: Could not enqueue jobs from stream mediawiki.job.cirrusSearchIncomingLinkCount but not rolling back train yet, as it seemed to be a short spike.

Sep 17 2020, 1:41 PM · Patch-For-Review, User-brennen, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
LarsWirzenius triaged T263132: Could not enqueue jobs from stream mediawiki.job.cirrusSearchIncomingLinkCount as Unbreak Now! priority.
Sep 17 2020, 1:40 PM · Analytics-Kanban, Operations, Analytics, Event-Platform, Wikimedia-production-error
LarsWirzenius created T263132: Could not enqueue jobs from stream mediawiki.job.cirrusSearchIncomingLinkCount.
Sep 17 2020, 1:40 PM · Analytics-Kanban, Operations, Analytics, Event-Platform, Wikimedia-production-error
LarsWirzenius added a comment to T257977: 1.36.0-wmf.9 deployment blockers.

Promoted to group2 about 15 minutes ago. Filed T263128: ResponseException from line 56 of extensions/GeoData/includes/Searcher.php: but not yet as a blocker.

Sep 17 2020, 1:25 PM · Patch-For-Review, User-brennen, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
LarsWirzenius triaged T263128: ResponseException from line 56 of extensions/GeoData/includes/Searcher.php: as Unbreak Now! priority.
Sep 17 2020, 1:25 PM · Patch-For-Review, Discovery-Search, Search-Platform-Programs, Elasticsearch, Wikimedia-production-error
LarsWirzenius created T263128: ResponseException from line 56 of extensions/GeoData/includes/Searcher.php:.
Sep 17 2020, 1:24 PM · Patch-For-Review, Discovery-Search, Search-Platform-Programs, Elasticsearch, Wikimedia-production-error

Sep 16 2020

LarsWirzenius reassigned T257977: 1.36.0-wmf.9 deployment blockers from LarsWirzenius to brennen.

Over to you, with thanks.

Sep 16 2020, 6:54 PM · Patch-For-Review, User-brennen, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
LarsWirzenius closed T261394: train-dev has no "definition of done" as Resolved.

a DONE.md has been merged now.

Sep 16 2020, 4:43 PM · Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), MediaWiki Train Development Environment
LarsWirzenius lowered the priority of T250302: Rename `scap sync` to `scap sync-world` from Medium to Low.
Sep 16 2020, 4:42 PM · Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Sustainability (Incident Followup), Patch-For-Review, EngProd-Virtual-Hackathon, Scap
LarsWirzenius added a comment to T250302: Rename `scap sync` to `scap sync-world`.

All known cases fixed, but leaving task open in case more are found.

Sep 16 2020, 4:25 PM · Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Sustainability (Incident Followup), Patch-For-Review, EngProd-Virtual-Hackathon, Scap
LarsWirzenius updated the task description for T250302: Rename `scap sync` to `scap sync-world`.
Sep 16 2020, 4:25 PM · Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Sustainability (Incident Followup), Patch-For-Review, EngProd-Virtual-Hackathon, Scap
LarsWirzenius added a comment to T257977: 1.36.0-wmf.9 deployment blockers.

Train promoted to group1.

Sep 16 2020, 1:14 PM · Patch-For-Review, User-brennen, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
LarsWirzenius added a comment to T257977: 1.36.0-wmf.9 deployment blockers.

Reported T263020: Use of Skin::aboutLink was deprecated in MediaWiki 1.36. [Called from NostalgiaTemplate::afterContent] but not as a train blocker: only happens on nostalgiawiki.

Sep 16 2020, 11:40 AM · Patch-For-Review, User-brennen, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
LarsWirzenius created T263020: Use of Skin::aboutLink was deprecated in MediaWiki 1.36. [Called from NostalgiaTemplate::afterContent].
Sep 16 2020, 11:39 AM · Nostalgia, Wikimedia-production-error
LarsWirzenius lowered the priority of T263014: Argument 2 passed to File::userCan() must be an instance of User, null given, called in /srv/mediawiki/php-1.36.0-wmf.9/includes/filerepo/LocalRepo.php on line 275 from Unbreak Now! to Needs Triage.

lowering urgency and removing as train blocker after @Jdforrester-WMF backported revert fix for train. This still needs fixing in parsoid properly, though.

Sep 16 2020, 10:52 AM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), User-DannyS712, Patch-For-Review, Commons, MediaWiki-File-management, Wikimedia-production-error
LarsWirzenius removed a subtask for T257977: 1.36.0-wmf.9 deployment blockers: T263014: Argument 2 passed to File::userCan() must be an instance of User, null given, called in /srv/mediawiki/php-1.36.0-wmf.9/includes/filerepo/LocalRepo.php on line 275.
Sep 16 2020, 10:51 AM · Patch-For-Review, User-brennen, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
LarsWirzenius removed a parent task for T263014: Argument 2 passed to File::userCan() must be an instance of User, null given, called in /srv/mediawiki/php-1.36.0-wmf.9/includes/filerepo/LocalRepo.php on line 275: T257977: 1.36.0-wmf.9 deployment blockers.
Sep 16 2020, 10:51 AM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), User-DannyS712, Patch-For-Review, Commons, MediaWiki-File-management, Wikimedia-production-error
LarsWirzenius added a comment to T257977: 1.36.0-wmf.9 deployment blockers.

Made T263014: Argument 2 passed to File::userCan() must be an instance of User, null given, called in /srv/mediawiki/php-1.36.0-wmf.9/includes/filerepo/LocalRepo.php on line 275 a blocker as it happens a lot now.

Sep 16 2020, 10:41 AM · Patch-For-Review, User-brennen, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
LarsWirzenius added a project to T263014: Argument 2 passed to File::userCan() must be an instance of User, null given, called in /srv/mediawiki/php-1.36.0-wmf.9/includes/filerepo/LocalRepo.php on line 275: Parsoid.
Sep 16 2020, 10:40 AM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), User-DannyS712, Patch-For-Review, Commons, MediaWiki-File-management, Wikimedia-production-error
LarsWirzenius triaged T263014: Argument 2 passed to File::userCan() must be an instance of User, null given, called in /srv/mediawiki/php-1.36.0-wmf.9/includes/filerepo/LocalRepo.php on line 275 as Unbreak Now! priority.

Over 700 now, raising urgency.

Sep 16 2020, 10:40 AM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), User-DannyS712, Patch-For-Review, Commons, MediaWiki-File-management, Wikimedia-production-error
LarsWirzenius added a subtask for T257977: 1.36.0-wmf.9 deployment blockers: T263014: Argument 2 passed to File::userCan() must be an instance of User, null given, called in /srv/mediawiki/php-1.36.0-wmf.9/includes/filerepo/LocalRepo.php on line 275.
Sep 16 2020, 10:40 AM · Patch-For-Review, User-brennen, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
LarsWirzenius added a parent task for T263014: Argument 2 passed to File::userCan() must be an instance of User, null given, called in /srv/mediawiki/php-1.36.0-wmf.9/includes/filerepo/LocalRepo.php on line 275: T257977: 1.36.0-wmf.9 deployment blockers.
Sep 16 2020, 10:39 AM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), User-DannyS712, Patch-For-Review, Commons, MediaWiki-File-management, Wikimedia-production-error
LarsWirzenius added a comment to T263014: Argument 2 passed to File::userCan() must be an instance of User, null given, called in /srv/mediawiki/php-1.36.0-wmf.9/includes/filerepo/LocalRepo.php on line 275.

There's more of these, at 66 now.

Sep 16 2020, 10:33 AM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), User-DannyS712, Patch-For-Review, Commons, MediaWiki-File-management, Wikimedia-production-error
LarsWirzenius added a comment to T257977: 1.36.0-wmf.9 deployment blockers.

Reported T263014: Argument 2 passed to File::userCan() must be an instance of User, null given, called in /srv/mediawiki/php-1.36.0-wmf.9/includes/filerepo/LocalRepo.php on line 275 but not making it a train blocker at this rate.

Sep 16 2020, 10:27 AM · Patch-For-Review, User-brennen, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
LarsWirzenius created T263014: Argument 2 passed to File::userCan() must be an instance of User, null given, called in /srv/mediawiki/php-1.36.0-wmf.9/includes/filerepo/LocalRepo.php on line 275.
Sep 16 2020, 10:26 AM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), User-DannyS712, Patch-For-Review, Commons, MediaWiki-File-management, Wikimedia-production-error
LarsWirzenius added a comment to T257977: 1.36.0-wmf.9 deployment blockers.

We are at group0 now.

Sep 16 2020, 10:21 AM · Patch-For-Review, User-brennen, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
LarsWirzenius closed T262900: Rebuilding l10n cache fails for train as Resolved.

I managed to deploy this week's train to testwikis, which rebuilds the l10n cache and failed yesterday. I declare this fixed now.

Sep 16 2020, 10:16 AM · MW-1.35-notes, MW-1.34-notes, Patch-For-Review, MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Platform Team Workboards (Clinic Duty Team), User-brennen, MediaWiki-extensions-Gadgets, Wikimedia-production-error
LarsWirzenius added a comment to T257977: 1.36.0-wmf.9 deployment blockers.

Deployment to testwikis worked. Going for group0 now.

Sep 16 2020, 10:15 AM · Patch-For-Review, User-brennen, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
LarsWirzenius closed T262900: Rebuilding l10n cache fails for train, a subtask of T257977: 1.36.0-wmf.9 deployment blockers, as Resolved.
Sep 16 2020, 10:15 AM · Patch-For-Review, User-brennen, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
LarsWirzenius added a comment to T257977: 1.36.0-wmf.9 deployment blockers.

This week's train is powered by Assam, Lapsang souchong, and Creme caramel tea, and the official soundtrack is Scooter's "Mind the gap". Just for the record.

Sep 16 2020, 10:07 AM · Patch-For-Review, User-brennen, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
LarsWirzenius added a comment to T257977: 1.36.0-wmf.9 deployment blockers.

T262900: Rebuilding l10n cache fails for train is supposed to be fixed, though not closed yet. Backported by @hashar. Trying to deploy to testwikis.

Sep 16 2020, 9:31 AM · Patch-For-Review, User-brennen, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments

Sep 15 2020

LarsWirzenius reassigned T257977: 1.36.0-wmf.9 deployment blockers from LarsWirzenius to brennen.

Over to you, Brennen, with my apologies and thanks.

Sep 15 2020, 4:23 PM · Patch-For-Review, User-brennen, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
LarsWirzenius added a comment to T262944: Do not expand large files (like package-lock.json) by default when `Expand All` is clicked.

Is it the size of the file or the size of the diff that's a problem? I'm going to assume the size of the diff, so that a one-line change to a huge file is still OK, but a diff that changes every line in a 1000-line file is not.

Sep 15 2020, 3:38 PM · User-zeljkofilipin, Gerrit
LarsWirzenius created T262939: PHP Notice: Undefined offset: 2.
Sep 15 2020, 2:47 PM · Wikimedia-General-or-Unknown