Page MenuHomePhabricator
Create Task
Maniphest T278347

1.37.0-wmf.3 deployment blockers
Closed, ResolvedPublicRelease
Actions

Details

Backup Train Conductor
jeena
Release Version
1.37.0-wmf.3
Release Date
Apr 26 2021, 12:00 AM

2021 week 17 1.37-wmf.3 Changes wmf/1.37.0-wmf.3

This MediaWiki Train Deployment is scheduled for the week of Monday, April 26th:

Monday April 26thTuesday, April 27thWednesday, April 28thThursday, April 29thFriday
Backports only.Branch wmf.3 and deploy to Group 0 Wikis.Deploy wmf.3 to Group 1 Wikis.Deploy wmf.3 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.3 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.37.0-wmf.2
Next: 1.37.0-wmf.4

Related Objects
Search...

Event Timeline

thcipriani created this task.Mar 24 2021, 3:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 24 2021, 3:46 PM
thcipriani assigned this task to brennen.Mar 26 2021, 6:07 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: • LarsWirzenius.
thcipriani added a project: Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)).
thcipriani moved this task from INBOX to Deployment on the Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)) board.
thcipriani reassigned this task from brennen to • LarsWirzenius.Mar 31 2021, 3:59 PM
thcipriani updated Other Assignee, added: jeena; removed: • LarsWirzenius.
thcipriani added a subscriber: brennen.
Jdforrester-WMF renamed this task from 1.36.0-wmf.41 deployment blockers to 1.37.0-wmf.2 deployment blockers.Apr 6 2021, 8:04 PM
• mmodell changed Release Version from 1.36.0-wmf.41 to 1.37.0-wmf.2.Apr 7 2021, 5:19 PM
Jdforrester-WMF subscribed.Apr 13 2021, 5:17 PM
Urbanecm_WMF added subscribers: Urbanecm_WMF, Tgr.Apr 14 2021, 9:31 AM

Risky Patch! 🚂🔥

thcipriani renamed this task from 1.37.0-wmf.2 deployment blockers to 1.37.0-wmf.3 deployment blockers.Apr 14 2021, 3:47 PM
thcipriani changed Release Version from 1.37.0-wmf.2 to 1.37.0-wmf.3.
thcipriani edited projects, added Release-Engineering-Team (Doing); removed Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)).Apr 20 2021, 4:25 AM
matmarex added a subtask: T281184: PHP Fatal Error: Access level to CentralAuthPrimaryAuthenticationProvider::$userNameUtils must be protected (as in class MediaWiki\Auth\AbstractPasswordPrimaryAuthenticationProvider) or weaker.Apr 26 2021, 5:55 PM
taavi closed subtask T281184: PHP Fatal Error: Access level to CentralAuthPrimaryAuthenticationProvider::$userNameUtils must be protected (as in class MediaWiki\Auth\AbstractPasswordPrimaryAuthenticationProvider) or weaker as Resolved.Apr 26 2021, 8:06 PM
matmarex closed subtask T281180: DiscussionTools: Precondition failed: This Title instance does not represent a proper page, but merely a link target as Resolved.Apr 26 2021, 9:15 PM
Stashbot added a comment.Apr 27 2021, 6:37 AM

Mentioned in SAL (#wikimedia-operations) [2021-04-27T06:37:08Z] <liw> version 1.37.0-wmf.3 was branched at rMW20ab303fd1d8 for T278347

• LarsWirzenius added a comment.Apr 27 2021, 8:33 AM

Filed T281223: MediaWiki\Revision\RevisionAccessException: Failed to load data blob from tt:9375723: Bad data in text row 9375723. Use findBadBlobs.php to remedy.. If this problem persist, use the findBadBlobs maintenance script to investigate the issue and mark bad blobs. but not as a blocker.

• LarsWirzenius added a comment.Apr 27 2021, 8:35 AM

Filed T281224: Property 'type' of non-object (in Kartographer) but not as a blocker.

• LarsWirzenius added a comment.Apr 27 2021, 8:58 AM

Filed T281226: PHP Notice: Only variables should be assigned by reference, making it a blocker.

• LarsWirzenius added a subtask: T281226: PHP Notice: Only variables should be assigned by reference.Apr 27 2021, 8:58 AM
• LarsWirzenius added a comment.Apr 27 2021, 9:27 AM

Filed T281229: InvalidArgumentException: GrowthExperiments\Config\WikiPageConfigWriter::getCurrentWikiConfig failed to load config but not yet as a blocker

Urbanecm_WMF added a comment.Apr 27 2021, 9:28 AM
In T278347#7037339, @LarsWirzenius wrote:

Filed T281229: InvalidArgumentException: GrowthExperiments\Config\WikiPageConfigWriter::getCurrentWikiConfig failed to load config but not yet as a blocker

You're so quick, was just going to fill this :).

Urbanecm_WMF added a comment.Apr 27 2021, 9:44 AM
In T278347#7037339, @LarsWirzenius wrote:

Filed T281229: InvalidArgumentException: GrowthExperiments\Config\WikiPageConfigWriter::getCurrentWikiConfig failed to load config but not yet as a blocker

Note: I deleted MediaWiki:GrowthExperimentsConfig.json from test.wikipedia, which should suppress this error. Once the patch I have for this task will get backported, I'll undo my deletion and make sure the error doesn't happen anymore.

• LarsWirzenius added a comment.Apr 27 2021, 1:01 PM

There's a train blocker, but I'm promoting train to group0 to see how bad things get. I can roll back if need be.

jeena closed subtask T281226: PHP Notice: Only variables should be assigned by reference as Resolved.Apr 27 2021, 8:28 PM
• LarsWirzenius added a comment.Apr 28 2021, 1:11 PM

New blocker {T281361: TypeError: Argument 2 passed to Wikibase\Client\DataAccess\Scribunto\WikibaseLanguageIndependentLuaBindings::trackUsageForSitelink() must be an instance of Wikibase\DataModel\Entity\ItemId, instance of Wikibase\MediaInfo\DataMo}

gerritbot added a comment.Apr 28 2021, 7:10 PM

Change 683419 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[operations/mediawiki-config@master] group1 wikis to 1.37.0-wmf.3 refs T278347

https://gerrit.wikimedia.org/r/683419

gerritbot added a project: Patch-For-Review.Apr 28 2021, 7:10 PM

Change 683419 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.37.0-wmf.3 refs T278347

https://gerrit.wikimedia.org/r/683419

Stashbot added a comment.Apr 28 2021, 7:12 PM

Mentioned in SAL (#wikimedia-operations) [2021-04-28T19:12:33Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.37.0-wmf.3 refs T278347

Stashbot added a comment.Apr 28 2021, 7:13 PM

Mentioned in SAL (#wikimedia-operations) [2021-04-28T19:13:41Z] <jhuneidi@deploy1002> Synchronized php: group1 wikis to 1.37.0-wmf.3 refs T278347 (duration: 01m 07s)

jeena added a subtask: T281405: Wikimedia\Rdbms\DBQueryError: Error 1054: Unknown column 'img_actor' .Apr 28 2021, 7:45 PM
tstarling closed subtask T281405: Wikimedia\Rdbms\DBQueryError: Error 1054: Unknown column 'img_actor' as Resolved.Apr 29 2021, 12:43 AM
Jakob_WMDE closed subtask T281361: TypeError: Argument 2 passed to Wikibase\Client\DataAccess\Scribunto\WikibaseLanguageIndependentLuaBindings::trackUsageForSitelink() must be an instance of Wikibase\DataModel\Entity\ItemId, instance of Wikibase\MediaInfo\DataMo as Resolved.Apr 29 2021, 7:44 AM
• LarsWirzenius added a comment.Apr 29 2021, 9:44 AM

Filed T281455: PHP Notice: Undefined variable: endTags, but not as a blocker due only happening once.

• LarsWirzenius added a comment.Apr 29 2021, 9:46 AM

Filed T281456: PHP Warning: Invalid argument supplied for foreach(), but not as a train blocker yet.

• LarsWirzenius removed a subtask: T281451: Wikimedia\Rdbms\DBTransactionError: Transaction round stage must be 'cursory' (not 'within-rollback-callbacks').Apr 29 2021, 12:01 PM
• LarsWirzenius added a comment.Apr 29 2021, 1:08 PM

Promoted train to group1.

• LarsWirzenius added a comment.Apr 29 2021, 1:41 PM

Filed T281480: SqlBlobStore no longer caching blobs (DBConnectionError Too many connections), but not as a blocker.

• LarsWirzenius removed a subtask: T281480: SqlBlobStore no longer caching blobs (DBConnectionError Too many connections).Apr 29 2021, 1:44 PM

Filed T281482: PHP Warning: A non-numeric value encountered (from TMH ID3Handler), but not as a blocker.

• LarsWirzenius added a subtask: T281480: SqlBlobStore no longer caching blobs (DBConnectionError Too many connections).Apr 29 2021, 3:51 PM
• LarsWirzenius added a comment.Apr 29 2021, 4:42 PM

Rolled back to group0 due to T281480: SqlBlobStore no longer caching blobs (DBConnectionError Too many connections)

gerritbot added a comment.Apr 29 2021, 7:43 PM

Change 683710 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[operations/mediawiki-config@master] group1 wikis to 1.37.0-wmf.3 refs T278347

https://gerrit.wikimedia.org/r/683710

gerritbot added a comment.Apr 29 2021, 7:44 PM

Change 683710 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.37.0-wmf.3 refs T278347

https://gerrit.wikimedia.org/r/683710

Stashbot added a comment.Apr 29 2021, 7:45 PM

Mentioned in SAL (#wikimedia-operations) [2021-04-29T19:45:24Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.37.0-wmf.3 refs T278347

Stashbot added a comment.Apr 29 2021, 7:46 PM

Mentioned in SAL (#wikimedia-operations) [2021-04-29T19:46:32Z] <jhuneidi@deploy1002> Synchronized php: group1 wikis to 1.37.0-wmf.3 refs T278347 (duration: 01m 08s)

gerritbot added a comment.Apr 29 2021, 7:57 PM

Change 683714 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[operations/mediawiki-config@master] all wikis to 1.37.0-wmf.3 refs T278347

https://gerrit.wikimedia.org/r/683714

gerritbot added a comment.Apr 29 2021, 7:59 PM

Change 683714 merged by jenkins-bot:

[operations/mediawiki-config@master] all wikis to 1.37.0-wmf.3 refs T278347

https://gerrit.wikimedia.org/r/683714

Stashbot added a comment.Apr 29 2021, 8:00 PM

Mentioned in SAL (#wikimedia-operations) [2021-04-29T20:00:19Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: all wikis to 1.37.0-wmf.3 refs T278347

• LarsWirzenius closed this task as Resolved.Apr 30 2021, 2:05 PM

Train seems to have been OK since yesterady, closing task.

Krinkle closed subtask T281480: SqlBlobStore no longer caching blobs (DBConnectionError Too many connections) as Resolved.May 3 2021, 3:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL