PHP Notice: Undefined variable: endTags
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	• LarsWirzenius
	Apr 29 2021, 9:43 AM

Description

Error

mwversion: 1.37.0-wmf.1
reqId: 2b8accf3-45a0-4d6b-a3da-b6efda1ac9ae
Find reqId in Logstash
Find normalized_message in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Notice: Undefined variable: endTags

exception.trace

from /srv/mediawiki/php-1.37.0-wmf.1/extensions/MassMessage/includes/SpecialMassMessage.php(269)
#0 /srv/mediawiki/php-1.37.0-wmf.1/extensions/MassMessage/includes/SpecialMassMessage.php(269): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.37.0-wmf.1/extensions/MassMessage/includes/SpecialMassMessage.php(388): MediaWiki\MassMessage\SpecialMassMessage->getUnclosedTags(string)
#2 /srv/mediawiki/php-1.37.0-wmf.1/extensions/MassMessage/includes/SpecialMassMessage.php(246): MediaWiki\MassMessage\SpecialMassMessage->preview(array)
#3 /srv/mediawiki/php-1.37.0-wmf.1/includes/htmlform/HTMLForm.php(715): MediaWiki\MassMessage\SpecialMassMessage->callback(array, HTMLForm)
#4 /srv/mediawiki/php-1.37.0-wmf.1/includes/htmlform/HTMLForm.php(605): HTMLForm->trySubmit()
#5 /srv/mediawiki/php-1.37.0-wmf.1/extensions/MassMessage/includes/SpecialMassMessage.php(93): HTMLForm->tryAuthorizedSubmit()
#6 /srv/mediawiki/php-1.37.0-wmf.1/includes/specialpage/SpecialPage.php(646): MediaWiki\MassMessage\SpecialMassMessage->execute(NULL)
#7 /srv/mediawiki/php-1.37.0-wmf.1/includes/specialpage/SpecialPageFactory.php(1381): SpecialPage->run(NULL)
#8 /srv/mediawiki/php-1.37.0-wmf.1/includes/MediaWiki.php(313): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#9 /srv/mediawiki/php-1.37.0-wmf.1/includes/MediaWiki.php(916): MediaWiki->performRequest()
#10 /srv/mediawiki/php-1.37.0-wmf.1/includes/MediaWiki.php(550): MediaWiki->main()
#11 /srv/mediawiki/php-1.37.0-wmf.1/index.php(53): MediaWiki->run()
#12 /srv/mediawiki/php-1.37.0-wmf.1/index.php(46): wfIndexMain()
#13 /srv/mediawiki/w/index.php(3): require(string)
#14 {main}

Impact

Low impact. Reporting because this seems like a programming error. Not making it a train blocker, but if it starts happening a lot, it'll need to become one.

Notes

Details

Request URL: https://meta.wikimedia.org/wiki/Special:MassMessage

	Subject	Repo	Branch	Lines +/-
	Fix PHP notice in SpecialMassMessage because of short-circuit	mediawiki/extensions/MassMessage	REL1_36	+4 -8
	Fix PHP notice in SpecialMassMessage because of short-circuit	mediawiki/extensions/MassMessage	master	+4 -8

Customize query in gerrit

Related Objects

Mentioned In: T281524: Analyze why phan does not report a possible undeclared variable on short-circuit code with pass-by-ref variable
T281456: PHP Warning: Invalid argument supplied for foreach()
T278347: 1.37.0-wmf.3 deployment blockers

Event Timeline

• LarsWirzenius created this task.Apr 29 2021, 9:43 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 29 2021, 9:43 AM

• LarsWirzenius mentioned this in T278347: 1.37.0-wmf.3 deployment blockers.Apr 29 2021, 9:44 AM

• LarsWirzenius mentioned this in T281456: PHP Warning: Invalid argument supplied for foreach().Apr 29 2021, 1:08 PM

Regression from https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MassMessage/+/649670

Change 683711 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/MassMessage@master] Fix PHP notice in SpecialMassMessage because of short-circuit

https://gerrit.wikimedia.org/r/683711

gerritbot added a project: Patch-For-Review.Apr 29 2021, 7:48 PM

Umherirrender mentioned this in T281524: Analyze why phan does not report a possible undeclared variable on short-circuit code with pass-by-ref variable.Apr 29 2021, 8:00 PM

Change 683711 merged by jenkins-bot:

[mediawiki/extensions/MassMessage@master] Fix PHP notice in SpecialMassMessage because of short-circuit

https://gerrit.wikimedia.org/r/683711

Maintenance_bot removed a project: Patch-For-Review.Apr 29 2021, 8:10 PM

Change 683632 had a related patch set uploaded (by Umherirrender; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/MassMessage@REL1_36] Fix PHP notice in SpecialMassMessage because of short-circuit

https://gerrit.wikimedia.org/r/683632

gerritbot added a project: Patch-For-Review.Apr 29 2021, 8:26 PM

Could fail on wmf/1.36.0-wmf.38 as well (suggest no backport)

Change 683632 merged by jenkins-bot: