Page MenuHomePhabricator
Create Task
Maniphest T281184

PHP Fatal Error: Access level to CentralAuthPrimaryAuthenticationProvider::$userNameUtils must be protected (as in class MediaWiki\Auth\AbstractPasswordPrimaryAuthenticationProvider) or weaker
Closed, ResolvedPublic
Actions

Description

I got this unrelated error in CI when running the tests for https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/682699:

19:44:16 26 04 2021 17:44:16.179:DEBUG [proxy]: proxying request - /wiki/Special:JavaScriptTest/qunit/export to 127.0.0.1:9412
19:44:16 INFO:backend.PhpWebserver:[Mon Apr 26 17:44:16 2021] PHP Fatal error:  Access level to CentralAuthPrimaryAuthenticationProvider::$userNameUtils must be protected (as in class MediaWiki\Auth\AbstractPasswordPrimaryAuthenticationProvider) or weaker in /workspace/src/extensions/CentralAuth/includes/CentralAuthPrimaryAuthenticationProvider.php on line 0
19:44:16 INFO:backend.PhpWebserver:[Mon Apr 26 17:44:16 2021] 127.0.0.1:44588 [200]: /wiki/Special:JavaScriptTest/qunit/export - Access level to CentralAuthPrimaryAuthenticationProvider::$userNameUtils must be protected (as in class MediaWiki\Auth\AbstractPasswordPrimaryAuthenticationProvider) or weaker in /workspace/src/extensions/CentralAuth/includes/CentralAuthPrimaryAuthenticationProvider.php on line 0

This is preventing us from merging changes (unless we override CI).

Details

SubjectRepoBranchLines +/-
Make CentralAuthPrimaryAuthenticationProvider::$userNameUtils protectedmediawiki/extensions/CentralAuthmaster+5 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Apr 26 2021, 5:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2021, 5:54 PM
matmarex added a comment.Apr 26 2021, 5:54 PM

Seems to be caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/680327.

matmarex added parent tasks: T278347: 1.37.0-wmf.3 deployment blockers, T281180: DiscussionTools: Precondition failed: This Title instance does not represent a proper page, but merely a link target.Apr 26 2021, 5:55 PM
matmarex renamed this task from PHP Fatal Error from /workspace/src/extensions/CentralAuth/includes/CentralAuthPrimaryAuthenticationProvider.php: Access level to CentralAuthPrimaryAuthenticationProvider::$userNameUtils must be protected (as in class MediaWiki\Auth\AbstractPasswordPrimaryAuthenticationProvider) or weaker to PHP Fatal Error: Access level to CentralAuthPrimaryAuthenticationProvider::$userNameUtils must be protected (as in class MediaWiki\Auth\AbstractPasswordPrimaryAuthenticationProvider) or weaker.Apr 26 2021, 5:59 PM
gerritbot added a comment.Apr 26 2021, 6:06 PM

Change 682710 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/CentralAuth@master] Make CentralAuthPrimaryAuthenticationProvider::$userNameUtils protected

https://gerrit.wikimedia.org/r/682710

gerritbot added a project: Patch-For-Review.Apr 26 2021, 6:06 PM
Urbanecm triaged this task as Unbreak Now! priority.Apr 26 2021, 6:06 PM
Urbanecm subscribed.

This is a blocker of a train blocker => UBN.

RhinosF1 subscribed.Apr 26 2021, 6:14 PM
gerritbot added a comment.Apr 26 2021, 7:00 PM

Change 682710 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Make CentralAuthPrimaryAuthenticationProvider::$userNameUtils protected

https://gerrit.wikimedia.org/r/682710

Maintenance_bot removed a project: Patch-For-Review.Apr 26 2021, 7:10 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 26 2021, 8:00 PM
taavi closed this task as Resolved.Apr 26 2021, 8:06 PM
taavi assigned this task to DannyS712.
Restricted Application added a project: User-DannyS712. · View Herald TranscriptApr 26 2021, 8:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL