Page MenuHomePhabricator
Create Task
Maniphest T281224

Property 'type' of non-object (in Kartographer)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Notice: Trying to get property 'type' of non-object
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.1/extensions/Kartographer/includes/SimpleStyleParser.php(204)
#0 /srv/mediawiki/php-1.37.0-wmf.1/extensions/Kartographer/includes/SimpleStyleParser.php(204): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.37.0-wmf.1/extensions/Kartographer/includes/SimpleStyleParser.php(97): Kartographer\SimpleStyleParser->normalize(array)
#2 /srv/mediawiki/php-1.37.0-wmf.1/extensions/JsonConfig/includes/JCMapDataContent.php(49): Kartographer\SimpleStyleParser->normalizeAndSanitize(array)
#3 /srv/mediawiki/php-1.37.0-wmf.1/extensions/JsonConfig/includes/JCDataApi.php(35): JsonConfig\JCMapDataContent->getSafeData(stdClass)
#4 /srv/mediawiki/php-1.37.0-wmf.1/includes/api/ApiMain.php(1652): JsonConfig\JCDataApi->execute()
#5 /srv/mediawiki/php-1.37.0-wmf.1/includes/api/ApiMain.php(622): ApiMain->executeAction()
#6 /srv/mediawiki/php-1.37.0-wmf.1/includes/api/ApiMain.php(593): ApiMain->executeActionWithErrorHandling()
#7 /srv/mediawiki/php-1.37.0-wmf.1/api.php(90): ApiMain->execute()
#8 /srv/mediawiki/php-1.37.0-wmf.1/api.php(45): wfApiMain()
#9 /srv/mediawiki/w/api.php(3): require(string)
#10 {main}
Impact

Low. One instance, only, but this is clearly a programming error.

Notes

Details

Request URL
https://en.wikipedia.org/w/api.php?format=*&formatversion=*&action=jsondata&title=*
SubjectRepoBranchLines +/-
Drop obsolete compatibility with Kartographer's SimpleStyleParsermediawiki/extensions/JsonConfigmaster+2 -16
Fix incomplete SimpleStyleParser::normalize() implementationmediawiki/extensions/Kartographermaster+10 -8
Add temporary compatibility before calling Kartographermediawiki/extensions/JsonConfigmaster+8 -3
Customize query in gerrit

Related Objects

Event Timeline

• LarsWirzenius created this task.Apr 27 2021, 8:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 27 2021, 8:35 AM
• LarsWirzenius mentioned this in T278347: 1.37.0-wmf.3 deployment blockers.Apr 27 2021, 8:35 AM
Krinkle renamed this task from PHP Notice: Trying to get property 'type' of non-object to Property 'type' of non-object (in Kartographer).Apr 28 2021, 6:09 PM
Krinkle added a project: Discovery-Search.Apr 28 2021, 6:52 PM
Krinkle edited projects, added Product-Infrastructure-Team-Backlog-Deprecated; removed Discovery-Search.
Krinkle moved this task from Untriaged to Apr 2021 on the Wikimedia-production-error board.
MSantos triaged this task as Low priority.May 3 2021, 3:13 PM
MSantos moved this task from Needs triage to Backlog on the Product-Infrastructure-Team-Backlog-Deprecated board.
gerritbot added a comment.May 17 2021, 9:07 AM

Change 692260 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/JsonConfig@master] Add temporary compatibility before calling Kartographer

https://gerrit.wikimedia.org/r/692260

gerritbot added a project: Patch-For-Review.May 17 2021, 9:07 AM
gerritbot added a comment.May 17 2021, 9:24 AM

Change 692266 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Fix incomplete SimpleStyleParser::normalize() implementation

https://gerrit.wikimedia.org/r/692266

gerritbot added a comment.May 17 2021, 5:39 PM

Change 692260 merged by jenkins-bot:

[mediawiki/extensions/JsonConfig@master] Add temporary compatibility before calling Kartographer

https://gerrit.wikimedia.org/r/692260

gerritbot added a comment.May 17 2021, 5:57 PM

Change 692266 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Fix incomplete SimpleStyleParser::normalize() implementation

https://gerrit.wikimedia.org/r/692266

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.6; 2021-05-18).May 17 2021, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 17 2021, 6:10 PM
• LarsWirzenius unsubscribed.Jun 15 2021, 5:34 AM
Krinkle closed this task as Resolved.Oct 11 2021, 1:49 AM
Krinkle assigned this task to thiemowmde.
awight merged a task: T304657: Kartographer: PHP Notice: Undefined property: stdClass::$type.Mar 25 2022, 9:21 AM
awight added subscribers: • brennen, awight.
gerritbot added a comment.Jan 3 2024, 4:21 PM

Change 987442 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/JsonConfig@master] Drop obsolete compatibility with Kartographer's SimpleStyleParser

https://gerrit.wikimedia.org/r/987442

gerritbot added a project: Patch-For-Review.Jan 3 2024, 4:21 PM
gerritbot added a comment.Jan 3 2024, 7:44 PM

Change 987442 merged by jenkins-bot:

[mediawiki/extensions/JsonConfig@master] Drop obsolete compatibility with Kartographer's SimpleStyleParser

https://gerrit.wikimedia.org/r/987442

Maintenance_bot removed a project: Patch-For-Review.Jan 3 2024, 8:30 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ).Jan 3 2024, 10:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits