PHP Notice: Only variables should be assigned by reference
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	• LarsWirzenius
	Apr 27 2021, 8:58 AM

Description

Error

mwversion: 1.37.0-wmf.3
reqId: 0e6f33c4-3445-4a18-8493-30083391837d
Find reqId in Logstash
Find normalized_message in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Notice: Only variables should be assigned by reference

exception.trace

from /srv/mediawiki/php-1.37.0-wmf.3/includes/rcfeed/IRCColourfulRCFeedFormatter.php(52)
#0 /srv/mediawiki/php-1.37.0-wmf.3/includes/rcfeed/IRCColourfulRCFeedFormatter.php(52): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.37.0-wmf.3/includes/rcfeed/FormattedRCFeed.php(58): IRCColourfulRCFeedFormatter->getLine(array, RecentChange, NULL)
#2 /srv/mediawiki/php-1.37.0-wmf.3/includes/changes/RecentChange.php(570): FormattedRCFeed->notify(RecentChange, NULL)
#3 /srv/mediawiki/php-1.37.0-wmf.3/includes/changes/RecentChange.php(488): RecentChange->notifyRCFeeds()
#4 /srv/mediawiki/php-1.37.0-wmf.3/includes/changes/RecentChange.php(767): RecentChange->save()
#5 /srv/mediawiki/php-1.37.0-wmf.3/includes/deferred/MWCallableUpdate.php(38): RecentChange::{closure}()
#6 /srv/mediawiki/php-1.37.0-wmf.3/includes/deferred/DeferredUpdates.php(513): MWCallableUpdate->doUpdate()
#7 /srv/mediawiki/php-1.37.0-wmf.3/includes/deferred/DeferredUpdates.php(390): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#8 /srv/mediawiki/php-1.37.0-wmf.3/includes/deferred/DeferredUpdates.php(221): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti, Monolog\Logger, BufferingStatsdDataFactory, string)
#9 /srv/mediawiki/php-1.37.0-wmf.3/includes/deferred/DeferredUpdatesScope.php(267): DeferredUpdates::{closure}(MWCallableUpdate, integer)
#10 /srv/mediawiki/php-1.37.0-wmf.3/includes/deferred/DeferredUpdatesScope.php(196): DeferredUpdatesScope->processStageQueue(integer, integer, Closure)
#11 /srv/mediawiki/php-1.37.0-wmf.3/includes/deferred/DeferredUpdates.php(242): DeferredUpdatesScope->processUpdates(integer, Closure)
#12 /srv/mediawiki/php-1.37.0-wmf.3/includes/MediaWiki.php(1132): DeferredUpdates::doUpdates(string)
#13 /srv/mediawiki/php-1.37.0-wmf.3/includes/MediaWiki.php(837): MediaWiki->restInPeace()
#14 /srv/mediawiki/php-1.37.0-wmf.3/includes/MediaWiki.php(575): MediaWiki->doPostOutputShutdown()
#15 /srv/mediawiki/php-1.37.0-wmf.3/index.php(53): MediaWiki->run()
#16 /srv/mediawiki/php-1.37.0-wmf.3/index.php(46): wfIndexMain()
#17 /srv/mediawiki/w/index.php(3): require(string)
#18 {main}

Impact

Currently has happened four times, and train is only on testwikis. This does not bode well for group0. Marking this as a train blocker.

Notes

Smells like a programming problem to me.

Details

Request URL: https://test.wikipedia.org/w/index.php?title=*&action=submit

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	rcfeed: Remove reference assignment	mediawiki/core	wmf/1.37.0-wmf.3	+1 -1
	rcfeed: Remove reference assignment	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	• LarsWirzenius	T278347 1.37.0-wmf.3 deployment blockers
		Resolved	PRODUCTION ERROR	kostajh	T281226 PHP Notice: Only variables should be assigned by reference

Event Timeline

• LarsWirzenius created this task.Apr 27 2021, 8:58 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 27 2021, 8:58 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• LarsWirzenius triaged this task as Unbreak Now! priority.Apr 27 2021, 8:58 AM

• LarsWirzenius mentioned this in T278347: 1.37.0-wmf.3 deployment blockers.

• LarsWirzenius added a parent task: T278347: 1.37.0-wmf.3 deployment blockers.

Change 682911 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/core@master] rcfeed: Remove reference assignment

https://gerrit.wikimedia.org/r/682911

gerritbot added a project: Patch-For-Review.Apr 27 2021, 9:15 AM

RhinosF1 subscribed.Apr 27 2021, 9:20 AM

kostajh claimed this task.Apr 27 2021, 11:50 AM

kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

kostajh moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 682911 merged by jenkins-bot:

[mediawiki/core@master] rcfeed: Remove reference assignment

https://gerrit.wikimedia.org/r/682911

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).Apr 27 2021, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 27 2021, 2:10 PM

Change 682818 had a related patch set uploaded (by Ahmon Dancy; author: Kosta Harlan):

[mediawiki/core@wmf/1.37.0-wmf.3] rcfeed: Remove reference assignment

https://gerrit.wikimedia.org/r/682818

gerritbot added a project: Patch-For-Review.Apr 27 2021, 2:53 PM

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Apr 27 2021, 5:58 PM

Change 682818 merged by jenkins-bot:

[mediawiki/core@wmf/1.37.0-wmf.3] rcfeed: Remove reference assignment

https://gerrit.wikimedia.org/r/682818

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.3; 2021-04-27); removed MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).Apr 27 2021, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 27 2021, 8:10 PM

Mentioned in SAL (#wikimedia-operations) [2021-04-27T20:11:36Z] <jhuneidi@deploy1002> Synchronized php-1.37.0-wmf.3/includes/rcfeed/IRCColourfulRCFeedFormatter.php: Backport rcfeed: Remove reference assignment (T281226) to 1.37.0-wmf.3 (duration: 01m 12s)

Fix merged and errors have dropped off

Krinkle moved this task from Untriaged to Apr 2021 on the Wikimedia-production-error board.Apr 7 2022, 3:42 PM

PHP Notice: Only variables should be assigned by referenceClosed, ResolvedPublicPRODUCTION ERRORActions