Page MenuHomePhabricator
Create Task
Maniphest T264284

Refactor DatabaseTermIdsCleaner
Closed, ResolvedPublic
Actions

Description

We found this as a TODO for the wb_terms cleanup work, but it’s currently not clear what exactly would need to be refactored. Work in this area was done already with T244115 / I480749aff7.

There may still be some easy areas to tidy up.
Approach could be:

  • Look at and understand the code in question
  • Perform any refactorings that make it clearer and update docs.
  • Mark task as done

Details

SubjectRepoBranchLines +/-
wb_terms: refactor DatabaseUsageCheckingTermStoreCleanermediawiki/extensions/Wikibasemaster+95 -151
Refactor DatabaseInnerTermStoreCleanerTest furthermediawiki/extensions/Wikibasemaster+52 -39
wb_terms: Refactor DatabaseInnerTermStoreCleanerTestmediawiki/extensions/Wikibasemaster+160 -243
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Oct 1 2020, 8:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2020, 8:39 AM
Addshore added a project: Story.Oct 1 2020, 8:40 AM
Lucas_Werkmeister_WMDE renamed this task from Refactor DatabaseTermIdsCleaner to Refactor DatabaseTermIdsCleaner(?).Oct 1 2020, 9:11 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Lucas_Werkmeister_WMDE added a subscriber: Addshore.
Addshore renamed this task from Refactor DatabaseTermIdsCleaner(?) to Refactor DatabaseTermIdsCleaner.Oct 6 2020, 9:15 AM
Addshore updated the task description. (Show Details)
Addshore moved this task from Backlog to To do on the Wikibase wb_terms leftovers 2020 board.
• toan claimed this task.Oct 6 2020, 9:20 AM
• toan moved this task from To do to Doing on the Wikibase wb_terms leftovers 2020 board.Oct 6 2020, 10:01 AM
gerritbot added a comment.Oct 6 2020, 1:02 PM

Change 632481 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] wb_terms: Refactor DatabaseInnerTermStoreCleaner

https://gerrit.wikimedia.org/r/632481

gerritbot added a project: Patch-For-Review.Oct 6 2020, 1:02 PM
gerritbot added a comment.Oct 6 2020, 2:32 PM

Change 632498 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] wb_terms: refactor DatabaseUsageCheckingTermStoreCleaner

https://gerrit.wikimedia.org/r/632498

• toan moved this task from Doing to Peer Review on the Wikibase wb_terms leftovers 2020 board.Oct 7 2020, 8:10 AM
gerritbot added a comment.Oct 7 2020, 2:28 PM

Change 632481 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] wb_terms: Refactor DatabaseInnerTermStoreCleanerTest

https://gerrit.wikimedia.org/r/632481

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.13; 2020-10-12).Oct 7 2020, 3:00 PM
gerritbot added a comment.Oct 8 2020, 10:13 AM

Change 632899 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Refactor DatabaseInnerTermStoreCleanerTest further

https://gerrit.wikimedia.org/r/632899

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Oct 8 2020, 2:58 PM
gerritbot added a comment.Oct 9 2020, 9:15 AM

Change 632899 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Refactor DatabaseInnerTermStoreCleanerTest further

https://gerrit.wikimedia.org/r/632899

gerritbot added a comment.Oct 9 2020, 2:38 PM

Change 632498 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] wb_terms: refactor DatabaseUsageCheckingTermStoreCleaner

https://gerrit.wikimedia.org/r/632498

Lucas_Werkmeister_WMDE moved this task from Peer Review to Verification on the Wikibase wb_terms leftovers 2020 board.Oct 9 2020, 2:57 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 9 2020, 3:10 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Oct 12 2020, 3:58 PM
Lucas_Werkmeister_WMDE moved this task from Verification to Done on the Wikibase wb_terms leftovers 2020 board.

I think we can close this. There’s some remaining more-or-less-duplicated code in DatabaseInnerTermStoreCleaner, where cleanTermInLangIdsInner ≈ cleanTextInLangIds, but I don’t think it would be a good idea to try to extract more code there.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL