| • Lucas_Werkmeister_WMDE | |
| Oct 1 2020, 8:40 AM |
We want to keep the conceptual separation between Item and Property terms, but still find ways to share more of the actual code instead of having it copy+pasted.
Classes include:
Create a new subtask for each pair when picking this story up.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T264285 Reduce code duplication between Item/Property term store classes | |||
| Resolved | • toan | T264882 Refactor PrefetchingItemTermLookup/PrefetchingPropertyTermLookup | |||
| Resolved | • toan | T265026 Reduce code duplication between DatabaseItemTermStoreWriter/DatabasePropertyTermStoreWriter | |||
| Declined | None | T265052 Refactor ItemTermsRebuilder/PropertyTermsRebuilder |
I think this is done – all three subtasks are closed, and I didn’t spot any other candidates for deduplicating in git ls '*Item*.php' ':!*/tests/*'.