Owner-only client missing token in confirmation view
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	apaskulin
	Oct 1 2020, 10:11 PM

Description

Expected behavior

After creating an owner-only client ("Bot account") or after resetting the secret for an owner-only client, the confirmation dialog includes the client ID, client secret, and "Access token"

Observed behavior

Access token is missing from confirmation dialog

Screen Shot 2020-10-01 at 2.49.56 PM.png (804×1 px, 101 KB)

Details

	Subject	Repo	Branch	Lines +/-
	1) Making access token visible 2) Adding colon to Access token label	mediawiki/extensions/WikimediaApiPortalOAuth	master	+3 -3

Customize query in gerrit

Related Objects

Mentioned In: T261702: Acceptance testing for WikimediaApiPortalOAuth and updates to OAuth extension

Event Timeline

apaskulin created this task.Oct 1 2020, 10:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2020, 10:11 PM

apaskulin triaged this task as High priority.Oct 1 2020, 10:12 PM

apaskulin mentioned this in T261702: Acceptance testing for WikimediaApiPortalOAuth and updates to OAuth extension.

The response from the OAuth extension includes the access_token if it's an owner-only consumer, so we'll need to change WikimediaApiPortalOAuth to display that filed in the confirmation dialog when included in the response.

apaskulin updated the task description. (Show Details)Oct 5 2020, 3:21 PM

apaskulin updated the task description. (Show Details)Oct 5 2020, 4:15 PM

apaskulin added a project: Platform Team Workboards (S&F Workboard).Oct 5 2020, 4:17 PM

apaskulin moved this task from Backlog to Current sprint Backlog on the Platform Team Workboards (S&F Workboard) board.

apaskulin added a project: Platform Team Initiatives (API Gateway).Oct 5 2020, 4:22 PM

Helga_sf set the point value for this task to 3.Oct 6 2020, 10:18 AM

Art.tsymbar claimed this task.Oct 12 2020, 5:21 PM

Art.tsymbar moved this task from Current sprint Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.

apaskulin moved this task from Backlog to Validation on the MediaWiki-extensions-WikimediaApiPortalOAuth board.Oct 23 2020, 6:17 PM

Change 636130 had a related patch set uploaded (by Art.tsymbar; owner: arttsymbar):
[mediawiki/extensions/WikimediaApiPortalOAuth@master] 1) Making access token visible 2) Adding colon to Access token label

https://gerrit.wikimedia.org/r/636130

gerritbot added a project: Patch-For-Review.Oct 24 2020, 12:03 PM

Art.tsymbar moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Oct 24 2020, 12:04 PM

Change 636130 merged by jenkins-bot:
[mediawiki/extensions/WikimediaApiPortalOAuth@master] 1) Making access token visible 2) Adding colon to Access token label

https://gerrit.wikimedia.org/r/636130

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 26 2020, 5:00 PM