weblinkchecker imports both config and config2
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Xqt
	Oct 5 2020, 5:48 AM

Description

config2 should be preferable imported due to circular Imports but not both

Details

	Subject	Repo	Branch	Lines +/-
	imported config2 as config and renamed config2 as config	pywikibot/core	master	+4 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Invalid		None	T223529 Pywikibot good first bugs (tracking)
		Resolved		Homeboy_445	T264564 weblinkchecker imports both config and config2

Event Timeline

Xqt created this task.Oct 5 2020, 5:48 AM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptOct 5 2020, 5:48 AM

Xqt triaged this task as Low priority.Oct 5 2020, 5:48 AM

Xqt added a parent task: T223529: Pywikibot good first bugs (tracking).

Hey there, I would like to tackle this task but I need some assistance for the same. So would you help me to get started with solving this?

@Homeboy_445: Sure. If you have any questions, just ask.

So do I have to remove the config import from the weblinkchecker.py?

In T264564#6593717, @Homeboy_445 wrote:

So do I have to remove the config import from the weblinkchecker.py?

Yes but you have to rename their usage. I propose to Import config2 as config and rename the config2 usage to config e.g.

from pywikibot import config2 as config

the replace all occurences of config2 to config

Okay got it! So my task is to import config2 as config and rename config2's usage to config. I'm on it and will let you know as soon as its done!

In T264564#6593761, @Homeboy_445 wrote:

Okay got it! So my task is to import config2 as config and rename config2's usage to config. I'm on it and will let you know as soon as its done!

Yes. Thanks in advance for your contribution.

Change 638097 had a related patch set uploaded (by Homeboy 445; owner: Homeboy 445):
[pywikibot/core@master] imported config2 as config and renamed config2 as config

https://gerrit.wikimedia.org/r/638097

gerritbot added a project: Patch-For-Review.Nov 2 2020, 12:55 PM

Xqt assigned this task to Homeboy_445.Nov 2 2020, 4:30 PM

Change 638097 had a related patch set uploaded (by Homeboy 445; owner: Homeboy 445):
[pywikibot/core@master] imported config2 as config and renamed config2 as config

https://gerrit.wikimedia.org/r/638097

Thanks @Homeboy_445

Change 638097 merged by jenkins-bot:
[pywikibot/core@master] imported config2 as config and renamed config2 as config

https://gerrit.wikimedia.org/r/638097

Homeboy_445 mentioned this in rPWBCf483751691b3: imported config2 as config and renamed config2 as config.Nov 10 2020, 7:49 AM

@Xqt Thank you so very much for bearing with me.