Page MenuHomePhabricator
Create Task
Maniphest T264602

Simplify WikibaseRepo term store writer-related code
Closed, ResolvedPublic
Actions

Description

WikibaseRepo still has some code around dealing with multiple term store writers that’s not needed anymore.

Details

SubjectRepoBranchLines +/-
Remove two unused term store writer classesmediawiki/extensions/Wikibasemaster+0 -195
Remove multiple-term-store logic from WikibaseRepomediawiki/extensions/Wikibasemaster+92 -193
Customize query in gerrit

Event Timeline

Lucas_Werkmeister_WMDE created this task.Oct 5 2020, 11:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2020, 11:42 AM
gerritbot added a comment.Oct 5 2020, 1:40 PM

Change 632225 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove multiple-term-store logic from WikibaseRepo

https://gerrit.wikimedia.org/r/632225

gerritbot added a project: Patch-For-Review.Oct 5 2020, 1:40 PM

Change 632226 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove two unused term store writer classes

https://gerrit.wikimedia.org/r/632226

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikibase wb_terms leftovers 2020 board.Oct 5 2020, 1:40 PM
gerritbot added a comment.Oct 5 2020, 5:42 PM

Change 632225 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove multiple-term-store logic from WikibaseRepo

https://gerrit.wikimedia.org/r/632225

gerritbot added a comment.Oct 5 2020, 5:42 PM

Change 632226 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove two unused term store writer classes

https://gerrit.wikimedia.org/r/632226

Lucas_Werkmeister_WMDE moved this task from Peer Review to Verification on the Wikibase wb_terms leftovers 2020 board.Oct 5 2020, 5:43 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED).Oct 5 2020, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 5 2020, 6:10 PM
Addshore moved this task from Verification to Done on the Wikibase wb_terms leftovers 2020 board.Oct 6 2020, 8:11 AM
Addshore closed this task as Resolved.Oct 6 2020, 8:11 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits