Page MenuHomePhabricator

Factor SocialProfile features of Cosmos into an extension
Open, LowestPublic

Description

Eventually I want to factor all SocialProfile integration features into an extension in order to clean up the codebase a bit. But this is of the lowest priority at the moment.

Event Timeline

Universal_Omega renamed this task from Factor SocialProfile features into an extension to Factor SocialProfile features of Cosmos into an extension.Oct 8 2020, 5:30 PM
Universal_Omega triaged this task as Lowest priority.
Universal_Omega created this task.

All methods under CosmosSocialProfile had an undeclared visibility, and is fixed in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Cosmos/+/633317.

CosmosProfile repository was created by Chris on October 9th (2 days ago) in https://www.mediawiki.org/w/index.php?diff=4161443

Most if not all code that is reliant or related to SocialProfile is listed below. This is sort of blocked on T264907 (this task would be easier to resolve if T264907 was resolved first)

  • CosmosSocialProfile class
  • ResourceLoader modules: skins.cosmos.profileavatar, skins.cosmos.profiletabs, skins.cosmos.socialprofile, skins.cosmos.profileeditcount, skins.cosmos.profiletags, skins.cosmos.profilebio
includes/Config.php
 		'modern-tabs' => 'wgCosmosSocialProfileModernTabs',
		'round-avatar' => 'wgCosmosSocialProfileRoundAvatar',
		'show-editcount' => 'wgCosmosSocialProfileShowEditCount',
		'allow-bio' => 'wgCosmosSocialProfileAllowBio',
		'profile-tags' => 'wgCosmosSocialProfileShowGroupTags',
		'social-avatar' => 'wgCosmosUseSocialProfileAvatar',
includes/CosmosTemplate.php
'<h1 itemprop="name">' . $profileOwner . '</h1>' . ( $config->isEnabled( 'profile-tags' ) ? CosmosSocialProfile::usergroups( $parser, $profileOwner ) : '' ) . ( $config->isEnabled( 'show-editcount' ) ? '<br/> <div class="contributions-details tally"><a href="' . htmlspecialchars( Title::newFromText( "Contributions/$profileOwner", NS_SPECIAL )->getFullURL() ) . '"><em>' . CosmosSocialProfile::useredits( $parser, $profileOwner ) . '</em><span>Edits since joining this wiki<br>' . CosmosSocialProfile::userregistration( $parser, $profileOwner ) . '</span></a></div>' : '' ) . ( $config->isEnabled( 'allow-bio' ) ? CosmosSocialProfile::userbio( $parser, $profileOwner ) : '' ) ,

Change 633582 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] Technical debt cleanup: Remove unused parameters from methods

https://gerrit.wikimedia.org/r/633582

Change 633582 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] Technical debt cleanup: Remove unused parameters from methods

https://gerrit.wikimedia.org/r/633582