Eventually I want to factor all SocialProfile integration features into an extension in order to clean up the codebase a bit. But this is of the lowest priority at the moment.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Technical debt cleanup: Remove unused parameters from methods | mediawiki/skins/Cosmos | master | +40 -76 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | Universal_Omega | T265063 Factor SocialProfile features of Cosmos into an extension | |||
| Resolved | Universal_Omega | T264907 Convert Cosmos to use ConfigRegistry |
Event Timeline
Comment Actions
All methods under CosmosSocialProfile had an undeclared visibility, and is fixed in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Cosmos/+/633317.
Comment Actions
CosmosProfile repository was created by Chris on October 9th (2 days ago) in https://www.mediawiki.org/w/index.php?diff=4161443
Most if not all code that is reliant or related to SocialProfile is listed below. This is sort of blocked on T264907 (this task would be easier to resolve if T264907 was resolved first)
- CosmosSocialProfile class
- ResourceLoader modules: skins.cosmos.profileavatar, skins.cosmos.profiletabs, skins.cosmos.socialprofile, skins.cosmos.profileeditcount, skins.cosmos.profiletags, skins.cosmos.profilebio
includes/Config.php
'modern-tabs' => 'wgCosmosSocialProfileModernTabs', 'round-avatar' => 'wgCosmosSocialProfileRoundAvatar', 'show-editcount' => 'wgCosmosSocialProfileShowEditCount', 'allow-bio' => 'wgCosmosSocialProfileAllowBio', 'profile-tags' => 'wgCosmosSocialProfileShowGroupTags', 'social-avatar' => 'wgCosmosUseSocialProfileAvatar',
includes/CosmosTemplate.php
'<h1 itemprop="name">' . $profileOwner . '</h1>' . ( $config->isEnabled( 'profile-tags' ) ? CosmosSocialProfile::usergroups( $parser, $profileOwner ) : '' ) . ( $config->isEnabled( 'show-editcount' ) ? '<br/> <div class="contributions-details tally"><a href="' . htmlspecialchars( Title::newFromText( "Contributions/$profileOwner", NS_SPECIAL )->getFullURL() ) . '"><em>' . CosmosSocialProfile::useredits( $parser, $profileOwner ) . '</em><span>Edits since joining this wiki<br>' . CosmosSocialProfile::userregistration( $parser, $profileOwner ) . '</span></a></div>' : '' ) . ( $config->isEnabled( 'allow-bio' ) ? CosmosSocialProfile::userbio( $parser, $profileOwner ) : '' ) ,
Comment Actions
Change 633582 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] Technical debt cleanup: Remove unused parameters from methods
Comment Actions
Change 633582 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] Technical debt cleanup: Remove unused parameters from methods