Page MenuHomePhabricator
Create Task
Maniphest T266499

Optimize ChangeHandler and AffectedPagesFinder
Closed, ResolvedPublic
Actions

Description

This is just a task to collect a few possible optimizations that I noticed while looking through the ChangeHandler/AffectedPagesFinder code for T265897: Create implicit use of description in content language. It doesn’t really have any AC, it can be closed as soon as all the related changes have been merged or abandoned.

Details

SubjectRepoBranchLines +/-
Use TitleFactory more efficientlymediawiki/extensions/Wikibasemaster+44 -32
Use LinkBatch in AffectedPagesFindermediawiki/extensions/Wikibasemaster+49 -19
Remove AffectedPagesFinder::filterUpdates()mediawiki/extensions/Wikibasemaster+3 -30
Use more iterables in AffectedPagesFindermediawiki/extensions/Wikibasemaster+8 -14
Remove pointless LinkBatch in ChangeHandlermediawiki/extensions/Wikibasemaster+0 -3
Abort early if no usages or titles in ChangeHandlermediawiki/extensions/Wikibasemaster+10 -0
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Oct 26 2020, 6:30 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptOct 26 2020, 6:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Oct 26 2020, 6:31 PM

Change 636064 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Use TitleFactory more efficiently

https://gerrit.wikimedia.org/r/636064

gerritbot added a project: Patch-For-Review.Oct 26 2020, 6:31 PM

Change 636473 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Use LinkBatch in AffectedPagesFinder

https://gerrit.wikimedia.org/r/636473

gerritbot added a comment.Oct 26 2020, 6:37 PM

Change 636475 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove AffectedPagesFinder::filterUpdates()

https://gerrit.wikimedia.org/r/636475

gerritbot added a comment.Oct 26 2020, 6:41 PM

Change 636478 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove pointless LinkBatch in ChangeHandler

https://gerrit.wikimedia.org/r/636478

Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 26 2020, 6:41 PM
gerritbot added a comment.Oct 28 2020, 3:50 PM

Change 636970 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] Abort early if no usages or titles in ChangeHandler

https://gerrit.wikimedia.org/r/636970

gerritbot added a comment.Oct 29 2020, 3:12 AM

Change 636970 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Abort early if no usages or titles in ChangeHandler

https://gerrit.wikimedia.org/r/636970

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 29 2020, 4:01 AM
gerritbot added a comment.Oct 29 2020, 2:04 PM

Change 636478 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove pointless LinkBatch in ChangeHandler

https://gerrit.wikimedia.org/r/636478

Lucas_Werkmeister_WMDE added a comment.EditedNov 2 2020, 5:08 PM

Status update: Remove AffectedPagesFinder::filterUpdates() is blocked on open questions that I or someone else need(s) to figure out, but Use TitleFactory more efficiently and Use LinkBatch in AffectedPagesFinder should be ready to merge as far as I’m aware.

Edit: The below change should also be ready, though it’s only partially related (it has little to do with titles and link batches, more with arrays and iterables).

gerritbot added a comment.Nov 2 2020, 6:15 PM

Change 638152 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Use more iterables in AffectedPagesFinder

https://gerrit.wikimedia.org/r/638152

gerritbot added a comment.Nov 4 2020, 11:01 AM

Change 638152 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use more iterables in AffectedPagesFinder

https://gerrit.wikimedia.org/r/638152

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.18; 2020-11-17); removed MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Nov 4 2020, 12:00 PM
gerritbot added a comment.Nov 4 2020, 2:41 PM

Change 636475 abandoned by Lucas Werkmeister (WMDE):
[mediawiki/extensions/Wikibase@master] Remove AffectedPagesFinder::filterUpdates()

Reason:
not worth the effort at this time IMHO

https://gerrit.wikimedia.org/r/636475

gerritbot added a comment.Nov 4 2020, 2:48 PM

Change 636473 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use LinkBatch in AffectedPagesFinder

https://gerrit.wikimedia.org/r/636473

gerritbot added a comment.Nov 4 2020, 4:51 PM

Change 636064 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use TitleFactory more efficiently

https://gerrit.wikimedia.org/r/636064

Lucas_Werkmeister_WMDE closed this task as Resolved.Nov 4 2020, 5:31 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits