Page MenuHomePhabricator
Create Task
Maniphest T266567

libvmod-netmapper: must specify ABI stanza
Closed, ResolvedPublic
Actions

Description

Starting with 6.0.0, VMOD descriptions can specify an ABI stanza. The valid values are either vrt or strict (the default). Strict means that VMODs built against a specific Varnish version will only work on that version, regardless of the ABI compatibility declared with VRT_MAJOR/MINOR . libvmod-netmapper currently does not set $ABI, hence a binary build of the netmapper module against 6.0.6 does not work against 6.0.4:

**** v1    0.1 CLI RX|\tFile name: /usr/lib/x86_64-linux-gnu/varnish/vmods/libvmod_netmapper.so
**** v1    0.1 CLI RX|\tABI mismatch, expected <Varnish 6.0.4 14d4eee6f0afc3020a044341235f54f3bd1449f1>, got <Varnish 6.0.6 29a1a8243dbef3d973aec28dc90403188c1dc8e7>

Details

SubjectRepoBranchLines +/-
Release 1.9-1operations/software/varnish/libvmod-netmapperdebian+6 -0
1.8: add 'ABI vrt' to vmod_netmapper.vccoperations/software/varnish/libvmod-netmappermaster+7 -1
Customize query in gerrit

Related Objects

Event Timeline

• ema created this task.Oct 27 2020, 2:06 PM
Restricted Application added a project: SRE. · View Herald TranscriptOct 27 2020, 2:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• ema triaged this task as Medium priority.Oct 27 2020, 2:06 PM
gerritbot added a comment.Oct 27 2020, 2:26 PM

Change 636666 had a related patch set uploaded (by Ema; owner: Ema):
[operations/software/varnish/libvmod-netmapper@master] 1.8: add 'ABI vrt' to vmod_netmapper.vcc

https://gerrit.wikimedia.org/r/636666

gerritbot added a project: Patch-For-Review.Oct 27 2020, 2:26 PM
gerritbot added a comment.Oct 27 2020, 2:38 PM

Change 636666 merged by Ema:
[operations/software/varnish/libvmod-netmapper@master] 1.8: add 'ABI vrt' to vmod_netmapper.vcc

https://gerrit.wikimedia.org/r/636666

gerritbot added a comment.Oct 27 2020, 2:42 PM

Change 636669 had a related patch set uploaded (by Ema; owner: Ema):
[operations/software/varnish/libvmod-netmapper@debian] Release 1.9-1

https://gerrit.wikimedia.org/r/636669

gerritbot added a comment.Oct 27 2020, 2:49 PM

Change 636669 merged by Ema:
[operations/software/varnish/libvmod-netmapper@debian] Release 1.9-1

https://gerrit.wikimedia.org/r/636669

Stashbot added a comment.Oct 27 2020, 2:55 PM

Mentioned in SAL (#wikimedia-operations) [2020-10-27T14:55:15Z] <ema> upload libvmod-netmapper 1.9-1 to buster-wikimedia component/varnish6 T266567

Maintenance_bot removed a project: Patch-For-Review.Oct 27 2020, 3:10 PM
Stashbot added a comment.Oct 27 2020, 3:13 PM

Mentioned in SAL (#wikimedia-operations) [2020-10-27T15:13:21Z] <ema> cp4032: varnish-frontend-restart with libvmod-netmapper 1.9-1 T266567

• ema closed this task as Resolved.Oct 27 2020, 3:28 PM
• ema claimed this task.

Done in libvmod-netmapper 1.9-1, closing.

• ema mentioned this in T264398: 8-10% response start regression (Varnish 5.1.3-1wm15 -> 6.0.6-1wm1).Oct 27 2020, 3:30 PM
Stashbot added a comment.Oct 28 2020, 10:25 AM

Mentioned in SAL (#wikimedia-operations) [2020-10-28T10:25:00Z] <ema> A:cp (except cp3052, running varnish 5) upgrade libvmod-netmapper to 1.9-1 T266567 T264398

• ema mentioned this in T266651: varnish crash upon reload after libvmod-netmapper upgrade due to liburcu6 assertion.Oct 28 2020, 10:38 AM
Stashbot added a comment.Oct 28 2020, 10:39 AM

Mentioned in SAL (#wikimedia-operations) [2020-10-28T10:39:33Z] <ema> due to T266651, cancel the entry above: A:cp upgrade libvmod-netmapper to 1.9-1 T266567 T264398

Stashbot added a comment.Oct 29 2020, 8:53 AM

Mentioned in SAL (#wikimedia-operations) [2020-10-29T08:53:57Z] <vgutierrez> A:cp (except cp3052, running varnish 5) upgrade libvmod-netmapper to 1.9-1 T266567 T264398

BCornwall added subscribers: Vgutierrez, BCornwall.Jan 9 2023, 6:29 PM

@Vgutierrez, since you were involved with the libvmod-netmapper upgrades, would you say that this 2-year-old issue is fixed?

BCornwall added a comment.Jan 9 2023, 6:30 PM

Ugh, sorry, meant to put that in T266651

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL