randomimage does not output the same characters it reads
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Paladium
	Oct 30 2020, 12:20 PM

Description

Steps to Reproduce:

Open a wiki.
Search wikimedia file page with image caption. For example: https://tuscriaturas.miraheze.org/wiki/Archivo:Lurming_2.png
Put the name of target file inside randomimage code. Example:

<randomimage float="center" choices="Lurming_2.png" />

Watch results.

Actual Results:
The image shows as expected, but the text is not shown properly.

Nuestros misiles encandilarÃ¡n el Sol...

Ã¡ is wrong encoding.

Expected Results:
Current image caption for this image is

"- Nuestros misiles encandilarán el Sol... - ¡Entonces lucharemos al mediodía!"

Encandilarán with á in it.
Is expected that full caption is displayed.

Details

	Subject	Repo	Branch	Lines +/-
	Ensure that we output valid UTF-8 instead of mojibake	mediawiki/extensions/RandomImage	REL1_35	+2 -0
	Ensure that we output valid UTF-8 instead of mojibake	mediawiki/extensions/RandomImage	master	+2 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jakeukalane	T266382 Broken encoding of non-ASCII characters
		Resolved	BUG REPORT	ashley	T266864 randomimage does not output the same characters it reads

Event Timeline

Paladium created this task.Oct 30 2020, 12:20 PM

Restricted Application added a project: User-RhinosF1. · View Herald TranscriptOct 30 2020, 12:20 PM

Restricted Application added subscribers: RhinosF1, Reception123. · View Herald Transcript

In Extension Talk, RandomImage/Archive. In this section:
https://www.mediawiki.org/wiki/Extension_talk:RandomImage/Archive#For_russian_encoding

Someone provides code for solving the encoding in languages with special characters like russian, german, chinese, etc:

public function render() {
		$title = $this->pickImage();
		if( $title instanceof Title && $this->imageExists( $title ) ) {
			return //$this->removeMagnifier( 
				$this->parser->recursiveTagParse(
					base64_decode ($this->buildMarkup( $title ))
				//)
			);
		}
		return '';
	}

	protected function buildMarkup ( $title ) {
		$parts[] = $title->getPrefixedText();
		$parts[] = 'thumb';
		if( $this->width !== false )
			$parts[] = "{$this->width}px";
		if( $this->float )
			$parts[] = $this->float;
		$parts[] = $this->getCaption( $title );
		return ( base64_encode ('[[' . implode( '|', $parts ) . ']]'));
	}

Several people say in the talk page that this code fix their encoding locally. But it seems that after all this years, the encoding in the original source is still incomplete.
How can we solve the encoding of Extension:Randomimage?
If I can help in any way, tell me or send me a message.

Change 640072 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/extensions/RandomImage@master] Ensure that we output valid UTF-8 instead of mojibake

https://gerrit.wikimedia.org/r/640072

gerritbot added a project: Patch-For-Review.Nov 9 2020, 9:21 AM

Change 640072 merged by jenkins-bot:
[mediawiki/extensions/RandomImage@master] Ensure that we output valid UTF-8 instead of mojibake

https://gerrit.wikimedia.org/r/640072

ashley closed this task as Resolved.Jan 9 2021, 5:30 AM

ashley claimed this task.

ashley removed a project: Patch-For-Review.

Maintenance_bot moved this task from Radar to Done on the User-RhinosF1 board.Jan 9 2021, 6:15 AM

Change 655391 had a related patch set uploaded (by RhinosF1; owner: Jack Phoenix):
[mediawiki/extensions/RandomImage@REL1_35] Ensure that we output valid UTF-8 instead of mojibake

https://gerrit.wikimedia.org/r/655391

gerritbot added a project: Patch-For-Review.Jan 11 2021, 6:59 PM

Change 655391 merged by jenkins-bot:
[mediawiki/extensions/RandomImage@REL1_35] Ensure that we output valid UTF-8 instead of mojibake

https://gerrit.wikimedia.org/r/655391

Maintenance_bot removed a project: Patch-For-Review.Jan 11 2021, 7:10 PM