Page MenuHomePhabricator

wowwiki is no longer MediaWiki 1.19
Closed, ResolvedPublic

Description

Some wowwiki sites are no longer MediaWiki 1.19 but 1.33.3

https://wowwiki.fandom.com/api.php?action=query&meta=siteinfo&siprop=general%7Cnamespaces%7Cnamespacealiases%7Cstatistics

This caues tests to fail, e.g.

______________________ TestLogentries.test_BlockEntry_old ______________________

self = <tests.logentries_tests.TestLogentries testMethod=test_BlockEntry_old>

    def wrapped_method(self):
        sitedata = self.sites[key]
        self.site_key = key
        self.family = sitedata['family']
        self.code = sitedata['code']
        self.site = sitedata['site']
>       func(self, key)

tests/aspects.py:674: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests/logentries_tests.py:139: in test_logevent
    self._test_logevent(logtype)
tests/logentries_tests.py:65: in _test_logevent
    logentry = self._get_logentry(logtype)
tests/logentries_tests.py:60: in _get_logentry
    self.assertLess(self.site.mw_version, '1.20')
E   AssertionError: MediaWikiVersion ('1.33.3') not less than '1.20'
------------------------------ Captured log call -------------------------------
VERBOSE  pywiki:logging.py:102 Found 1 wowwiki:en processes running, including this one.
_____________________ TestLogentries.test_DeleteEntry_old ______________________

fandom is updating its platform:

What to do?

  • Update wowiki family file
  • Check other fandom families to be updated
  • Find another "old" family for 1.19 tests
  • Drop support for MediaWiki < 1.23 (1.23 is the next LTS) -> T268979

Event Timeline

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald Transcript

Change 644785 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] use wowwiki:cs for logentries_tests.py

https://gerrit.wikimedia.org/r/644785

Change 644785 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] use wowwiki:cs for logentries_tests.py

https://gerrit.wikimedia.org/r/644785

Change 645531 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] enable "old" logentries tests

https://gerrit.wikimedia.org/r/645531

Change 645531 merged by Xqt:
[pywikibot/core@master] [bugfix] enable "old" logentries tests

https://gerrit.wikimedia.org/r/645531

Xqt lowered the priority of this task from High to Low.Dec 7 2020, 6:27 AM

Decrease prio for the remaining issues

Xqt claimed this task.
Xqt reopened this task as Open.EditedDec 17 2020, 9:43 AM

Reopened because the next wowwiki are merged to MW 1.33,
see https://travis-ci.org/github/wikimedia/pywikibot/jobs/749983319

Change 650094 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Use btrfs family for old tests in logentries_tests.py

https://gerrit.wikimedia.org/r/650094

Xqt raised the priority of this task from Low to High.Dec 17 2020, 10:19 AM

Change 650094 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Use btrfs family for old tests in logentries_tests.py

https://gerrit.wikimedia.org/r/650094