Page MenuHomePhabricator

[live ▶️] 🎬 mobile-de-09 | Add use of funds link to mini banner | ⏰ Dec 10th
Closed, ResolvedPublic

Description

The banners are based on the variant banner of mobile-de-07.

Acceptance Criteria

  • In both banners, the link to the use of funds overlay does not forward to our donation page.
  • A link to the use of funds overlay is added to the mini banner.
  • The spacing above and below the link is set to 12px.
  • Clicking the "Jetzt spenden" button closes the overlay, expands the banner and sets the viewport to the top of the form (without animation).

Mockup

screenshot-de.m.wikipedia.org-2020.12.07-18_10_06.png (309×360 px, 34 KB)

Event Timeline

@kai.nissen I think I need further info..
where should that link in the mini banner be exactly?

Sorry, I meant to add the screenshot to the task description.

@CorinnaHillebrand_WMDE

When clicking the "Jetzt spenden" button in the overlay, the banner expansion should not be animated and the viewport should be set show the "Jetzt sind Sie gefragt" at the top. Please have a look at what happens if you click that button in the control banner. By the way, the variant banner behaves differently when clicking the "Jetzt spenden" button in the use of funds overlay opened from the expanded banner (Abban posted a screencast on Mattermost).

An additional requirement is to also remove the yellow highlighting from the banners (both ctrl and var, both in the slider and the expanded banner).

Oh, and the banners should have the same height. Seems reasonable to add some space to the slider content.

@kai.nissen please have another look if that is now the correct behaviour, the banners are updated on CN. same height part done, too ☑

CorinnaHillebrand_WMDE renamed this task from 🎬 mobile-de-09 | Add use of funds link to mini banner | ⏰ Dec 10th to [live ▶️] 🎬 mobile-de-09 | Add use of funds link to mini banner | ⏰ Dec 10th.Dec 10 2020, 8:57 AM
CorinnaHillebrand_WMDE moved this task from Doing to Code Review on the WMDE-FUN-Funban-2020 board.
kai.nissen claimed this task.