Echo badges too high
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Isarra
	Dec 11 2020, 12:23 AM

Description

Need to unset the top: -5px Echo seems to have by default. As usual.

Details

	Subject	Repo	Branch	Lines +/-
	Make echo badges cooperate and kill a linebreak	mediawiki/skins/GreyStuff	master	+13 -1

Customize query in gerrit

Event Timeline

Isarra created this task.Dec 11 2020, 12:23 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptDec 11 2020, 12:23 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

(Assuming this is about changes in GreyStuff so removing Notifications tag)

Nope, this is just the top: -5px positioning that every skin but vector pretty much has to override back to 0. (Okay, MonoBook did -1px, but it'd be fine at 0.)

Change 648730 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/GreyStuff@master] Make echo badges cooperate and kill a linebreak

https://gerrit.wikimedia.org/r/648730

gerritbot added a project: Patch-For-Review.Dec 12 2020, 9:32 PM

Change 648730 merged by jenkins-bot:
[mediawiki/skins/GreyStuff@master] Make echo badges cooperate and kill a linebreak

https://gerrit.wikimedia.org/r/648730

Okay fixed here.

Maybe next time I'll actually bother to tag all the skins affected that all need the same fix... that might be more useful.

Maintenance_bot removed a project: Patch-For-Review.Dec 12 2020, 10:10 PM

Echo badges too highClosed, ResolvedPublicActions

Description

Details

Event Timeline

Echo badges too high
Closed, ResolvedPublic
Actions