Page MenuHomePhabricator

Perf follow-up: SkinTemplate getFooterLinks performs new non-trivial ActionFactory logic
Closed, ResolvedPublic

Description

Follows-up change 594811 and T251817.

See inline CR at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/594811/20/includes/skins/SkinTemplate.php#380.

Code that was previously feature-flagged to be off in prod was accidentally enabled it seems.

Event Timeline

Change 649459 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Limit credits factory creation to when $wgMaxCredits !== 0

https://gerrit.wikimedia.org/r/649459

Jdlrobson added a subscriber: Jdlrobson.

This is a small mistake in the original patch.

Change 649459 merged by jenkins-bot:
[mediawiki/core@master] Skin: Limit credits factory creation to when $wgMaxCredits !== 0

https://gerrit.wikimedia.org/r/649459

Jdlrobson claimed this task.