Page MenuHomePhabricator
Create Task
Maniphest T270135

Perf follow-up: SkinTemplate getFooterLinks performs new non-trivial ActionFactory logic
Closed, ResolvedPublic
Actions

Description

Follows-up change 594811 and T251817.

See inline CR at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/594811/20/includes/skins/SkinTemplate.php#380.

Code that was previously feature-flagged to be off in prod was accidentally enabled it seems.

Details

SubjectRepoBranchLines +/-
Skin: Limit credits factory creation to when $wgMaxCredits !== 0mediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Dec 14 2020, 10:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 14 2020, 10:11 PM
gerritbot added a comment.Dec 14 2020, 10:17 PM

Change 649459 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Limit credits factory creation to when $wgMaxCredits !== 0

https://gerrit.wikimedia.org/r/649459

gerritbot added a project: Patch-For-Review.Dec 14 2020, 10:17 PM
Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog.Dec 14 2020, 10:38 PM
Jdlrobson subscribed.

This is a small mistake in the original patch.

Krinkle moved this task from Limbo to Perf recommendation on the Performance-Team (Radar) board.Dec 15 2020, 1:32 AM
gerritbot added a comment.Dec 16 2020, 3:50 AM

Change 649459 merged by jenkins-bot:
[mediawiki/core@master] Skin: Limit credits factory creation to when $wgMaxCredits !== 0

https://gerrit.wikimedia.org/r/649459

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Dec 16 2020, 4:00 AM
Maintenance_bot removed a project: Patch-For-Review.Dec 16 2020, 4:10 AM
Jdlrobson moved this task from Needs Analysis to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Dec 16 2020, 4:33 PM
Jdlrobson closed this task as Resolved.Dec 16 2020, 6:05 PM
Jdlrobson claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits