Change some icons position to center (Top-down).
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Gopavasanth
	Dec 17 2020, 5:48 PM

Description

VideoCutTool is a tool to trim, crop, rotate on-the-fly videos in Wikimedia Commons and can be found at https://videocuttool.wmflabs.org/

Task:

Learn about VideoCutTool from Commons: VideoCutTool
Currently, some icons elements are titled a little downwards, So position them at the center (Top-down).

For a quick glance

Code repos:

If you need any help, please feel free to comment here, happy to help you!

Details

	Subject	Repo	Branch	Lines +/-
	Fixed the button-icons alignment.	labs/tools/VideoCutTool	master	+4 -0

Customize query in gerrit

Event Timeline

Gopavasanth created this task.Dec 17 2020, 5:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 17 2020, 5:48 PM

Gopavasanth updated the task description. (Show Details)Dec 17 2020, 5:49 PM

I want to contribute

Hi @Bharatkhatri351, Welcome! Feel free to claim the task and assign it your self by clicking on Add Action-> Assign/Claim and Save.

@Gopavasanth

i cloned the first link given and read Readme file according to it i installed npm

and now opening in my localhost/3000 its not opening please resolve it

please help me how to start the server...

Bharatkhatri351 claimed this task.Dec 19 2020, 10:53 AM

Hi and welcome @Bharatkhatri351. This task's topic is changing icons. Please bring up general development environment questions in more suited places. Thanks a lot! :)

and now opening in my localhost/3000 its not opening please resolve it

Hi @Bharatkhatri351, After installing the required packages and setting up the dev environment, You need to start the server using npm start from your project directory and then go to http://localhost:3000 but not http://localhost/3000

Bharatkhatri351 added a comment.Dec 19 2020, 8:28 PM

This comment was removed by Bharatkhatri351.

i jst change some css file and did this
please tell me is this satisfactory

and please help how can i submit my changes..

@Bharatkhatri351: Please read https://www.mediawiki.org/wiki/New_Developers , plus the task description of this task. Thanks a lot!

I have submitted a patch. Please review

@Bharatkhatri351: Thanks. We don't know where. Please follow https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines

i have sumbitted a Patch again According to instruction please review

Change 651949 had a related patch set uploaded (by Bharatkhatri; owner: Bharatkhatri):
[labs/tools/VideoCutTool@master] Fixed the button-icons alignment.

https://gerrit.wikimedia.org/r/651949

gerritbot added a project: Patch-For-Review.Dec 26 2020, 7:41 AM

Change 651949 merged by jenkins-bot:
[labs/tools/VideoCutTool@master] Fixed the button-icons alignment.

https://gerrit.wikimedia.org/r/651949

Gopavasanth closed this task as Resolved.Dec 26 2020, 7:48 AM

Gopavasanth removed a project: Patch-For-Review.

	F33961988: image.png
	Dec 19 2020, 8:35 PM

	F33961077: image.png
	Dec 19 2020, 10:52 AM

	F33961081: image.png
	Dec 19 2020, 10:52 AM

Change some icons position to center (Top-down). Closed, ResolvedPublicActions

Description

Details

Event Timeline

Change some icons position to center (Top-down).
Closed, ResolvedPublic
Actions