Page MenuHomePhabricator
Create Task
Maniphest T271059

CI for mediawiki/extensions/Translate is not running against the proper version of mediawiki/extensions/UniversalLanguageSelector
Closed, InvalidPublic
Actions

Description

I accidentally discovered this while fixing Translate's REL1_31 tests. It seems that Translate's CI is running against the most recently tagged version of ULS, *not* the version from the correct branch, which is going to be deployed to Wikimedia sites -> therefore unbreak now.

Translate, via composer.json, depends on mediawiki/universal-language-selector: *, which pulls in the most recently tagged ULS version via packagist/composer. This gets installed in the normal extensions/ directory, overwriting the correct version of ULS that quibble cloned from Gerrit.

The straightfoward thing would be to remove the composer dependency, I don't know if that's acceptable to the Translate maintainers. In any case, not testing Translate against the right ULS version isn't acceptable IMO.

Related Objects

Event Timeline

Legoktm triaged this task as Unbreak Now! priority.Jan 3 2021, 7:43 AM
Legoktm created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 3 2021, 7:43 AM
Legoktm added a comment.Jan 3 2021, 7:47 AM

A bandaid might be to depend on dev-master (what TranslationNotifications does), but that won't work for wmf/ branches if patches need to be backported. Also features like Depends-On won't work either.

Nikerabbit subscribed.Jan 3 2021, 7:57 AM

The composer dependency has been long removed in master so it's not going to be deployed to Wikimedia sites (and I don't think it ever was, since composer deps only come via the vendor repo).

Legoktm closed this task as Invalid.Jan 3 2021, 8:01 AM

Uhhh, I feel stupid, I forgot to actually check master. This was fixed in rETRA37d8658932d3: Track ULS dependency in extension.json, a year ago.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits