Page MenuHomePhabricator

MediaWiki Skin: Getting started Failed!
Closed, InvalidPublicBUG REPORT

Description

I developed a skin long time ago (https://www.mediawiki.org/wiki/Skin:MediaWikiBootstrap). Recently Jon Robson (Jdlrobson) contributed and made the skin compatible with the latest stable release MediaWiki 1.35.1. I was planning to update the skin to Bootstrap 5 for a while and few days back started to working on it.

When I started to work I found that the stable version is not stable at all and there are a number of known issue which are being ignored. For example extracting the MediaWiki installer archive file (T271447)!

**The Example skin does not work with the MW1.35.1 nor the Skin form SkinLab (https://skins.wmflabs.org).** I need some help to start building a new skin from scratch. I will also need assistance on some advanced area later but at the beginning I need a ground to stand upon.

This is a contunation the discussion started at the talk page of "Manual talk:How to make a MediaWiki skin" (https://www.mediawiki.org/wiki/Topic:W15bk2m77rjegfmk)

Steps to Reproduce:

Try to follow the steps mentioned at https://www.mediawiki.org/wiki/Manual:How_to_make_a_MediaWiki_skin

  1. Download MW1.35.1 form the site and install it.
  2. Download Example skin from Github and set as default. I downloaded both the master branch (https://github.com/wikimedia/mediawiki-skins-Example) and REL1_35 branch (https://github.com/wikimedia/mediawiki-skins-Example/tree/REL1_35). The results are same.
  3. Found that pages look like broken and the CSS file is missing but I assume there are other issues too.
  4. Try open 2: create a skin from https://skins.wmflabs.org. Then install and enable that.

I installed Mediawiki 1.35.1 by downloading the archive file. Then I downloaded the Example skin from Github. I downloaded both the master branch (https://github.com/wikimedia/mediawiki-skins-Example) and REL1_35 branch (https://github.com/wikimedia/mediawiki-skins-Example/tree/REL1_35). After that I updated the LocalSettings.php and set $wgDefaultSkin = "example"; .

Unfortunately I got a broken page looks like the CSS file is missing but I assume there are other issues too.

Then I tried Option 2. Created a new skin form Skin Lab and enabled that. It did show in a way, but as I do not have and reference I am not sure if It was showing all the parts. But which I found that there are issues in JS because the special:preferences tabs were not working and I could not change the skin from the settings.

Can you please help to start building a new skin from scratch and provide a simple example skin which works! I will also need assistance on some advance area later but at the beginning I need a ground to stand upon.

Actual Results:

Example Skin

  • Pages look like broken and the CSS file is missing but I assume there are other issues too.

Skin Lab

  • It was showing something but right search was placed over top right hamburger menu. So it was not working either.

special:preferences tabs were not working on any of the skin. So I could not change the skin from the settings. But it was working in the Vector skin and I changed to these news skins once and could not return to the Vector again.

I got the following error on the browser console.

Uncaught SyntaxError: missing } after function body load.php:581:33
note: { opened at line 579, column 138 load.php:579:138

Screenshots

I came to know that there are some known bugs in the stable release and T271441 was merged between the time I started facing the issues and now. I updated both includes/resourceloader/ResourceLoaderSkinModule.php and resources/Resources.php files. But the issue was not fixed and looks like same as earlier.

Expected Results:

I expected that the Example Skin and SkinLab skin both will be installed and can be used as a ground to build new skin.

Talk page is great place to start the conversation but tracing the bugs was difficult for me as I was getting responses after long hours and days of posting an updates. I expect a fast response so that I can continue working on it. The assistance I need right now is to get a working version of example skin.

Event Timeline

Hi @Nasirkhan, thanks for reporting this. Wikimedia Phabricator is for bug reports and enhancement requests in Wikimedia code.
It's unfortunately unclear to me what exactly this task is reporting or asking for (maybe several things?).
If the Example skin is broken, then concentrating on that very aspect in a dedicated task would be welcome, by follow https://www.mediawiki.org/wiki/How_to_report_a_bug . When it comes to helping with developing third-party code, this is out of scope for Phabricator itself.
Could you please clarify?
Thanks a lot! :)

Thanks for your quick response.

I wrote a lots of related things here to understand the context but did not asked for several things.

I want a working Example skin and/or example skin form https://skins.wmflabs.org. As Example skin is available under Wikimedia Github account I assume this task is not out of scope. But I do not contribute here regularly and I might be wrong. On that case let me know where should I report that Mediawiki stable release has bugs and a skin does not work as it should be.

Hi, if the Example skin at https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/skins/Example (which is mirrored to GitHub) does not work (either its master branch with MediaWiki core master, or its REL1_35 branch with MediaWiki core's REL1_35 branch), then please follow https://www.mediawiki.org/wiki/How_to_report_a_bug (minimal steps to reproduce, what happens, what you expected instead) and report a bug in phabricator.wikimedia.org under Example (skin) . One bug per task, please, to keep things actionable. :) It's unclear to me in the description above where exactly something fails. Thanks a lot!

Thanks. created two new bugs for example skin.

Thanks a lot, this is helpful! For the records: T271650, T271651.
May I close this ticket as invalid?