Page MenuHomePhabricator

Non-existent user page links display as bluelinks when SocialProfile is enabled
Closed, DeclinedPublic

Description

Bug: For a user that desires to have neither a social profile or a wiki user page, user page links when SocialProfile is installed and enabled on the wiki are blue. This is undesirable. I suppose it's expected wherein a social profile as been toggled as their default user page, but where their wiki user page has been toggled as default, wikilinks should return red. This has forced cumbersome workarounds like this that users can individually add to their common.js file.

I think we should solve this by:
(1) Making the wiki user page the default user page; and by,
(2) Removing the SocialProfile user page header from the wiki user page.

Implementing #2 too should solve the incompatibility issues with GlobalUserPage (see T250033).

Pinging @Naleksuh here as he originally identified this issue to me.

Event Timeline

Restricted Application added a subscriber: RhinosF1. · View Herald Transcript
dmehus updated the task description. (Show Details)

This is undesirable.

No, this is literally an intentional feature (see c115f5acfd61deb464f529821e61d5f291f2de79). The underlying logic is that with SocialProfile installed, a page like [[User:Foo]] is guaranteed to display something; thus red links in NS_USER don't really make much sense, especially if and when they point to a social profile page (which isn't world-editable even on a wiki that is otherwise open to anon contributions etc.).
I did consider a $wg variable toggle for this feature, but decided against it due to the aforementioned reason.

I think we should solve this by:
(1) Making the wiki user page the default user page;

That's literally the default without SocialProfile installed, though, yes? I'm not exactly sure why you'd want to do this, but I'm willing to review a patch which adds a $wg* variable of some kind to toggle this behavior, but it should default to social profiles being the default.

(2) Removing the SocialProfile user page header from the wiki user page.

I don't think this is a good idea for it'd hinder the discoverability of social profiles from wiki user pages and vice-versa. cc'ing @Isarra for design input.

The purpose of differentiated redlinks is to highlight missing pages and invite (other) users to create them and fill them in with information. A missing userpage is up to the user to fill in or not, and whether or not it exists with custom content doesn't affect that any page with content may still be worth visiting for viewing purposes.

While it could be argued that having nonexistant userpages be red action=edit links to other users is undesirable behaviour even without SocialProfile being installed, as typically anyone else visiting the page is going to be there for the associated links, not to create the page for the user, SocialProfile's specific content that displays regardless makes this much less ambiguous in this case.