Normalize button margin across browsers in MW
Closed, ResolvedPublic
Actions

Description

We've started with sensible defaults in T256520, now it's time to extend scope in small steps:
button feature together with other form elements UA margin in Firefox and Safari. This has caused for example T272089: Safari sets ominous margin on search (icon/button) even though user agent styles don't.
It seems reasonable (and relative low risk) to normalize button rendering across browsers.

Details

	Subject	Repo	Branch	Lines +/-
	mediawiki.skinning: Add form elements `margin` normalization to 'normalize.less'	mediawiki/core	master	+9 -0

Customize query in gerrit

Related Objects

Mentioned Here: T256520: Consider 'normalize' stylesheet RL module
T272089: Safari sets ominous margin on search (icon/button) even though user agent styles don't

Event Timeline

Volker_E created this task.Jan 15 2021, 11:29 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 15 2021, 11:29 AM

Change 656387 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] mediawiki.skinning: Add form element margin normalization to 'normalize.less'

https://gerrit.wikimedia.org/r/656387

gerritbot added a project: Patch-For-Review.Jan 15 2021, 11:37 AM

Jdlrobson moved this task from Backlog to Phase 4 - Standardize ResourceLoaderSkinModules styling rules on the MediaWiki-Core-Skin-Architecture board.Jan 15 2021, 11:30 PM

Change 656387 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.skinning: Add form elements margin normalization to 'normalize.less'

https://gerrit.wikimedia.org/r/656387

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Jan 21 2021, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 21 2021, 10:10 PM

Jdlrobson closed this task as Resolved.Jan 21 2021, 11:48 PM

Jdlrobson claimed this task.

Jdlrobson added a project: Web-Team-Backlog (Kanbanana-FY-2020-21).