site_tests.TestAlldeletedrevisionsWithoutUser test methods fail with KeyError
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Xqt
	Jan 22 2021, 2:26 PM

Description

======================================================================
FAIL: test_prefix (tests.site_tests.TestAlldeletedrevisionsWithoutUser)
Test the site.alldeletedrevisions() method with prefix.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/wikimedia/pywikibot/tests/site_tests.py", line 1815, in test_prefix
    self.assertIn(key, drev)
AssertionError: 'parentid' not found in {'user': 'Meco', 'timestamp': '2006-05-12T13:50:22Z', 'revid': 860412}

Details

	Subject	Repo	Branch	Lines +/-
	[tests] parentid not in all alldeletedrevisions responses	pywikibot/core	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned In: T282812: Update Vuex to be able to convert a Z10/List from normal to canonical
rPWBCc46dafed8f1d: [tests] parentid not in all alldeletedrevisions responses
Mentioned Here: T272212: site_tests.TestAlldeletedrevisionsAsUser test methods fail with KeyError

Event Timeline

Xqt created this task.Jan 22 2021, 2:26 PM

Restricted Application added a project: Pywikibot. · View Herald TranscriptJan 22 2021, 2:26 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald Transcript

Xqt renamed this task from ite_tests.TestAlldeletedrevisionsWithoutUser test methods fail with KeyError to site_tests.TestAlldeletedrevisionsWithoutUser test methods fail with KeyError.Jan 22 2021, 2:26 PM

Xqt triaged this task as High priority.

Xqt changed the subtype of this task from "Task" to "Bug Report".

Xqt updated the task description. (Show Details)Jan 22 2021, 2:28 PM

Xqt updated the task description. (Show Details)Jan 22 2021, 3:51 PM

JJMC89 claimed this task.Jan 22 2021, 4:59 PM

Change 657876 had a related patch set uploaded (by JJMC89; owner: JJMC89):
[pywikibot/core@master] [tests] parentid not in all alldeletedrevisions responses

https://gerrit.wikimedia.org/r/657876

gerritbot added a project: Patch-For-Review.Jan 22 2021, 5:02 PM

Change 657876 merged by Xqt:
[pywikibot/core@master] [tests] parentid not in all alldeletedrevisions responses

https://gerrit.wikimedia.org/r/657876

JJMC89 mentioned this in rPWBCc46dafed8f1d: [tests] parentid not in all alldeletedrevisions responses.Jan 22 2021, 5:12 PM

I don't know why some have a parentid and others don't. Here are two deleted edits from enwiki by the same user, one with and one without. Looking at the deleted edits themselves, I don't see why they would be different.

{
    "pageid": 18690151,
    "revisions": [
        {
            "revid": 181205920,
            "minor": "",
            "user": "LordAnubisBOT",
            "timestamp": "2007-12-31T16:17:29Z"
        }
    ],
    "ns": 0,
    "title": "Sheffield Medical School"
},
{
    "pageid": 0,
    "revisions": [
        {
            "revid": 181203877,
            "parentid": 167902014,
            "minor": "",
            "user": "LordAnubisBOT",
            "timestamp": "2007-12-31T16:04:54Z"
        }
    ],
    "ns": 0,
    "title": "George Elcoat"
},

Thanks @JJMC89!

Maintenance_bot removed a project: Patch-For-Review.Jan 22 2021, 6:10 PM

DVrandecic mentioned this in T282812: Update Vuex to be able to convert a Z10/List from normal to canonical.May 13 2021, 6:57 PM

site_tests.TestAlldeletedrevisionsWithoutUser test methods fail with KeyErrorClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

site_tests.TestAlldeletedrevisionsWithoutUser test methods fail with KeyError
Closed, ResolvedPublicBUG REPORT
Actions