Page MenuHomePhabricator

config/index.php does not detect full disk (fwrite result not checked)
Closed, ResolvedPublic

Description

Author: zigger

Description:
config/index.php does not detect a full disk, as the fwrite() result is not checked.


Version: 1.3.x
Severity: normal
URL: http://www.php.net/manual/en/function.fwrite.php

Details

Reference
bz733

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 7:01 PM
bzimport set Reference to bz733.

If you have a full disk, a lot more than this will probably fail...

zigger wrote:

I agree with Brion's comment, which is one of the reasons I marked this as low
priority. But:

  1. this is "probably" the only direct write to the mediawiki folder/directory

tree. Databases and image uploads and /tmp could well be on separate
file-systems (and have related writes that could use error-checking).

  1. it is better to detect and report a full/restricted file-system early and

descriptively. Config is an early and descriptive process.

Probably fixed in cvs. Dieing if fwrite() return false.

zigger wrote:

The fix was first released with v1.4beta1.