Allow for the use of user language for ProtectionForm expiration dropdown
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	BrandonXLF
	Feb 19 2021, 2:08 AM

Description

There is no reason why the ProtectionForm expiration dropdowns should be in the content language since it doesn't change the submitted value. The issue is that items in the dropdown are defined in the message.

This applies to:

Core (ProtectionForm.php)
FlaggedRevs (FlaggedRevsUIHooks.php)
ArticleFeedbackv5 (ArticleFeedbackv5Hooks.php)

Details

	Subject	Repo	Branch	Lines +/-
	Don't use content language for expiration dropdown	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T296717: Expiry options not translated into user's interface language

Event Timeline

BrandonXLF created this task.Feb 19 2021, 2:08 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 19 2021, 2:08 AM

Change 665176 had a related patch set uploaded (by BrandonXLF; owner: BrandonXLF):
[mediawiki/core@master] Don't use content language for expiration dropdown

https://gerrit.wikimedia.org/r/665176

gerritbot added a project: Patch-For-Review.Feb 19 2021, 2:09 AM

BrandonXLF added projects: MediaWiki-extensions-FlaggedRevs, ArticleFeedbackv5.Feb 19 2021, 6:46 PM

BrandonXLF updated the task description. (Show Details)

Wugapodes moved this task from Backlog to Under review on the MediaWiki-extensions-FlaggedRevs board.Mar 16 2021, 9:13 PM

BrandonXLF renamed this task from Use user language for ProtectionForm expiration dropdown to Allow for the use of user language for ProtectionForm expiration dropdown.Mar 23 2021, 2:01 PM

BrandonXLF updated the task description. (Show Details)

Change 665176 abandoned by BrandonXLF:
[mediawiki/core@master] Don't use content language for expiration dropdown

Reason:
Messages can define custom expirations

https://gerrit.wikimedia.org/r/665176

Maintenance_bot removed a project: Patch-For-Review.Mar 23 2021, 2:10 PM

Umherirrender mentioned this in T296717: Expiry options not translated into user's interface language.Nov 30 2021, 4:12 PM

BrandonXLF removed BrandonXLF as the assignee of this task.Jan 30 2023, 6:28 PM