Page MenuHomePhabricator

Closed caption button inserts div at bottom of page instead of in player
Closed, ResolvedPublic

Description

In some situations, clicking on the closed caption button inserts the timedTextMenu_mwe_ogg_player_1 div at the end of the body instead of within the player. I've seen this in both Firefox and Safari. When it occurs in Safari it gives the following error:

ResourceLoader.php:945
TypeError: Result of expression 'subPage.title' [undefined] is not an object.

The relevant code seems to be:
var langKey=subPage.title.split('.');


Version: unspecified
Severity: normal
URL: http://en.wikipedia.org/wiki/L%27Orfeo

Details

Reference
bz25529

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 21 2014, 11:19 PM
bzimport added a project: mwEmbed-Video-player.
bzimport set Reference to bz25529.
kaldari created this task.Oct 15 2010, 12:29 AM

mdale wrote:

Can't recreate but sounds like an error caused by a partially empty api response for a subtitles for a given video title.
At least the error as reported should be fixed in r79155. If you can recreate the error post mwEmbed r180, please re-open this bug