Moving a translatable page makes all translation units no longer outdated
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

Move a translatable page that has at least one outdated translation unit (this happened on MediaWiki.org when I moved https://www.mediawiki.org/wiki/Wikia to https://www.mediawiki.org/wiki/Fandom)

Actual Results:

All previously-outdated translations are no longer marked as outdated. For example, see https://www.mediawiki.org/w/index.php?title=Fandom/ru&diff=prev&oldid=4418282

Expected Results:

Any translation units that were outdated before making the move stay outdated.

Outcome

Information about translation status is no longer lost during a move of a translatable page.

Details

	Subject	Repo	Branch	Lines +/-
	Copy selected revtags for a new revisions with unchanged content	mediawiki/extensions/Translate	master	+78 -13
	Fix metadata handling for translatable page moves and deletions	mediawiki/extensions/Translate	master	+17 -6

Customize query in gerrit

Related Objects

Mentioned Here: T287373: Discouraged translatable page is no longer discouraged after move

Event Timeline

Pppery created this task.Feb 21 2021, 8:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 21 2021, 8:56 PM

Pppery added a project: MediaWiki-extensions-Translate.Feb 21 2021, 8:56 PM

If you look at the subsequent diffs, it's okay: https://www.mediawiki.org/w/index.php?title=Fandom/ru&type=revision&diff=4419350&oldid=4188098&diffmode=source

The issue is that we forgot to add moving & deletion handling of the metadata key that controls this behavior.

Change 666357 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Fix metadata handling for translatable page moves and deletions

https://gerrit.wikimedia.org/r/666357

gerritbot added a project: Patch-For-Review.Feb 23 2021, 1:46 PM

Simple fix, related to on going work.

• Nikerabbit moved this task from Quarter Backlog to In Review on the Language-Team (Language-2021-January-March) board.Feb 23 2021, 1:47 PM

Change 666357 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Fix metadata handling for translatable page moves and deletions

https://gerrit.wikimedia.org/r/666357

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 8 2021, 1:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 8 2021, 1:10 PM

Noted in the code review: the patch above does not fix this problem. Further investigation and changes are needed.

Change 670826 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Move copy selected revtags to the new revision on move

https://gerrit.wikimedia.org/r/670826

gerritbot added a project: Patch-For-Review.Mar 11 2021, 2:20 PM

Pginer-WMF edited projects, added Language-Team (Language-2021-April-June); removed Language-Team (Language-2021-January-March).Apr 1 2021, 11:21 AM

Pginer-WMF moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2021-April-June) board.

Pginer-WMF edited projects, added Language-Team (Language-2021-July-September); removed Language-Team (Language-2021-April-June).Jul 12 2021, 8:18 AM

Pginer-WMF moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2021-July-September) board.

• Nikerabbit moved this task from In Progress to In Review on the Language-Team (Language-2021-July-September) board.Jul 14 2021, 10:55 AM

Change 670826 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Copy selected revtags for a new revisions with unchanged content

https://gerrit.wikimedia.org/r/670826

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.15; 2021-07-19).Jul 19 2021, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 19 2021, 6:10 PM