Page MenuHomePhabricator
Create Task
Maniphest T275503

Html2Wt crasher in WTUtils via wikitext escape handlers during rt-testing
Closed, ResolvedPublic
Actions

Description

Argument 1 passed to Wikimedia\Parsoid\Utils\WTUtils::isFirstEncapsulationWrapperNode() must be an instance of DOMNode, null given, called in /srv/parsoid-testing/src/Html2Wt/WikitextEscapeHandlers.php on line 447
from /srv/parsoid-testing/src/Utils/WTUtils.php(486)
#0 /srv/parsoid-testing/src/Html2Wt/WikitextEscapeHandlers.php(447): Wikimedia\Parsoid\Utils\WTUtils::isFirstEncapsulationWrapperNode(NULL)
#1 /srv/parsoid-testing/src/Html2Wt/WikitextEscapeHandlers.php(1017): Wikimedia\Parsoid\Html2Wt\WikitextEscapeHandlers->textCanParseAsLink(NULL, Wikimedia\Parsoid\Html2Wt\SerializerState, string)
#2 /srv/parsoid-testing/src/Html2Wt/WikitextSerializer.php(188): Wikimedia\Parsoid\Html2Wt\WikitextEscapeHandlers->escapeWikiText(Wikimedia\Parsoid\Html2Wt\SerializerState, string, array)
#3 /srv/parsoid-testing/src/Html2Wt/SerializerState.php(623): Wikimedia\Parsoid\Html2Wt\WikitextSerializer->escapeWikiText(Wikimedia\Parsoid\Html2Wt\SerializerState, string, array)
#4 /srv/parsoid-testing/src/Html2Wt/WikitextSerializer.php(1072): Wikimedia\Parsoid\Html2Wt\SerializerState->emitChunk(Wikimedia\Parsoid\Html2Wt\ConstrainedText\ConstrainedText, DOMText)
#5 /srv/parsoid-testing/src/Html2Wt/WikitextSerializer.php(1092): Wikimedia\Parsoid\Html2Wt\WikitextSerializer->serializeText(string, DOMText, boolean)
#6 [internal function]: Wikimedia\Parsoid\Html2Wt\WikitextSerializer->serializeTextNode(DOMText, Wikimedia\Parsoid\Html2Wt\DOMHandlers\DOMHandler)
#7 /srv/parsoid-testing/src/Html2Wt/WikitextSerializer.php(1353): call_user_func(array, DOMText, Wikimedia\Parsoid\Html2Wt\DOMHandlers\DOMHandler)
#8 /srv/parsoid-testing/src/Html2Wt/SerializerState.php(715): Wikimedia\Parsoid\Html2Wt\WikitextSerializer->serializeNode(DOMText)
#9 /srv/parsoid-testing/src/Html2Wt/DOMHandlers/QuoteHandler.php(43): Wikimedia\Parsoid\Html2Wt\SerializerState->serializeChildren(DOMElement)
#10 /srv/parsoid-testing/src/Html2Wt/WikitextSerializer.php(1260): Wikimedia\Parsoid\Html2Wt\DOMHandlers\QuoteHandler->handle(DOMElement, Wikimedia\Parsoid\Html2Wt\SerializerState, boolean)
#11 [internal function]: Wikimedia\Parsoid\Html2Wt\WikitextSerializer->serializeDOMNode(DOMElement, Wikimedia\Parsoid\Html2Wt\DOMHandlers\QuoteHandler)
#12 /srv/parsoid-testing/src/Html2Wt/WikitextSerializer.php(1353): call_user_func(array, DOMElement, Wikimedia\Parsoid\Html2Wt\DOMHandlers\QuoteHandler)
#13 /srv/parsoid-testing/src/Html2Wt/SerializerState.php(715): Wikimedia\Parsoid\Html2Wt\WikitextSerializer->serializeNode(DOMElement)
#14 /srv/parsoid-testing/src/Html2Wt/DOMHandlers/FallbackHTMLHandler.php(75): Wikimedia\Parsoid\Html2Wt\SerializerState->serializeChildren(DOMElement)
#15 /srv/parsoid-testing/src/Html2Wt/WikitextSerializer.php(1260): Wikimedia\Parsoid\Html2Wt\DOMHandlers\FallbackHTMLHandler->handle(DOMElement, Wikimedia\Parsoid\Html2Wt\SerializerState, boolean)
#16 [internal function]: Wikimedia\Parsoid\Html2Wt\WikitextSerializer->serializeDOMNode(DOMElement, Wikimedia\Parsoid\Html2Wt\DOMHandlers\FallbackHTMLHandler)
#17 /srv/parsoid-testing/src/Html2Wt/WikitextSerializer.php(1353): call_user_func(array, DOMElement, Wikimedia\Parsoid\Html2Wt\DOMHandlers\FallbackHTMLHandler)
#18 /srv/parsoid-testing/src/Html2Wt/SerializerState.php(715): Wikimedia\Parsoid\Html2Wt\WikitextSerializer->serializeNode(DOMElement)
#19 /srv/parsoid-testing/src/Html2Wt/DOMHandlers/TDHandler.php(65): Wikimedia\Parsoid\Html2Wt\SerializerState->serializeChildren(DOMElement, Closure)
#20 /srv/parsoid-testing/src/Html2Wt/WikitextSerializer.php(1260): Wikimedia\Parsoid\Html2Wt\DOMHandlers\TDHandler->handle(DOMElement, Wikimedia\Parsoid\Html2Wt\SerializerState, boolean)
#21 [internal function]: Wikimedia\Parsoid\Html2Wt\WikitextSerializer->serializeDOMNode(DOMElement, Wikimedia\Parsoid\Html2Wt\DOMHandlers\TDHandler)
#22 /srv/parsoid-testing/src/Html2Wt/WikitextSerializer.php(1353): call_user_func(array, DOMElement, Wikimedia\Parsoid\Html2Wt\DOMHandlers\TDHandler)
#23 /srv/parsoid-testing/src/Html2Wt/SerializerState.php(715): Wikimedia\Parsoid\Html2Wt\WikitextSerializer->serializeNode(DOMElement)
#24 /srv/parsoid-testing/src/Html2Wt/DOMHandlers/TRHandler.php(37): Wikimedia\Parsoid\Html2Wt\SerializerState->serializeChildren(DOMElement)
#25 /srv/parsoid-testing/src/Html2Wt/WikitextSerializer.php(1260): Wikimedia\Parsoid\Html2Wt\DOMHandlers\TRHandler->handle(DOMElement, Wikimedia\Parsoid\Html2Wt\SerializerState, boolean)
#26 [internal function]: Wikimedia\Parsoid\Html2Wt\WikitextSerializer->serializeDOMNode(DOMElement, Wikimedia\Parsoid\Html2Wt\DOMHandlers\TRHandler)
#27 /srv/parsoid-testing/src/Html2Wt/WikitextSerializer.php(1353): call_user_func(array, DOMElement, Wikimedia\Parsoid\Html2Wt\DOMHandlers\TRHandler)
#28 /srv/parsoid-testing/src/Html2Wt/SerializerState.php(715): Wikimedia\Parsoid\Html2Wt\WikitextSerializer->serializeNode(DOMElement)
#29 /srv/parsoid-testing/src/Html2Wt/DOMHandlers/JustChildrenHandler.php(21): Wikimedia\Parsoid\Html2Wt\SerializerState->serializeChildren(DOMElement)
#30 /srv/parsoid-testing/src/Html2Wt/WikitextSerializer.php(1260): Wikimedia\Parsoid\Html2Wt\DOMHandlers\JustChildrenHandler->handle(DOMElement, Wikimedia\Parsoid\Html2Wt\SerializerState, boolean)
#31 [internal function]: Wikimedia\Parsoid\Html2Wt\WikitextSerializer->serializeDOMNode(DOMElement, Wikimedia\Parsoid\Html2Wt\DOMHandlers\JustChildrenHandler)
#32 /srv/parsoid-testing/src/Html2Wt/WikitextSerializer.php(1353): call_user_func(array, DOMElement, Wikimedia\Parsoid\Html2Wt\DOMHandlers\JustChildrenHandler)
#33 /srv/parsoid-testing/src/Html2Wt/SerializerState.php(715): Wikimedia\Parsoid\Html2Wt\WikitextSerializer->serializeNode(DOMElement)
#34 /srv/parsoid-testing/src/Html2Wt/DOMHandlers/TableHandler.php(38): Wikimedia\Parsoid\Html2Wt\SerializerState->serializeChildren(DOMElement)
#35 /srv/parsoid-testing/src/Html2Wt/WikitextSerializer.php(1260): Wikimedia\Parsoid\Html2Wt\DOMHandlers\TableHandler->handle(DOMElement, Wikimedia\Parsoid\Html2Wt\SerializerState, boolean)
#36 [internal function]: Wikimedia\Parsoid\Html2Wt\WikitextSerializer->serializeDOMNode(DOMElement, Wikimedia\Parsoid\Html2Wt\DOMHandlers\TableHandler)
#37 /srv/parsoid-testing/src/Html2Wt/WikitextSerializer.php(1353): call_user_func(array, DOMElement, Wikimedia\Parsoid\Html2Wt\DOMHandlers\TableHandler)
#38 /srv/parsoid-testing/src/Html2Wt/SerializerState.php(715): Wikimedia\Parsoid\Html2Wt\WikitextSerializer->serializeNode(DOMElement)
#39 /srv/parsoid-testing/src/Html2Wt/SerializerState.php(741): Wikimedia\Parsoid\Html2Wt\SerializerState->serializeChildren(DOMElement, NULL)
#40 /srv/parsoid-testing/src/Html2Wt/WikitextSerializer.php(1620): Wikimedia\Parsoid\Html2Wt\SerializerState->kickOffSerialize(DOMElement)
#41 /srv/parsoid-testing/src/Core/WikitextContentModelHandler.php(168): Wikimedia\Parsoid\Html2Wt\WikitextSerializer->serializeDOM(DOMElement)
#42 /srv/parsoid-testing/src/Parsoid.php(281): Wikimedia\Parsoid\Core\WikitextContentModelHandler->fromDOM(Wikimedia\Parsoid\Config\Env, NULL)
#43 /srv/parsoid-testing/extension/src/Rest/Handler/ParsoidHandler.php(828): Wikimedia\Parsoid\Parsoid->dom2wikitext(MWParsoid\Config\PageConfig, DOMDocument, array, NULL)
#44 /srv/parsoid-testing/extension/src/Rest/Handler/TransformHandler.php(133): MWParsoid\Rest\Handler\ParsoidHandler->html2wt(MWParsoid\Config\PageConfig, array, string)
#45 /srv/mediawiki/php-1.36.0-wmf.31/includes/Rest/Router.php(395): MWParsoid\Rest\Handler\TransformHandler->execute()
#46 /srv/mediawiki/php-1.36.0-wmf.31/includes/Rest/Router.php(322): MediaWiki\Rest\Router->executeHandler(MWParsoid\Rest\Handler\TransformHandler)
#47 /srv/mediawiki/php-1.36.0-wmf.31/includes/Rest/EntryPoint.php(165): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#48 /srv/mediawiki/php-1.36.0-wmf.31/includes/Rest/EntryPoint.php(130): MediaWiki\Rest\EntryPoint->execute()
#49 /srv/mediawiki/php-1.36.0-wmf.31/rest.php(31): MediaWiki\Rest\EntryPoint::main()
#50 /srv/mediawiki/w/rest.php(3): require(string)
#51 {main}

URL: /w/rest.php/vi.wikipedia.org/v3/transform/pagebundle/to/wikitext/Danh%20s%C3%A1ch%20phim%20VTV%20n%C4%83m%202020

Details

SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to 0.13.0-a26mediawiki/vendormaster+232 -115
WTUtils::isFirstEncapsulationWrapperNode expects a nodemediawiki/services/parsoidmaster+1 -1
Customize query in gerrit

Event Timeline

ssastry created this task.Feb 23 2021, 2:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 23 2021, 2:39 PM
ssastry triaged this task as Medium priority.Feb 23 2021, 2:55 PM
gerritbot added a comment.Feb 23 2021, 4:54 PM

Change 666410 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] WTUtils::isFirstEncapsulationWrapperNode expects a node

https://gerrit.wikimedia.org/r/666410

gerritbot added a project: Patch-For-Review.Feb 23 2021, 4:54 PM
gerritbot added a comment.Feb 23 2021, 5:15 PM

Change 666410 merged by jenkins-bot:
[mediawiki/services/parsoid@master] WTUtils::isFirstEncapsulationWrapperNode expects a node

https://gerrit.wikimedia.org/r/666410

Arlolra closed this task as Resolved.Feb 23 2021, 5:16 PM
Arlolra claimed this task.
Maintenance_bot removed a project: Patch-For-Review.Feb 23 2021, 6:10 PM
gerritbot added a comment.Mar 1 2021, 9:05 PM

Change 667711 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a26

https://gerrit.wikimedia.org/r/667711

gerritbot added a project: Patch-For-Review.Mar 1 2021, 9:05 PM
gerritbot added a comment.Mar 1 2021, 10:54 PM

Change 667711 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a26

https://gerrit.wikimedia.org/r/667711

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Mar 1 2021, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 1 2021, 11:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits