Page MenuHomePhabricator

Move WikibaseRepo TypeIdsStore to service container
Closed, ResolvedPublic

Description

This one doesn’t exist as a WikibaseRepo service, but we need it to be shared in the service container, it seems. (In several other tasks – T276312, T276245, T276064 – we ran into test failures when label conflicts on items and properties were no longer detected.)

Open questions: there is no TypeIdsStore class; the DatabaseTypeIdsStore class implements the TypeIdsAcquirer, TypeIdsLookup and TypeIdsResolver interfaces. I’m pretty sure we need the store as one service (so it’s a single shared instance), but do we call that TypeIdsStore or DatabaseTypeIdsStore? And do we register the acquirer, lookup and resolver as separate services as well?

Event Timeline

Change 668138 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] repo: move TypeIdsStore to service container

https://gerrit.wikimedia.org/r/668138

Change 668138 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] repo: move DatabaseTypeIdsStore to service container

https://gerrit.wikimedia.org/r/668138