Page MenuHomePhabricator
Create Task
Maniphest T277255

MassMessageHooks::onSkinTemplateNavigation uses hard deprecated title methods
Closed, ResolvedPublicBUG REPORT
Actions

Description

Uses Title::getNextRevisionId and Title::getPreviousRevisionId, both hard deprecated
I guess the logic to get to them isn't executed in the course of every-day editing, so it wasn't noticed? By manually manipulating my url to
https://meta.wikimedia.org/w/index.php?title=User:DannyS712/Global_watchlist/Updates&diff=21140244&oldid=21135074&direction=next and
https://meta.wikimedia.org/w/index.php?title=User:DannyS712/Global_watchlist/Updates&diff=21140244&oldid=21135074&direction=prev triggered the deprecations

[YEqxJXgkpBWUf0W1SfI6IQAAAEQ] /w/index.php?title=User:DannyS712/Global_watchlist/Updates&diff=21140244&oldid=21135074&direction=next   ErrorException: Use of Title::getNextRevisionID was deprecated in MediaWiki 1.34. [Called from MediaWiki\MassMessage\MassMessageHooks::onSkinTemplateNavigation]
[YEqxcq4x0sbnZX2Y4WJR0gAAAM4] /w/index.php?title=User:DannyS712/Global_watchlist/Updates&diff=21140244&oldid=21135074&direction=prev   ErrorException: Use of Title::getPreviousRevisionID was deprecated in MediaWiki 1.34. [Called from MediaWiki\MassMessage\MassMessageHooks::onSkinTemplateNavigation]

Details

SubjectRepoBranchLines +/-
Fix hard deprecation warnings in MasMessageHooksmediawiki/extensions/MassMessagemaster+5 -3
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Mar 12 2021, 12:12 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptMar 12 2021, 12:12 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 changed the subtype of this task from "Task" to "Bug Report".Mar 12 2021, 12:12 AM
DannyS712 moved this task from Unsorted to Reports on the User-DannyS712 board.
gerritbot added a comment.Mar 15 2021, 6:26 PM

Change 672503 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/MassMessage@master] Fix hard deprecation warnings in MasMessageHooks

https://gerrit.wikimedia.org/r/672503

gerritbot added a project: Patch-For-Review.Mar 15 2021, 6:26 PM
Urbanecm claimed this task.Mar 15 2021, 6:27 PM
Restricted Application added a project: User-Urbanecm. · View Herald TranscriptMar 15 2021, 6:27 PM
Urbanecm moved this task from Backlog to Waiting on review on the User-Urbanecm board.Mar 15 2021, 6:27 PM
• AMooney edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Engineering.Mar 16 2021, 2:10 PM
gerritbot added a comment.Jan 26 2022, 9:18 AM

Change 672503 abandoned by Nikerabbit:

[mediawiki/extensions/MassMessage@master] Fix hard deprecation warnings in MasMessageHooks

Reason:

Fixed in If27bb6b5142d09bc9293d080e97b6642462219f4

https://gerrit.wikimedia.org/r/672503

Nikerabbit closed this task as Resolved.Jan 26 2022, 9:19 AM
Nikerabbit subscribed.

This was fixed in rEMAM12ef1e4692e0: Remove use of hard-deprecated Title methods.

Maintenance_bot removed a project: Patch-For-Review.Jan 26 2022, 10:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL