Score generatePngAndMidi.sh hides individual shell commands
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Mar 22 2021, 8:58 PM

Description

generatePngAndMidi.sh is a wrapper that runs various commands instead of having MediaWiki shell out to them directly. One downside is that the individual shell commands being run don't get logged, just generatePngAndMidi.sh. Could we do something like set -x in the script? Or something to that effect at least.

Details

	Subject	Repo	Branch	Lines +/-
	Trace command execution in generatePngAndMidi.sh	mediawiki/extensions/Score	REL1_39	+16 -10
	Trace command execution in generatePngAndMidi.sh	mediawiki/extensions/Score	master	+16 -10

Customize query in gerrit

Event Timeline

Legoktm created this task.Mar 22 2021, 8:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 22 2021, 8:58 PM

Change 815828 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/Score@master] Trace command execution in generatePngAndMidi.sh

https://gerrit.wikimedia.org/r/815828

gerritbot added a project: Patch-For-Review.Jul 21 2022, 4:11 AM

set -x is noisy and breaks errorExit() by inserting trace messages in between the arguments. But it was possible to wrap the main commands with a DIY equivalent.

Change 815828 merged by jenkins-bot:

[mediawiki/extensions/Score@master] Trace command execution in generatePngAndMidi.sh

https://gerrit.wikimedia.org/r/815828

Maintenance_bot removed a project: Patch-For-Review.Oct 20 2022, 12:30 AM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.7; 2022-10-24).Oct 20 2022, 1:00 AM

Sorry I missed this in my review queue somehow. Thank you!

tstarling closed this task as Resolved.Nov 23 2022, 3:20 AM

tstarling claimed this task.

Change 868531 had a related patch set uploaded (by Reedy; author: Tim Starling):

[mediawiki/extensions/Score@REL1_39] Trace command execution in generatePngAndMidi.sh

https://gerrit.wikimedia.org/r/868531

gerritbot added a project: Patch-For-Review.Dec 16 2022, 6:26 PM

Change 868531 merged by jenkins-bot: